target-ppc: fix SPE evsplat* instructions
PATCH 1/1 target-ppc: fix SPE evsplat* instructions
The shifts in the gen_evsplat* functions were expecting rA to be masked, not extracted, and so used the wrong shift amounts to sign-extend or pad with zeroes.
Signed-off-by Nathan Froyd <[email protected]>
--- target-ppc/translate.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
target-ppc/translate.c +2 -2
@@ -7001,7 +7001,7 @@ static inline void gen_evmergelohi(DisasContext *ctx) }static inline void gen_evsplati (DisasContext *ctx) { -uint64_t imm = ((int32_t )(rA (ctx->opcode) <<11 )) >>27 ; +uint64_t imm = ((int32_t )(rA (ctx->opcode) <<27 )) >>27 ;#if defined(TARGET_PPC64 )tcg_gen_movi_tl (cpu_gpr[rD (ctx->opcode)], (imm <<32 ) | imm);
@@ -7012,7 +7012,7 @@ static inline void gen_evsplati(DisasContext *ctx) }static inline void gen_evsplatfi (DisasContext *ctx) { -uint64_t imm =rA (ctx->opcode) <<11 ; +uint64_t imm =rA (ctx->opcode) <<27 ;#if defined(TARGET_PPC64 )tcg_gen_movi_tl (cpu_gpr[rD (ctx->opcode)], (imm <<32 ) | imm);
Signature · 1 line
1.6.3.2
Aurelien Jarno
AppliedQuoted 5 lines · Nathan Froyd
The shifts in the gen_evsplat* functions were expecting rA to be masked, not extracted, and so used the wrong shift amounts to sign-extend or pad with zeroes.
Signed-off-by Nathan Froyd <[email protected]>
Thanks, applied.
Quoted 32 lines
--- target-ppc/translate.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)target-ppc/translate.c +2
-2@@ -7001,7 +7001,7 @@ static inline void gen_evmergelohi(DisasContext *ctx) }static inline void gen_evsplati (DisasContext *ctx) { -uint64_t imm = ((int32_t )(rA (ctx->opcode) <<11 )) >>27 ; +uint64_t imm = ((int32_t )(rA (ctx->opcode) <<27 )) >>27 ;#if defined(TARGET_PPC64 )tcg_gen_movi_tl (cpu_gpr[rD (ctx->opcode)], (imm <<32 ) | imm);@@ -7012,7 +7012,7 @@ static inline void gen_evsplati(DisasContext *ctx) }static inline void gen_evsplatfi (DisasContext *ctx) { -uint64_t imm =rA (ctx->opcode) <<11 ; +uint64_t imm =rA (ctx->opcode) <<27 ;#if defined(TARGET_PPC64 )tcg_gen_movi_tl (cpu_gpr[rD (ctx->opcode)], (imm <<32 ) | imm);Signature · 1 line
1.6.3.2
Signature · 2 lines
Aurelien Jarno GPG: 1024D/F1BCDB73 [email protected] http://www.aurel32.net