omap3: Fix EHCI port for IGEP v2 board.
Subsystems (3)
PATCH RESEND 1/1 omap3: Fix EHCI port for IGEP v2 board.
From: Enric Balletbo i Serra <[email protected]>
IGEP v2 uses EHCI port 1 instead of EHCI port 2.
--- arch/arm/mach-omap2/board-igep0020.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/mach-omap2/board-igep0020.c +4 -4
@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = { };static const struct ehci_hcd_omap_platform_data ehci_pdata__initconst = { - .port_mode[0 ] =EHCI_HCD_OMAP_MODE_UNKNOWN , - .port_mode[1 ] =EHCI_HCD_OMAP_MODE_PHY , + .port_mode[0 ] =EHCI_HCD_OMAP_MODE_PHY , + .port_mode[1 ] =EHCI_HCD_OMAP_MODE_UNKNOWN , .port_mode[2 ] =EHCI_HCD_OMAP_MODE_UNKNOWN , .phy_reset = true, - .reset_gpio_port[0 ] = -EINVAL , - .reset_gpio_port[1 ] =IGEP2_GPIO_USBH_NRESET , + .reset_gpio_port[0 ] =IGEP2_GPIO_USBH_NRESET , + .reset_gpio_port[1 ] = -EINVAL , .reset_gpio_port[2 ] = -EINVAL , };
Signature · 1 line
1.5.4.3
Hi,
Quoted 5 lines · Enric Balletbo i Serra
arch/arm/mach-omap2/board-igep0020.c +0
-1@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = { };static const struct ehci_hcd_omap_platform_data ehci_pdata__initconst = { - .port_mode[0 ] =EHCI_HCD_OMAP_MODE_UNKNOWN ,
arch/arm/mach-omap2/board-igep0020.c static struct omap_musb_board_data musb_board_data = { · line 467
Quoted 10 lines
arch/arm/mach-omap2/board-igep0020.c +4
-3- .port_mode[1] = EHCI_HCD_OMAP_MODE_PHY, + .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY, + .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN, .port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN, .phy_reset = true, - .reset_gpio_port[0] = -EINVAL, - .reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET, + .reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET, + .reset_gpio_port[1] = -EINVAL,
no way to be backwards compatible ? Is it worth to be backwards compatible ?
Signature · 1 line
balbi
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hello,
Felipe, sorry but I don't understand your questions,m maybe I'm missing something.
All IGEP v2 boards uses USB1HS EHCI port. My mistake was suppose that port_mode[1] --> EHCI USB1HS but this is not correct, the EHCI USB1HS is port_mode[0]. This patch only fixes this.
Best regards,
Enric
Quoted 24 lines
Quoted 24 lines
2010/3/15 Felipe Balbi <[email protected]>
Quoted 23 lines
Hi,
Quoted 5 lines · Enric Balletbo i Serra
arch/arm/mach-omap2/board-igep0020.c +0
-1@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = { }; static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst = { - .port_mode[0] = EHCI_HCD_OMAP_MODE_UNKNOWN,arch/arm/mach-omap2/board-igep0020.c static struct omap_musb_board_data musb_board_data = { · line 467
Quoted 10 lines
arch/arm/mach-omap2/board-igep0020.c +4
-3- .port_mode[1] = EHCI_HCD_OMAP_MODE_PHY, + .port_mode[0] = EHCI_HCD_OMAP_MODE_PHY, + .port_mode[1] = EHCI_HCD_OMAP_MODE_UNKNOWN, .port_mode[2] = EHCI_HCD_OMAP_MODE_UNKNOWN, .phy_reset = true, - .reset_gpio_port[0] = -EINVAL, - .reset_gpio_port[1] = IGEP2_GPIO_USBH_NRESET, + .reset_gpio_port[0] = IGEP2_GPIO_USBH_NRESET, + .reset_gpio_port[1] = -EINVAL,no way to be backwards compatible ? Is it worth to be backwards compatible ?
Quoted 5 lines
Quoted 4 lines
Quoted 3 lines
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
please don't top-post. Read more at [1].
Quoted 2 lines · Enric Balletb? i Serra
Felipe, sorry but I don't understand your questions,m maybe I'm missing something.
is there a IGEP v1 board available ? Are there any developers around using it ? If true, you should try to be backwards compatible.
[1] http://www.elinux.org/Netiquette
Signature · 1 line
balbi
Hi,
2010/3/15 Felipe Balbi <[email protected]>:
Quoted 3 lines
Hi,
please don't top-post. Read more at [1].
Sorry
Quoted 2 lines
is there a IGEP v1 board available ? Are there any developers around using it ? If true, you should try to be backwards compatible.
Yes, IGEP v1 is available but it's a different platform with different processor and aren't compatible.
See http://www.igep-platform.com.
- IGEPv1 is low-power and fan-less single board computer based on ATMEL ARM9 processor.
- IGEPv2 is low-power and fan-less single board computer based on
OMAP35x processor.
Regards,
--
Enric
Hi,
Quoted 3 lines · Enric Balletb? i Serra
Quoted 1 line
please don't top-post. Read more at [1].
Sorry
np
Quoted 10 lines
Yes, IGEP v1 is available but it's a different platform with different processor and aren't compatible.
See http://www.igep-platform.com.
- IGEPv1 is low-power and fan-less single board computer based on ATMEL ARM9 processor.
- IGEPv2 is low-power and fan-less single board computer based on
OMAP35x processor.
now I get it. Thanks for the info :-)
cool boards.
Signature · 1 line
balbi
Quoted 5 lines · ext Enric Balletbo i Serra
From: Enric Balletbo i Serra <[email protected]>
IGEP v2 uses EHCI port 1 instead of EHCI port 2.
Signed-off-by Enric Balletbo i Serra <[email protected]>
I'm happy with the explanation:
Quoted 33 lines
---
arch/arm/mach-omap2/board-igep0020.c| 8 ++++----1 files changed, 4 insertions(+), 4 deletions(-)arch/arm/mach-omap2/board-igep0020.c +4
-4@@ -458,13 +458,13 @@ static struct omap_musb_board_data musb_board_data = { };static const struct ehci_hcd_omap_platform_data ehci_pdata__initconst = { - .port_mode[0 ] =EHCI_HCD_OMAP_MODE_UNKNOWN , - .port_mode[1 ] =EHCI_HCD_OMAP_MODE_PHY , + .port_mode[0 ] =EHCI_HCD_OMAP_MODE_PHY , + .port_mode[1 ] =EHCI_HCD_OMAP_MODE_UNKNOWN , .port_mode[2 ] =EHCI_HCD_OMAP_MODE_UNKNOWN , .phy_reset = true, - .reset_gpio_port[0 ] = -EINVAL , - .reset_gpio_port[1 ] =IGEP2_GPIO_USBH_NRESET , + .reset_gpio_port[0 ] =IGEP2_GPIO_USBH_NRESET , + .reset_gpio_port[1 ] = -EINVAL , .reset_gpio_port[2 ] = -EINVAL , };Signature · 6 lines
1.5.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
balbi