drm/radeon/kms: clean assigning HDMI blocks to encoders
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 2/6 drm/radeon/kms: clean assigning HDMI blocks to encoders
We almost always used first HDMI block for first encoder and second for sencod. Exception was KLDSCP_LVTMA. Analyzing code picking DIG encoder shows the same behaviour. It shows HDMI block are related to DIGs, which relation we now use.
--- drivers/gpu/drm/radeon/r600_audio.c | 12 +++- drivers/gpu/drm/radeon/r600_hdmi.c | 114 +++++++++++++----------------- drivers/gpu/drm/radeon/radeon.h | 3 +- drivers/gpu/drm/radeon/radeon_encoders.c | 10 ++-- 4 files changed, 67 insertions(+), 72 deletions(-)
drivers/gpu/drm/radeon/r600_audio.c +11 -1
@@ -224,8 +224,14 @@ void r600_audio_set_clock(struct drm_encoder *encoder, int clock)struct drm_device *dev = encoder->dev;struct radeon_device *rdev = dev->dev_private;struct radeon_encoder *radeon_encoder =to_radeon_encoder (encoder); +struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv;int base_rate =48000 ; +if (!dig) { +dev_err (rdev->dev,"Setting audio clock on non-dig encoder\n" ); +return ; + } +switch (radeon_encoder->encoder_id) {case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1 :case ENCODER_OBJECT_ID_INTERNAL_LVTM1 :
@@ -245,7 +251,7 @@ void r600_audio_set_clock(struct drm_encoder *encoder, int clock)return ; } -switch (r600_audio_tmds_index (encoder)) { +switch (dig->dig_encoder) {case 0 :WREG32 (R600_AUDIO_PLL1_MUL , base_rate*50 );WREG32 (R600_AUDIO_PLL1_DIV , clock*100 );
@@ -257,6 +263,10 @@ void r600_audio_set_clock(struct drm_encoder *encoder, int clock)WREG32 (R600_AUDIO_PLL2_DIV , clock*100 );WREG32 (R600_AUDIO_CLK_SRCSEL ,1 );break ; +default : +dev_err (rdev->dev,"Unsupported DIG on encoder 0x%02X\n" , + radeon_encoder->encoder_id); +return ; } }
drivers/gpu/drm/radeon/r600_hdmi.c +49 -65
139 lines not on this page · raw message
drivers/gpu/drm/radeon/radeon.h +2 -1
@@ -1323,7 +1323,8 @@ extern int r600_audio_tmds_index(struct drm_encoder *encoder);extern void r600_audio_set_clock (struct drm_encoder *encoder,int clock);extern void r600_audio_fini (struct radeon_device *rdev);extern void r600_hdmi_init (struct drm_encoder *encoder); -extern void r600_hdmi_enable (struct drm_encoder *encoder,int enable); +extern void r600_hdmi_enable (struct drm_encoder *encoder); +extern void r600_hdmi_disable (struct drm_encoder *encoder);extern void r600_hdmi_setmode (struct drm_encoder *encoder,struct drm_display_mode *mode);extern int r600_hdmi_buffer_status_changed (struct drm_encoder *encoder); extern void r600_hdmi_update_audio_settings(struct drm_encoder *encoder,
drivers/gpu/drm/radeon/radeon_encoders.c +5 -5
@@ -593,7 +593,6 @@ atombios_digital_setup(struct drm_encoder *encoder, int action) }atom_execute_table (rdev->mode_info.atom_context, index, (uint32_t *)&args); -r600_hdmi_enable (encoder, hdmi_detected); }int
@@ -1396,9 +1395,10 @@ radeon_atom_encoder_mode_set(struct drm_encoder *encoder, }atombios_apply_encoder_quirks (encoder, adjusted_mode); -/* XXX */ -if (!ASIC_IS_DCE4 (rdev)) +if (atombios_get_encoder_mode (encoder) ==ATOM_ENCODER_MODE_HDMI ) { +r600_hdmi_enable (encoder);r600_hdmi_setmode (encoder, adjusted_mode); + } } static bool
@@ -1509,6 +1509,8 @@ static void radeon_atom_encoder_disable(struct drm_encoder *encoder)radeon_atom_encoder_dpms (encoder,DRM_MODE_DPMS_OFF );if (radeon_encoder_is_digital (encoder)) { +if (atombios_get_encoder_mode (encoder) ==ATOM_ENCODER_MODE_HDMI ) +r600_hdmi_disable (encoder); dig = radeon_encoder->enc_priv; dig->dig_encoder =-1 ; }
@@ -1659,6 +1661,4 @@ radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_id, uint32_t sudrm_encoder_helper_add (encoder, &radeon_atom_dig_helper_funcs);break ; } - -r600_hdmi_init (encoder); }
Signature · 14 lines
1.6.4.2 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
Am Samstag, den 06.03.2010, 14:03 +0100 schrieb Rafał Miłecki:
Quoted 8 lines
drivers/gpu/drm/radeon/r600_audio.c +6
-0+struct radeon_encoder_atom_dig *dig = radeon_encoder->enc_priv;int base_rate =48000 ; +if (!dig) { +dev_err (rdev->dev,"Setting audio clock on non-dig encoder\n" ); +return ; + } +
...
Quoted 5 lines
drivers/gpu/drm/radeon/r600_audio.c +1
-1-switch (r600_audio_tmds_index (encoder)) { +switch (dig->dig_encoder) {case 0 :WREG32 (R600_AUDIO_PLL1_MUL , base_rate*50 );WREG32 (R600_AUDIO_PLL1_DIV , clock*100 );
....
drivers/gpu/drm/radeon/r600_audio.c void r600_audio_set_clock(struct drm_encoder *encoder, int clock) · line 269
Quoted 7 lines
drivers/gpu/drm/radeon/r600_audio.c +4
-0WREG32 (R600_AUDIO_PLL2_DIV , clock*100 );WREG32 (R600_AUDIO_CLK_SRCSEL ,1 );break ; +default : +dev_err (rdev->dev,"Unsupported DIG on encoder 0x%02X\n" , + radeon_encoder->encoder_id); +return ;
I know that I made the suggestion to code it like this, but now I'm thinking that we should make it depend on the hdmi_offset instead of the dig_encoder number. First I'm not sure that radeon_encoder->enc_priv will always point to a radeon_encoder_atom_dig structure, and second I think the possibility of rerouting the signals on pre DCE3 makes this decision depend on the wrong index.
Currently checking this out on my hardware, so stay tuned for an update.
Regards,
Christian.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
W dniu 6 marca 2010 17:26 użytkownik Christian König
Quoted 23 lines · <[email protected]> napisał:
Am Samstag, den 06.03.2010, 14:03 +0100 schrieb Rafał Miłecki:
Quoted 8 lines
+ struct
radeon_encoder_atom_dig*dig =radeon_encoder->enc_priv; intbase_rate= 48000;+ if (!dig) {
+dev_err(rdev->dev, "Setting audio clock on non-dig encoder\n");
+ return;
+ }
+...
Quoted 5 lines
- switch (
r600_audio_tmds_index(encoder)) {
+ switch (dig->dig_encoder) {
case 0:
WREG32(R600_AUDIO_PLL1_MUL, base_rate*50);WREG32(R600_AUDIO_PLL1_DIV, clock*100);....
Quoted 7 lines
WREG32(R600_AUDIO_PLL2_DIV, clock*100);WREG32(R600_AUDIO_CLK_SRCSEL, 1);
break;
+ default:
+ dev_err(rdev->dev, "Unsupported DIG on encoder 0x%02X\n",
+radeon_encoder->encoder_id);
+ return;
Quoted 6 lines
I know that I made the suggestion to code it like this, but now I'm thinking that we should make it depend on the
hdmi_offsetinstead of thedig_encodernumber. First I'm not sure thatradeon_encoder->enc_privwill always point to aradeon_encoder_atom_digstructure, and second I think the possibility of rerouting the signals on pre DCE3 makes this decision depend on the wrong index.
Not sure about dig pointer... I think it should be always available. But indeed it can be wrong for pre-DCE3. Thanks for pointing.
Signature · 13 lines
Rafał ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
Am Samstag, den 06.03.2010, 17:26 +0100 schrieb Christian König:
Quoted 1 line
Currently checking this out on my hardware, so stay tuned for an update.
I double checked this, and using dig_encoder as the index for the clock source selection is indeed the right thing to do. Sound is working flawlessly on both connectors of my RV630, even if I switch the HDMI block assignment so the second gets used first. I could also test a RV710 and RS780 next week if this is still necessary, but at least I have no more objections in committing this code.
While at it I found something interesting, when I enabled the HDMI block for the first time after an reboot I get an "Unhandled interrupt: 21":
[ 74.076287] [drm:r600_hdmi_enable], Enabling HDMI interface @ 0x7700 for encoder 0xf [ 74.076297] [drm:r600_hdmi_calc_CTS], Using ACR timing N=4096 CTS=74250 for frequency 32000 [ 74.076304] [drm:r600_hdmi_calc_CTS], Using ACR timing N=6272 CTS=82500 for frequency 44100 [ 74.076311] [drm:r600_hdmi_calc_CTS], Using ACR timing N=6144 CTS=74250 for frequency 48000 [ 74.076340] [drm:r600_irq_process], Unhandled interrupt: 21 5
[ 143.532481] [drm:r600_hdmi_enable], Enabling HDMI interface @ 0x7400 for encoder 0x13 [ 143.532491] [drm:r600_hdmi_calc_CTS], Using ACR timing N=4096 CTS=74250 for frequency 32000 [ 143.532498] [drm:r600_hdmi_calc_CTS], Using ACR timing N=6272 CTS=82500 for frequency 44100 [ 143.532504] [drm:r600_hdmi_calc_CTS], Using ACR timing N=6144 CTS=74250 for frequency 48000 [ 143.532526] [drm:r600_irq_process], r600_irq_process start: rptr 48, wptr 64 [ 143.532535] [drm:r600_irq_process], Unhandled interrupt: 21 4
This looks like the right place to start if we want to get rid of the polling timer for the audio codec.
Christian.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
PATCH 3/6 drm/radeon/kms: add HDMI code for pre-DCE3 R6xx GPUs
In reply to a message not in the archiveOlder GPUs are little different, HDMI blocks are not hard-wired, but routable. We should just find some free HDMI block and route it to choosen encoder. In case of RS6x0 there is only one HDMI block, we don't enable HDMI on RS6x00 yet however.
--- drivers/gpu/drm/radeon/r600_hdmi.c | 71 +++++++++++++++++++++++++++++++++++- 1 files changed, 69 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/r600_hdmi.c +69 -2
@@ -417,6 +417,39 @@ void r600_hdmi_update_audio_settings(struct drm_encoder *encoder,WREG32_P (offset+R600_HDMI_CNTL ,0x04000000 , ~0x04000000 ); } +static int r600_hdmi_find_free_block (struct drm_device *dev) +{ +struct radeon_device *rdev = dev->dev_private; +struct drm_encoder *encoder; +struct radeon_encoder *radeon_encoder; +bool free_blocks[3 ] = { true, true, true }; + +list_for_each_entry (encoder, &dev->mode_config.encoder_list, head) { + radeon_encoder =to_radeon_encoder (encoder); +switch (radeon_encoder->hdmi_offset) { +case R600_HDMI_BLOCK1 : + free_blocks[0 ] = false; +break ; +case R600_HDMI_BLOCK2 : + free_blocks[1 ] = false; +break ; +case R600_HDMI_BLOCK3 : + free_blocks[2 ] = false; +break ; + } + } + +if (rdev->family ==CHIP_RS600 || rdev->family ==CHIP_RS690 ) { +return free_blocks[0 ] ?R600_HDMI_BLOCK1 :0 ; + }else if (rdev->family >=CHIP_R600 ) { +if (free_blocks[0 ]) +return R600_HDMI_BLOCK1 ; +else if (free_blocks[1 ]) +return R600_HDMI_BLOCK2 ; + } +return 0 ; +} +static void r600_hdmi_assign_block (struct drm_encoder *encoder) {struct drm_device *dev = encoder->dev;
@@ -437,6 +470,8 @@ static void r600_hdmi_assign_block(struct drm_encoder *encoder)if (ASIC_IS_DCE32 (rdev)) radeon_encoder->hdmi_config_offset = dig->dig_encoder ?R600_HDMI_CONFIG2 :R600_HDMI_CONFIG1 ; + }else if (rdev->family >=CHIP_R600 ) { + radeon_encoder->hdmi_offset =r600_hdmi_find_free_block (dev); } }
@@ -458,8 +493,24 @@ void r600_hdmi_enable(struct drm_encoder *encoder) } } -if (ASIC_IS_DCE32 (rdev) && !ASIC_IS_DCE4 (rdev)) +if (ASIC_IS_DCE32 (rdev) && !ASIC_IS_DCE4 (rdev)) {WREG32_P (radeon_encoder->hdmi_config_offset +0x4 ,0x1 , ~0x1 ); + }else if (rdev->family >=CHIP_R600 && !ASIC_IS_DCE3 (rdev)) { +int offset = radeon_encoder->hdmi_offset; +switch (radeon_encoder->encoder_id) { +case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1 : +WREG32_P (AVIVO_TMDSA_CNTL ,0x4 , ~0x4 ); +WREG32 (offset +R600_HDMI_ENABLE ,0x101 ); +break ; +case ENCODER_OBJECT_ID_INTERNAL_LVTM1 : +WREG32_P (AVIVO_LVTMA_CNTL ,0x4 , ~0x4 ); +WREG32 (offset +R600_HDMI_ENABLE ,0x105 ); +break ; +default : +dev_err (rdev->dev,"Unknown HDMI output type\n" ); +break ; + } + }DRM_DEBUG ("Enabling HDMI interface @ 0x%04X for encoder 0x%x\n" , radeon_encoder->hdmi_offset, radeon_encoder->encoder_id);
@@ -482,8 +533,24 @@ void r600_hdmi_disable(struct drm_encoder *encoder)DRM_DEBUG ("Disabling HDMI interface @ 0x%04X for encoder 0x%x\n" , radeon_encoder->hdmi_offset, radeon_encoder->encoder_id); -if (ASIC_IS_DCE32 (rdev) && !ASIC_IS_DCE4 (rdev)) +if (ASIC_IS_DCE32 (rdev) && !ASIC_IS_DCE4 (rdev)) {WREG32_P (radeon_encoder->hdmi_config_offset +0x4 ,0 , ~0x1 ); + }else if (rdev->family >=CHIP_R600 && !ASIC_IS_DCE3 (rdev)) { +int offset = radeon_encoder->hdmi_offset; +switch (radeon_encoder->encoder_id) { +case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1 : +WREG32_P (AVIVO_TMDSA_CNTL ,0 , ~0x4 ); +WREG32 (offset +R600_HDMI_ENABLE ,0 ); +break ; +case ENCODER_OBJECT_ID_INTERNAL_LVTM1 : +WREG32_P (AVIVO_LVTMA_CNTL ,0 , ~0x4 ); +WREG32 (offset +R600_HDMI_ENABLE ,0 ); +break ; +default : +dev_err (rdev->dev,"Unknown HDMI output type\n" ); +break ; + } + } radeon_encoder->hdmi_offset =0 ; radeon_encoder->hdmi_config_offset =0 ;
Signature · 14 lines
1.6.4.2 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH 0/6] HDMI clean & DCE32 support
In reply to a message not in the archive2010/3/6 Rafał Miłecki <[email protected]>:
Quoted 20 lines
This patchset cleans our HDMI code and adds support for DCE32.
It was tested on:
1) RV620 with HDMI - no regressions
2) RV635 with 2 DVI - no regressions
3) RV730 with HDMI - made it workWould be more than great if we still could get this for 2.6.34.
I could not do this work without help from Christian and Alex, so big thanks for them :)
Rafał Miłecki (6):
drm/radeon/kms: clear HDMI definitions drm/radeon/kms: clean assigning HDMI blocks to encoders drm/radeon/kms: add HDMI code for pre-DCE3 R6xx GPUs drm/radeon/kms: enable audio engine on DCE32 drm/radeon/kms: remove dead audio/HDMI code drm/radeon/kms: improve coding style a little
Quoted 10 lines
drivers/gpu/drm/radeon/r600_audio.c | 57 +++-------
drivers/gpu/drm/radeon/r600_hdmi.c| 191 +++++++++++++++++++-----------drivers/gpu/drm/radeon/r600_reg.h| 10 +-drivers/gpu/drm/radeon/radeon.h| 3 +-drivers/gpu/drm/radeon/radeon_encoders.c| 10 +-drivers/gpu/drm/radeon/radeon_mode.h| 1 +drivers/gpu/drm/radeon/rv770.c| 15 +++7 files changed, 166 insertions(+), 121 deletions(-)
Hi Rafal
What kernel do these patches apply cleanly to? Or equally is there a git tree I could pull somewhere?
Cheers
Mike
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH 0/6] HDMI clean & DCE32 support
2010/3/6 Mike Lothian <[email protected]>:
Quoted 32 lines
2010/3/6 Rafał Miłecki <[email protected]>:
Quoted 20 lines
This patchset cleans our HDMI code and adds support for DCE32.
It was tested on:
1) RV620 with HDMI - no regressions
2) RV635 with 2 DVI - no regressions
3) RV730 with HDMI - made it workWould be more than great if we still could get this for 2.6.34.
I could not do this work without help from Christian and Alex, so big thanks for them :)
Rafał Miłecki (6):
drm/radeon/kms: clear HDMI definitions drm/radeon/kms: clean assigning HDMI blocks to encoders drm/radeon/kms: add HDMI code for pre-DCE3 R6xx GPUs drm/radeon/kms: enable audio engine on DCE32 drm/radeon/kms: remove dead audio/HDMI code drm/radeon/kms: improve coding style a littleQuoted 10 lines
drivers/gpu/drm/radeon/r600_audio.c | 57 +++-------
drivers/gpu/drm/radeon/r600_hdmi.c| 191 +++++++++++++++++++-----------drivers/gpu/drm/radeon/r600_reg.h| 10 +-drivers/gpu/drm/radeon/radeon.h| 3 +-drivers/gpu/drm/radeon/radeon_encoders.c| 10 +-drivers/gpu/drm/radeon/radeon_mode.h| 1 +drivers/gpu/drm/radeon/rv770.c| 15 +++7 files changed, 166 insertions(+), 121 deletions(-)
Quoted 4 lines
Hi Rafal
What kernel do these patches apply cleanly to? Or equally is there a git tree I could pull somewhere?
I do not have own tree, I based patches on drm-linus.
Signature · 13 lines
Rafał ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- _______________________________________________ Dri-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH 0/6] HDMI clean & DCE32 support
Quoted 35 lines · Rafał Miłecki
2010/3/6 Mike Lothian <[email protected]>:
Quoted 34 lines
2010/3/6 Rafał Miłecki <[email protected]>:
Quoted 20 lines
This patchset cleans our HDMI code and adds support for DCE32.
It was tested on:
1) RV620 with HDMI - no regressions
2) RV635 with 2 DVI - no regressions
3) RV730 with HDMI - made it workWould be more than great if we still could get this for 2.6.34.
I could not do this work without help from Christian and Alex, so big thanks for them :)
Rafał Miłecki (6):
drm/radeon/kms: clear HDMI definitions drm/radeon/kms: clean assigning HDMI blocks to encoders drm/radeon/kms: add HDMI code for pre-DCE3 R6xx GPUs drm/radeon/kms: enable audio engine on DCE32 drm/radeon/kms: remove dead audio/HDMI code drm/radeon/kms: improve coding style a littleQuoted 10 lines
drivers/gpu/drm/radeon/r600_audio.c | 57 +++-------
drivers/gpu/drm/radeon/r600_hdmi.c| 191 +++++++++++++++++++-----------drivers/gpu/drm/radeon/r600_reg.h| 10 +-drivers/gpu/drm/radeon/radeon.h| 3 +-drivers/gpu/drm/radeon/radeon_encoders.c| 10 +-drivers/gpu/drm/radeon/radeon_mode.h| 1 +drivers/gpu/drm/radeon/rv770.c| 15 +++7 files changed, 166 insertions(+), 121 deletions(-)Hi Rafal
Quoted 8 lines
Quoted 2 lines
What kernel do these patches apply cleanly to? Or equally is there a git tree I could pull somewhere?
I do not have own tree, I based patches on drm-linus.
--
Rafał
Apologies I'm not used to patches
I used git apply on the drm-radeon-testing branch with the --ignore-whitespace option and it compiled cleanly
Not only that I have audio working on my system :-D
Thanks for all your hard work in this area it really is appreciated
If you're ever in Edinburgh I'll happily take you out for a night of drinking and merriment
Cheers
Mike
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
Re: [PATCH 0/6] HDMI clean & DCE32 support
In reply to a message not in the archive2010/3/6 Rafał Miłecki <[email protected]>:
Quoted 20 lines
This patchset cleans our HDMI code and adds support for DCE32.
It was tested on:
1) RV620 with HDMI - no regressions
2) RV635 with 2 DVI - no regressions
3) RV730 with HDMI - made it workWould be more than great if we still could get this for 2.6.34.
I could not do this work without help from Christian and Alex, so big thanks for them :)
Rafał Miłecki (6):
drm/radeon/kms: clear HDMI definitions drm/radeon/kms: clean assigning HDMI blocks to encoders drm/radeon/kms: add HDMI code for pre-DCE3 R6xx GPUs drm/radeon/kms: enable audio engine on DCE32 drm/radeon/kms: remove dead audio/HDMI code drm/radeon/kms: improve coding style a little
Quoted 10 lines
drivers/gpu/drm/radeon/r600_audio.c | 57 +++-------
drivers/gpu/drm/radeon/r600_hdmi.c| 191 +++++++++++++++++++-----------drivers/gpu/drm/radeon/r600_reg.h| 10 +-drivers/gpu/drm/radeon/radeon.h| 3 +-drivers/gpu/drm/radeon/radeon_encoders.c| 10 +-drivers/gpu/drm/radeon/radeon_mode.h| 1 +drivers/gpu/drm/radeon/rv770.c| 15 +++7 files changed, 166 insertions(+), 121 deletions(-)
Is there any chance we could get these updates included in the drm-radeon-testing branch?
Cheers
Mike
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
Dave Airlie
maintainerRe: [PATCH 0/6] HDMI clean & DCE32 support
Quoted 32 lines · Mike Lothian
2010/3/6 Rafał Miłecki <[email protected]>:
Quoted 20 lines
This patchset cleans our HDMI code and adds support for DCE32.
It was tested on:
1) RV620 with HDMI - no regressions
2) RV635 with 2 DVI - no regressions
3) RV730 with HDMI - made it workWould be more than great if we still could get this for 2.6.34.
I could not do this work without help from Christian and Alex, so big thanks for them :)
Rafał Miłecki (6):
drm/radeon/kms: clear HDMI definitions drm/radeon/kms: clean assigning HDMI blocks to encoders drm/radeon/kms: add HDMI code for pre-DCE3 R6xx GPUs drm/radeon/kms: enable audio engine on DCE32 drm/radeon/kms: remove dead audio/HDMI code drm/radeon/kms: improve coding style a littleQuoted 10 lines
drivers/gpu/drm/radeon/r600_audio.c | 57 +++-------
drivers/gpu/drm/radeon/r600_hdmi.c| 191 +++++++++++++++++++-----------drivers/gpu/drm/radeon/r600_reg.h| 10 +-drivers/gpu/drm/radeon/radeon.h| 3 +-drivers/gpu/drm/radeon/radeon_encoders.c| 10 +-drivers/gpu/drm/radeon/radeon_mode.h| 1 +drivers/gpu/drm/radeon/rv770.c| 15 +++7 files changed, 166 insertions(+), 121 deletions(-)
Quoted 3 lines
Is there any chance we could get these updates included in the drm-radeon-testing branch?
Should all be in there for a week or so.
Dave.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
Re: [PATCH 0/6] HDMI clean & DCE32 support
Am Freitag, den 19.03.2010, 10:36 +1000 schrieb Dave Airlie:
Quoted 6 lines · Mike Lothian
Quoted 3 lines
Is there any chance we could get these updates included in the drm-radeon-testing branch?
Should all be in there for a week or so.
I can confirm that's working very well, even on my RV710.
And having a nearly standard ubuntu karmic (the kernel is self compiled, and xorg, mesa etc... updated) on an usb stick with KMS, multihead, HDMI audio and accelerated 3D working flawlessly is definitely a big step forward.
Regards,
Christian.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--