anon_inodes: mark the anon inode private
Subsystems (2)
PATCH 1/1 anon_inodes: mark the anon inode private
Inotify was switched to use anon_inode instead of its own private filesystem which only had one inode in commit c44dcc56d2b5c7 "switch inotify_user to anon_inode"
The problem with this is that now the inotify inode is not a distinct inode which can be managed by LSMs. userspace tools which use inotify were allowed to use the inotify inode but may not have had permission to do read/write type operations on the anon_inode. After looking at the anon_inode and its users it looks like the best solution is to just mark the anon_inode as S_PRIVATE so the security system will ignore it.
--- fs/anon_inodes.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
fs/anon_inodes.c +1 -0
@@ -209,6 +209,7 @@ static struct inode *anon_inode_mkinode(void) inode->i_mode =S_IRUSR |S_IWUSR ; inode->i_uid =current_fsuid (); inode->i_gid =current_fsgid (); + inode->i_flags |=S_PRIVATE ; inode->i_atime = inode->i_mtime = inode->i_ctime =CURRENT_TIME ;return inode; }
Signature · 7 lines
1.6.5.3 -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.
Quoted 4 lines · Eric Paris
Inotify was switched to use
anon_inodeinstead of its own private filesystem which only had one inode in commitc44dcc56d2b5c7"switchinotify_usertoanon_inode"
Quoted 8 lines
The problem with this is that now the inotify inode is not a distinct inode which can be managed by LSMs. userspace tools which use inotify were allowed to use the inotify inode but may not have had permission to do read/write type operations on the
anon_inode. After looking at theanon_inodeand its users it looks like the best solution is to just mark theanon_inodeasS_PRIVATEso the security system will ignore it.Signed-off-by Eric Paris <[email protected]>
Quoted 19 lines
--- fs/anon_inodes.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)fs/anon_inodes.c +1
-0@@ -209,6 +209,7 @@ static struct inode *anon_inode_mkinode(void) inode->i_mode =S_IRUSR |S_IWUSR ; inode->i_uid =current_fsuid (); inode->i_gid =current_fsgid (); + inode->i_flags |=S_PRIVATE ; inode->i_atime = inode->i_mtime = inode->i_ctime =CURRENT_TIME ;return inode; }Signature · 1 line
1.6.5.3
Signature · 7 lines
James Morris <[email protected]> -- This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.