perf_events: remove bogus Intel Core constraint on ITLB_MISS_RETIRED
Subsystems (2)
PATCH 1/1 perf_events: remove bogus Intel Core constraint on ITLB_MISS_RETIRED
Contrary to what Vol3b section 30.4.3 leads to believe, there is no constraint on ITLB_MISS_RETIRED on Intel Core-based CPU, so remove it.
--
perf_event_intel.c | 1 - 1 file changed, 1 deletion(-)
arch/x86/kernel/cpu/perf_event_intel.c +0 -1
@@ -43,7 +43,6 @@ static struct event_constraint intel_core2_event_constraints[] =INTEL_EVENT_CONSTRAINT (0x18 ,0x1 ),/* IDLE_DURING_DIV */ INTEL_EVENT_CONSTRAINT (0x19 ,0x2 ),/* DELAYED_BYPASS */ INTEL_EVENT_CONSTRAINT (0xa1 ,0x1 ),/* RS_UOPS_DISPATCH_CYCLES */ -INTEL_EVENT_CONSTRAINT (0xc9 ,0x1 ),/* ITLB_MISS_RETIRED (T30-9) */ INTEL_EVENT_CONSTRAINT (0xcb ,0x1 ),/* MEM_LOAD_RETIRED */ EVENT_CONSTRAINT_END };
Peter Zijlstra
maintainerQuoted 3 lines · On Thu, 2010-03-11 at 12:59 -0800, [email protected] wrote:
Contrary to what Vol3b section 30.4.3 leads to believe, there is no constraint on
ITLB_MISS_RETIREDon Intel Core-based CPU, so remove it.
Is that from Intel, and will they clarify the text in the next version of the document?
Quoted 16 lines
Signed-off-by Stephane Eranian <[email protected]>--
perf_event_intel.c | 1 - 1 file changed, 1 deletion(-)arch/x86/kernel/cpu/perf_event_intel.c +0
-1@@ -43,7 +43,6 @@ static struct event_constraint intel_core2_event_constraints[] =INTEL_EVENT_CONSTRAINT (0x18 ,0x1 ),/* IDLE_DURING_DIV */ INTEL_EVENT_CONSTRAINT (0x19 ,0x2 ),/* DELAYED_BYPASS */ INTEL_EVENT_CONSTRAINT (0xa1 ,0x1 ),/* RS_UOPS_DISPATCH_CYCLES */ -INTEL_EVENT_CONSTRAINT (0xc9 ,0x1 ),/* ITLB_MISS_RETIRED (T30-9) */ INTEL_EVENT_CONSTRAINT (0xcb ,0x1 ),/* MEM_LOAD_RETIRED */ EVENT_CONSTRAINT_END };
Quoted 8 lines · Peter Zijlstra
Quoted 3 lines · On Thu, 2010-03-11 at 12:59 -0800, [email protected] wrote:
Contrary to what Vol3b section 30.4.3 leads to believe, there is no constraint on
ITLB_MISS_RETIREDon Intel Core-based CPU, so remove it.Is that from Intel, and will they clarify the text in the next version of the document?
Yes.
Quoted 20 lines
Quoted 16 lines
Signed-off-by Stephane Eranian <[email protected]>--
perf_event_intel.c | 1 -1 file changed, 1 deletion(-)arch/x86/kernel/cpu/perf_event_intel.c +0
-0@@ -43,7 +43,6 @@ static struct event_constraint intel_core2_event_constraints[] =
INTEL_EVENT_CONSTRAINT(0x18, 0x1), /*IDLE_DURING_DIV*/INTEL_EVENT_CONSTRAINT(0x19, 0x2), /*DELAYED_BYPASS*/INTEL_EVENT_CONSTRAINT(0xa1, 0x1), /*RS_UOPS_DISPATCH_CYCLES*/
-INTEL_EVENT_CONSTRAINT(0xc9, 0x1), /*ITLB_MISS_RETIRED(T30-9) */INTEL_EVENT_CONSTRAINT(0xcb, 0x1), /*MEM_LOAD_RETIRED*/EVENT_CONSTRAINT_END
};
Signature · 8 lines
Stephane Eranian | EMEA Software Engineering Google France | 38 avenue de l'Opéra | 75002 Paris Tel : +33 (0) 1 42 68 53 00 This email may be confidential or privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it went to the wrong person. Thanks