serial: timbuart: Make sure last byte is sent when port is closed
PATCH 1/1 serial: timbuart: Make sure last byte is sent when port is closed
This patched fixes a problem in early versions of the FPGA IP.
In certain situations the IP reports that the FIFO is empty, but a byte is still clocked out. If a flush is done at that point the currently clocked byte is canceled.
This causes incompatibilities with the upper layers when a port is closed, it waits until the FIFO is empty and then closes the port. During close the FIFO is flushed -> the last byte is not sent properly.
Now the FIFO is only flushed if it is reported to be non-empty. Which makes the currently clocked out byte to finish.
---
drivers/serial/timbuart.c +6 -3
@@ -69,10 +69,13 @@ static void timbuart_start_tx(struct uart_port *port)static void timbuart_flush_buffer (struct uart_port *port) { -u8 ctl =ioread8 (port->membase +TIMBUART_CTRL ) |TIMBUART_CTRL_FLSHTX ; +if (!timbuart_tx_empty (port)) { +u8 ctl =ioread8 (port->membase +TIMBUART_CTRL ) | +TIMBUART_CTRL_FLSHTX ; -iowrite8 (ctl, port->membase +TIMBUART_CTRL ); -iowrite32 (TXBF , port->membase +TIMBUART_ISR ); +iowrite8 (ctl, port->membase +TIMBUART_CTRL ); +iowrite32 (TXBF , port->membase +TIMBUART_ISR ); + } }static void timbuart_rx_chars (struct uart_port *port)
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html