Why we need to call cpu_idle() with preemption disabled
Hi, Thomas
Just traced the preemption latency of 2.6.33-rt7 on my Yeeloong netbook with the preemptoff tracer of Ftrace and found it is very big in cpu_idle(), more than 1000 us.
And found that we have called cpu_idle() in init/main.c with preemption disabled? why we need to do it? can we simply call it with preemption enabled?
init/main.c +1 -2
@@ -428,9 +428,8 @@ static noinline void __init_refok rest_init(void)*/ init_idle_bootup_task (current);preempt_enable_and_schedule (); -preempt_disable (); -/* Call into cpu_idle with preempt disabled */ +/* There is no reason for calling cpu_idle with preemption
disabled */
cpu_idle();
}
After removing that preempt_disable() and the related operations around the calling to __schedule() in the cpu_idle(), the result becomes around 200 us, which is acceptable for I have enabled several Ftrace tracers.
Best Regards,
Wu Zhangjin
Quoted 23 lines · Wu Zhangjin
Hi, Thomas
Just traced the preemption latency of 2.6.33-rt7 on my Yeeloong netbook with the preemptoff tracer of Ftrace and found it is very big in
cpu_idle(), more than 1000 us.And found that we have called
cpu_idle()ininit/main.cwith preemption disabled? why we need to do it? can we simply call it with preemption enabled?init/main.c +1
-2@@ -428,9 +428,8 @@ static noinline void __init_refok rest_init(void)*/ init_idle_bootup_task (current);preempt_enable_and_schedule (); -preempt_disable (); -/* Call into cpu_idle with preempt disabled */ +/* There is no reason for calling cpu_idle with preemption disabled */
Quoted 6 lines
cpu_idle();}
After removing that
preempt_disable()and the related operations around the calling to__schedule()in thecpu_idle(), the result becomes around 200 us, which is acceptable for I have enabled several Ftrace tracers.
The preempt disable is needed for idle since cpu_idle() expects preemption to be disabled.
But this can cause the latency tracer to do show false latencies. What you need to add in arch/mips/kernel/process.c: cpu_idle()
+ stop_critical_timings(); if (cpu_wait) (*cpu_wait)();
+ start_critical_timings();
This two functions tell the latency tracer to ignore the time spent in idle, while idle will wake up when an interrupt happens anyway.
-- Steve