Patch inclusion in stable
Hi All,
I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st patch in the series:
commit 7ef79e1045213953b87f45cf5993cc9c70c873ec
Author: Stanislaw Gruszka <[email protected]>
airo: fix setting zero length WEP key
The linux-2.6 source has another patch that adds the following line:
if (WARN_ON(keylen == 0))
Quoted 1 line
Quoted 1 line
+ return -1;
This is added through the commit 6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the 2.6.32.10 stable patches. I think it should be a part of stable patches too.
Thanks!
Warm Regards,
Surbhi.
Quoted 10 lines · Surbhi Palande
Hi All,
I had a look at the 2.6.32.10 stable patches. Had a comment on the 31st patch in the series:
commit
7ef79e1045213953b87f45cf5993cc9c70c873ec
Author: Stanislaw Gruszka <[email protected]>airo: fix setting zero length WEP key
Quoted 8 lines
The linux-2.6 source has another patch that adds the following line:
if (WARN_ON(keylen == 0))Quoted 1 line
Quoted 1 line
+ return -1;
This is added through the commit
6510b8917948283005a125c8337d3312a8a0561c. This commit is missing in the 2.6.32.10 stable patches. I think it should be a part of stable patches too.
keylen == 0 is just bug and should never happen. As we are printing calltrace in such situation user is informed of a bug. Return from function in that case is nice, but not strictly necessary.
Cheers
Stanislaw