trace-cmd: Add BUILDING and INSTALL instructions to README
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 2 lines · John Kacur
- Add BUILDING and INSTALL instructions to the README
- ChangeMakefileso that messages don't appear like errors.
Thanks,
Did you rebase your repo or do I need to pull in the other patches from the mbox?
One comment below.
Quoted 56 lines
Signed-off-by John Kacur <[email protected]>--- Makefile | 6 +++--- README | 26 ++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 3 deletions(-)Makefile +3
-3@@ -373,10 +373,10 @@ ifneq ($(dep_includes),) endif show_gui_make: - @echo "*** to build the gui, type \"make gui\" ***" + @echo "Note: to build the gui, type \"make gui\"" show_gui_done: - @echo "*** gui build complete ***" + @echo "gui build complete" PHONY += show_gui_make@@ -397,7 +397,7 @@ install_cmd: all_cmd install_plugins $(INSTALL) trace-cmd '$(bindir_SQ)' install: install_cmd - @echo "*** to install the gui, type \"make install_gui\" ***" + @echo "Note: to install the gui, type \"make install_gui\"" install_gui: install_cmd gui $(INSTALL) -d -m 755 '$(bindir_SQ)'README +15
-0@@ -9,3 +9,29 @@ These files also make up the code to create the libraries The applications are licensed under the GNU General Public License 2.0 (see COPYING) and the libraries are licensed under the GNU Lesser General Public License 2.1 (See COPYING.LIB). + +BUILDING: + +To make trace-cmd + make + +To make the gui + make gui + +INSTALL: + +To install trace-cmd + make install + +To install the gui
README These files also make up the code to create the libraries · line 36
Quoted 10 lines
README +10
-0+ make install_gui + +Note: The default install is relative to /usr/local + The default install directory is /usr/local/bin + The default plugin directory is /usr/local/share/trace-cmd/plugins + +To change the default, you can set 'prefix', eg +mkdir $HOME/test-trace +make prefix=$HOME/test-trace +make prefix=$HOME/test-trace install
Looks good, but I would use the example of this:
make prefix=~
make prefix=~ install
The above would install the executables into your home directory ~/bin and the plugins into ~/.trace-cmd/plugins
-- Steve
Quoted 1 line
README +1
-0+
Quoted 9 lines · ----- "Steven Rostedt
Quoted 2 lines · John Kacur
- Add BUILDING and INSTALL instructions to the README
- ChangeMakefileso that messages don't appear like errors.Thanks,
Did you rebase your repo or do I need to pull in the other patches from
the mbox?
I rebased the repo and did a push -f
Quoted 75 lines
One comment below.
README These files also make up the code to create the
Quoted 38 lines
Signed-off-by John Kacur <[email protected]>--- Makefile | 6 +++--- README | 26 ++++++++++++++++++++++++++ 2 files changed, 29 insertions(+), 3 deletions(-)Makefile +3
-3@@ -373,10 +373,10 @@ ifneq ($(dep_includes),) endif show_gui_make: - @echo "*** to build the gui, type \"make gui\" ***" + @echo "Note: to build the gui, type \"make gui\"" show_gui_done: - @echo "*** gui build complete ***" + @echo "gui build complete" PHONY += show_gui_make@@ -397,7 +397,7 @@ install_cmd: all_cmd install_plugins $(INSTALL) trace-cmd '$(bindir_SQ)' install: install_cmd - @echo "*** to install the gui, type \"make install_gui\" ***" + @echo "Note: to install the gui, type \"make install_gui\"" install_gui: install_cmd gui $(INSTALL) -d -m 755 '$(bindir_SQ)'README +0
-0@@ -9,3 +9,29 @@ These files also make up the code to create thelibraries
README These files also make up the code to create the · line 9
Quoted 1 line
README +0
-0The applications are licensed under the GNU General Public License2.0
Quoted 12 lines
README +10
-0(see COPYING) and the libraries are licensed under the GNU Lesser General Public License 2.1 (See COPYING.LIB). + +BUILDING: + +To make trace-cmd + make + +To make the gui + make gui + +INSTALL:README These files also make up the code to create the · line 31
Quoted 10 lines
README +10
-0+ +To install trace-cmd + make install + +To install the gui + make install_gui + +Note: The default install is relative to /usr/local + The default install directory is /usr/local/bin + The default plugin directory is
/usr/local/share/trace-cmd/pluginsREADME These files also make up the code to create the · line 36
Quoted 5 lines
README +5
-0+ +To change the default, you can set 'prefix', eg +mkdir $HOME/test-trace +make prefix=$HOME/test-trace +make prefix=$HOME/test-trace installLooks good, but I would use the example of this:
Quoted 7 lines
make prefix=~
make prefix=~ installThe above would install the executables into your home directory ~/bin
and the plugins into ~/.trace-cmd/plugins
That is an oddity, I tried to show a general case. We could append more info about that special case if you wish.
Quoted 6 lines · John Kacur
Quoted 4 lines · ----- "Steven Rostedt
Quoted 2 lines · John Kacur
- Add BUILDING and INSTALL instructions to the README
- ChangeMakefileso that messages don't appear like errors.
Quoted 8 lines
Quoted 5 lines
Thanks,
Did you rebase your repo or do I need to pull in the other patches from
the mbox?I rebased the repo and did a push -f
Thanks I'll pull it.
Quoted 16 lines
Quoted 16 lines
Review
Quoted 4 lines
(quoted diff) +4
-0+ +Note: The default install is relative to /usr/local + The default install directory is /usr/local/bin + The default plugin directory is
/usr/local/share/trace-cmd/pluginsReview
Quoted 5 lines
(quoted diff) +5
-0+ +To change the default, you can set 'prefix', eg +mkdir $HOME/test-trace +make prefix=$HOME/test-trace +make prefix=$HOME/test-trace installLooks good, but I would use the example of this:
make prefix=~
make prefix=~ install
Quoted 8 lines
Quoted 4 lines
The above would install the executables into your home directory ~/bin
and the plugins into ~/.trace-cmd/pluginsThat is an oddity, I tried to show a general case. We could append more info about that special case if you wish.
Yeah, it was the default case ;-)
The general case would probably be better to:
make prefix=/usr
-- Steve