re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver

Subject: re-submit2 [ANNOUNCEMENT] NET: usb: sierra_net.c driver
From: Elina Pasheva <[email protected]>

re-submit2:
Consolidated diffstat output.

Re-submitting based on comments from netdev community. Summary of the changes:
1. Replaced flag FLAG_ETHER with FLAG_WWAN.
2. Fixed the e-mail address for Rory Filer.

The following is a new Linux driver which exposes certain models of Sierra Wireless modems to the operating system as Network Interface Cards (NICs).

This driver requires a version of the sierra.c driver which supports blacklisting to work properly. The blacklist in sierra.c rejects the interfaces claimed by sierra_net.c. Likewise, the sierra_net.c driver only accepts (i.e. whitelists) the interface(s) used for Direct IP traffic.
The term "Direct IP" is used within Sierra Wireless to refer to these alternate data interfaces. The version of sierra.c which supports blacklisting is available from the sierra wireless knowledge base page for older kernels. It is also available in Linux kernel starting from version 2.6.31.

This driver works with all Sierra Wireless devices configured with PID=68A3 like USB305, USB306 provided the corresponding firmware version is I2.0 (for USB305) or M3.0 (for USB306) and later.
This driver will not work with earlier firmware versions than the ones shown above. In this case the driver will issue an error message indicating incompatibility and will not serve the device's DirectIP interface.

Sierra_net.c sits atop a pre-existing Linux driver called usbnet.c. A series of hook functions are provided in sierra_net.c which are called by usbnet.c in response to a particular condition such as receipt or transmission of a data packet. As such, usbnet.c does most of the work of making a modem appear to the system as a network device and for properly exchanging traffic between the USB subsystem and the Network card interface. Sierra_net.c is concerned with managing the data exchanged between the so-called Direct-IP interface and the upper layers of the operating system.

The version number of sierra_net.c driver is set to 2.0. This patch has been tested on the latest stable kernel-2.6.33.1.

---

 drivers/net/usb/Kconfig      |   10 
 drivers/net/usb/Makefile     |    2 
 drivers/net/usb/sierra_net.c |  968 +++++++++++++++++++++++++++++++++
 3 files changed, 980 insertions(+)

@@ -377,4 +377,14 @@ config USB_CDC_PHONET
 	  cellular modem, as found on most Nokia handsets with the
 	  "PC suite" USB profile.
 
+config USB_SIERRA_NET
+	tristate "DirectIP Driver for Sierra Wireless modems"
+	depends on USB_USBNET
+
+	help
+	  Choose this option if you have a Sierra Wireless DirectIP device.
+
+	  To compile this driver as a module, choose M here: the
+	  module will be called sierra_net.
+
 endmenu

@@ -22,4 +22,6 @@ obj-$(CONFIG_USB_NET_MCS7830)	+= mcs7830
 obj-$(CONFIG_USB_USBNET)	+= usbnet.o
 obj-$(CONFIG_USB_NET_INT51X1)	+= int51x1.o
 obj-$(CONFIG_USB_CDC_PHONET)	+= cdc-phonet.o
+obj-$(CONFIG_USB_SIERRA_NET)	+= sierra_net.o
+
 

From: Elina Pasheva <[email protected]>
Date: Mon, 29 Mar 2010 13:13:16 -0700

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

From: David Miller <davem-fT/PcQaiUtIeIZ0/[email protected]>
Date: Tue, 30 Mar 2010 23:09:32 -0700 (PDT)

Nevermind, reverted, it doesn't even build.

drivers/net/usb/sierra_net.c: In function 'check_ethip_packet':
drivers/net/usb/sierra_net.c:221:3: error: implicit declaration of function 'deverr'

Really, this should never ever happen, and there is simply
no excuse at all for this.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

-----Original Message-----

Well actually there is an excuse, but I'm sure you don't want to know what it is.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html


The patch was posted saying it had only been tested on 2.6.33.1.
There was failure-to-build and boot problems beyond our control with 2.6.34-rc2. Now that 2.6.34-rc3 is available (and we are able to build and boot on our Ubuntu platform) I will modify the driver to reflect the fact that deverr is no longer in existence and is replaced by another function. I will submit the modified driver tested on 2.6.34-rc3 shortly. Perhaps we should have waited until the build problem was fixed.
Regards,
Elina

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

You should be sending patches based on David Miller's net-next-2.6 or net-2.6 git repository, where he will be applying them. As this is a new driver I assume it can go into net-2.6.

Or come up with a fix yourself.

Ben.

Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html