Skip to contentSkip to conversation

mpc83xx: Fix comments on map_flash_by_law1

PATCH New Gao Ya'nan 2 participants 5 messages Apr 11, 2010

lore
Share & tools
lore

Gao Ya'nan

author
#0 lore raw

PATCH 1/2 mpc83xx: Fix comments on map_flash_by_law1

---
 cpu/mpc83xx/start.S |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
cpu/mpc83xx/start.S +2 -2
index 68bb620..d7b03a9 100644
@@ -1156,7 +1156,7 @@ map_flash_by_law1:
 	ori r4, r4, (CONFIG_SYS_FLASH_BASE)@l
 	stw r4, LBLAWBAR1(r3) /* LBLAWBAR1 <= CONFIG_SYS_FLASH_BASE */
 
-	/* Store 0x80000012 + log2(CONFIG_SYS_FLASH_SIZE) into LBLAWAR1 */
+	/* Store 0x80000012 + log2(CONFIG_SYS_FLASH_SIZE) + 1 into LBLAWAR1 */
 	lis r4, (0x80000012)@h
 	ori r4, r4, (0x80000012)@l
 	li r5, CONFIG_SYS_FLASH_SIZE
@@ -1164,7 +1164,7 @@ map_flash_by_law1:
 	addi r4, r4, 1
 	bne 1b
 
-	stw r4, LBLAWAR1(r3) /* LBLAWAR1 <= 8MB Flash Size */
+	stw r4, LBLAWAR1(r3) /* LBLAWAR1 <= Flash Size */
 	blr
 
 	/* Though all the LBIU Local Access Windows and LBC Banks will be
Signature · 1 line
1.7.0
author
#1 lore raw

PATCH 2/2 mpc83xx: {acr, spcr, sccr}_mask take more left-shifted values

---
 cpu/mpc83xx/cpu_init.c |   36 ++++++++++++++++++------------------
 1 files changed, 18 insertions(+), 18 deletions(-)
cpu/mpc83xx/cpu_init.c +18 -18
index 75b4522..f3b67ae 100644
@@ -65,16 +65,16 @@ void cpu_init_f (volatile immap_t * im)
 {
 	__be32 acr_mask =
 #ifdef CONFIG_SYS_ACR_PIPE_DEP /* Arbiter pipeline depth */
-		(ACR_PIPE_DEP << ACR_PIPE_DEP_SHIFT) |
+		ACR_PIPE_DEP |
 #endif
 #ifdef CONFIG_SYS_ACR_RPTCNT /* Arbiter repeat count */
-		(ACR_RPTCNT << ACR_RPTCNT_SHIFT) |
+		ACR_RPTCNT |
 #endif
 #ifdef CONFIG_SYS_ACR_APARK	/* Arbiter address parking mode */
-		(ACR_APARK << ACR_APARK_SHIFT) |
+		ACR_APARK |
 #endif
 #ifdef CONFIG_SYS_ACR_PARKM	/* Arbiter parking master */
-		(ACR_PARKM << ACR_PARKM_SHIFT) |
+		ACR_PARKM |
 #endif
 		0;
 	__be32 acr_val =
@@ -93,16 +93,16 @@ void cpu_init_f (volatile immap_t * im)
 		0;
 	__be32 spcr_mask =
 #ifdef CONFIG_SYS_SPCR_OPT /* Optimize transactions between CSB and other dev */
-		(SPCR_OPT << SPCR_OPT_SHIFT) |
+		SPCR_OPT |
 #endif
 #ifdef CONFIG_SYS_SPCR_TSECEP /* all eTSEC's Emergency priority */
-		(SPCR_TSECEP << SPCR_TSECEP_SHIFT) |
+		SPCR_TSECEP |
 #endif
 #ifdef CONFIG_SYS_SPCR_TSEC1EP /* TSEC1 Emergency priority */
-		(SPCR_TSEC1EP << SPCR_TSEC1EP_SHIFT) |
+		SPCR_TSEC1EP |
 #endif
 #ifdef CONFIG_SYS_SPCR_TSEC2EP /* TSEC2 Emergency priority */
-		(SPCR_TSEC2EP << SPCR_TSEC2EP_SHIFT) |
+		SPCR_TSEC2EP |
 #endif
 		0;
 	__be32 spcr_val =
@@ -121,34 +121,34 @@ void cpu_init_f (volatile immap_t * im)
 		0;
 	__be32 sccr_mask =
 #ifdef CONFIG_SYS_SCCR_ENCCM /* Encryption clock mode */
-		(SCCR_ENCCM << SCCR_ENCCM_SHIFT) |
+		SCCR_ENCCM |
 #endif
 #ifdef CONFIG_SYS_SCCR_PCICM /* PCI & DMA clock mode */
-		(SCCR_PCICM << SCCR_PCICM_SHIFT) |
+		SCCR_PCICM |
 #endif
 #ifdef CONFIG_SYS_SCCR_TSECCM /* all TSEC's clock mode */
-		(SCCR_TSECCM << SCCR_TSECCM_SHIFT) |
+		SCCR_TSECCM |
 #endif
 #ifdef CONFIG_SYS_SCCR_TSEC1CM /* TSEC1 clock mode */
-		(SCCR_TSEC1CM << SCCR_TSEC1CM_SHIFT) |
+		SCCR_TSEC1CM |
 #endif
 #ifdef CONFIG_SYS_SCCR_TSEC2CM /* TSEC2 clock mode */
-		(SCCR_TSEC2CM << SCCR_TSEC2CM_SHIFT) |
+		SCCR_TSEC2CM |
 #endif
 #ifdef CONFIG_SYS_SCCR_TSEC1ON /* TSEC1 clock switch */
-		(SCCR_TSEC1ON << SCCR_TSEC1ON_SHIFT) |
+		SCCR_TSEC1ON |
 #endif
 #ifdef CONFIG_SYS_SCCR_TSEC2ON /* TSEC2 clock switch */
-		(SCCR_TSEC2ON << SCCR_TSEC2ON_SHIFT) |
+		SCCR_TSEC2ON |
 #endif
 #ifdef CONFIG_SYS_SCCR_USBMPHCM /* USB MPH clock mode */
-		(SCCR_USBMPHCM << SCCR_USBMPHCM_SHIFT) |
+		SCCR_USBMPHCM |
 #endif
 #ifdef CONFIG_SYS_SCCR_USBDRCM /* USB DR clock mode */
-		(SCCR_USBDRCM << SCCR_USBDRCM_SHIFT) |
+		SCCR_USBDRCM |
 #endif
 #ifdef CONFIG_SYS_SCCR_SATACM /* SATA controller clock mode */
-		(SCCR_SATACM << SCCR_SATACM_SHIFT) |
+		SCCR_SATACM |
 #endif
 		0;
 	__be32 sccr_val =
Signature · 1 line
1.7.0
#2 lore raw

PATCH 2/2 mpc83xx: {acr, spcr, sccr}_mask take more left-shifted values

Dear Gao Ya'nan,

Quoted 3 lines · In message <[email protected]> you wrote:
---
 cpu/mpc83xx/cpu_init.c |   36 ++++++++++++++++++------------------
 1 files changed, 18 insertions(+), 18 deletions(-)

Again, I see zero difference between this patch and your earlier posting.

So why are you reposting at all?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is much easier to suggest solutions when you know nothing
#3 lore raw

PATCH 1/2 mpc83xx: Fix comments on map_flash_by_law1

In reply to Gao Ya'nan

Dear Gao Ya'nan,

Quoted 3 lines · In message <[email protected]> you wrote:
---
 cpu/mpc83xx/start.S |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

When reposting patches, please ALWAYS mark these as a new version in the Subject line, like this: "[PATCH 1/2 v2]".

Also, please make sure that your mailer adds or keeps correct
In-reply-to: and References: headers, so threading of messages is working and everybody can see that this reefers to some older posting of the same topic.

Finally, add a changelog below the "---" line, where you explain what exactly has been changed compare to the previous version.

Here, I see zero difference between your first patch and this one, except for the slight change of the subject line.

Such uncommented and un-threaded repostings are extremely annoying and time-consuming, as we have to try to remember if anything similkar has been posted before, look up th eold threads, and then manually compare if anything has been changesd, or what.

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The explanation requiring the fewest assumptions is the  most  likely
to be correct.                                    -- William of Occam
author
#4 lore raw

PATCH 1/2 mpc83xx: Fix comments on map_flash_by_law1

2010/4/11 Wolfgang Denk <[email protected]>:

Quoted 11 lines

Dear Gao Ya'nan,

Quoted 3 lines · In message <[email protected]> you wrote:

---
?cpu/mpc83xx/start.S | ? ?4 ++--
?1 files changed, 2 insertions(+), 2 deletions(-)

When reposting patches, please ALWAYS mark these as a new version in the Subject line, like this: "[PATCH 1/2 v2]".

Quoted 8 lines

Also, please make sure that your mailer adds or keeps correct
In-reply-to: and References: ?headers, so threading of messages is working and everybody can see that this reefers to some older posting of the same topic.

Finally, add a changelog below the "---" line, where you explain what exactly has been changed compare to the previous version.

Sorry, I'm a git newbie and post patch for u-boot first time.

Quoted 3 lines

Here, I see zero difference between your first patch and this one, except for the slight change of the subject line.

And I thought I should highlight "mpc83xx".

Quoted 20 lines

Such uncommented and un-threaded repostings are extremely annoying and time-consuming, as we have to try to remember if anything similkar has been posted before, look up th eold threads, and then manually compare if anything has been changesd, or what.

Thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The explanation requiring the fewest assumptions is the ?most ?likely to be correct. ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?-- William of Occam