Skip to contentSkip to conversation

microblaze: allow developer selection of STACKTRACE

PATCH Superseded Steven J. Magnani 3 participants 5 messages Apr 14, 2010 Microblaze architecture

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 microblaze: allow developer selection of STACKTRACE

Allow the developer to configure STACKTRACE to enable userland access to backtraces in /proc/NN/stack.

---

arch/microblaze/Kconfig +8 -0
diff -uprN a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
@@ -136,6 +136,14 @@ config PROC_DEVICETREE
 	  an image of the device tree that the kernel copies from Open
 	  Firmware or other boot firmware. If unsure, say Y here.
 
+config PROC_BACKTRACE
+	bool "Support for kernel backtraces in /proc/NN/stack"
+	default n
+	select STACKTRACE
+	help
+	  This option adds a backtrace of the kernel stack to /proc/NN/stack.
+	  If unsure, say N here.
+
 endmenu
 
 menu "Advanced setup"
maintainer
#1 lore raw
Quoted 9 lines · Steven J. Magnani

Allow the developer to configure STACKTRACE to enable userland access to backtraces in /proc/NN/stack.

---
diff -uprN a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig

arch/microblaze/Kconfig +0 -0
@@ -136,6 +136,14 @@ config PROC_DEVICETREE
 	  an image of the device tree that the kernel copies from Open

arch/microblaze/Kconfig config PROC_DEVICETREE · line 146

Quoted 10 lines
arch/microblaze/Kconfig +8 -0
 	  Firmware or other boot firmware. If unsure, say Y here.
 
+config PROC_BACKTRACE
+	bool "Support for kernel backtraces in /proc/NN/stack"
+	default n
+	select STACKTRACE
+	help
+	  This option adds a backtrace of the kernel stack to /proc/NN/stack.
+	  If unsure, say N here.
+

Why did you create new Kconfig option? /proc/NN/stack is there when you enable stacktrace support. There is not necessary to enable any new option.

Or is there any other point which I am missing?

Thanks,
Michal

Quoted 5 lines
arch/microblaze/Kconfig +0 -0
 endmenu
 
 menu "Advanced setup"
Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#2 lore raw
Quoted 24 lines · Michal Simek
Quoted 9 lines · Steven J. Magnani

Allow the developer to configure STACKTRACE to enable userland access to backtraces in /proc/NN/stack.

---
diff -uprN a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig

arch/microblaze/Kconfig +0 -0
@@ -136,6 +136,14 @@ config PROC_DEVICETREE
 	  an image of the device tree that the kernel copies from Open

arch/microblaze/Kconfig config PROC_DEVICETREE · line 146

Quoted 10 lines
arch/microblaze/Kconfig +8 -0
 	  Firmware or other boot firmware. If unsure, say Y here.
 
+config PROC_BACKTRACE
+	bool "Support for kernel backtraces in /proc/NN/stack"
+	default n
+	select STACKTRACE
+	help
+	  This option adds a backtrace of the kernel stack to /proc/NN/stack.
+	  If unsure, say N here.
+

Why did you create new Kconfig option? /proc/NN/stack is there when you enable stacktrace support. There is not necessary to enable any new option.

Quoted 1 line

Or is there any other point which I am missing?

AFAICT STACKTRACE is an embedded option that isn't presented in the menu. If all you want is /proc/NN/stack without the baggage of kmemleak, tracing, etc., I didn't see a way to configure it.

This probably belongs somewhere more generic, maybe lib/Kconfig.debug?

Steve

maintainer
#3 lore raw
Quoted 23 lines · Steven J. Magnani
Quoted 22 lines · Michal Simek
Quoted 9 lines · Steven J. Magnani

Allow the developer to configure STACKTRACE to enable userland access to backtraces in /proc/NN/stack.

---
diff -uprN a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig

arch/microblaze/Kconfig +0 -0
@@ -136,6 +136,14 @@ config PROC_DEVICETREE
 	  an image of the device tree that the kernel copies from Open

arch/microblaze/Kconfig config PROC_DEVICETREE · line 146

Quoted 10 lines
arch/microblaze/Kconfig +8 -0
 	  Firmware or other boot firmware. If unsure, say Y here.
 
+config PROC_BACKTRACE
+	bool "Support for kernel backtraces in /proc/NN/stack"
+	default n
+	select STACKTRACE
+	help
+	  This option adds a backtrace of the kernel stack to /proc/NN/stack.
+	  If unsure, say N here.
+

Why did you create new Kconfig option? /proc/NN/stack is there when you enable stacktrace support. There is not necessary to enable any new option.

Quoted 5 lines
Quoted 1 line

Or is there any other point which I am missing?

AFAICT STACKTRACE is an embedded option that isn't presented in the menu. If all you want is /proc/NN/stack without the baggage of kmemleak, tracing, etc., I didn't see a way to configure it.

Agree that you have to enable some option to get this functionality but the correct question is if someone need only this functionality.

Quoted 2 lines

This probably belongs somewhere more generic, maybe lib/Kconfig.debug?

It is more generic things.
Arnd: What do you think?

Thanks,
Michal

Quoted 4 lines

Steve

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#4 lore raw
Quoted 24 lines · Michal Simek
Quoted 18 lines
Quoted 18 lines
Quoted 5 lines

diff -uprN a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig

arch/microblaze/Kconfig 2010-04-12 22:16:01.000000000 -0500 renamed from arch/microblaze/Kconfig 2010-04-09 21:52:36.000000000 -0500 +0 -0
@@ -136,6 +136,14 @@ config PROC_DEVICETREE
      an image of the device tree that the kernel copies from Open

arch/microblaze/Kconfig 2010-04-12 22:16:01.000000000 -0500 config PROC_DEVICETREE · line 146

Quoted 10 lines
arch/microblaze/Kconfig 2010-04-12 22:16:01.000000000 -0500 renamed from arch/microblaze/Kconfig 2010-04-09 21:52:36.000000000 -0500 +8 -0
      Firmware or other boot firmware. If unsure, say Y here.
 
+config PROC_BACKTRACE
+   bool "Support for kernel backtraces in /proc/NN/stack"
+   default n
+   select STACKTRACE
+   help
+     This option adds a backtrace of the kernel stack to /proc/NN/stack.
+     If unsure, say N here.
+

Why did you create new Kconfig option? /proc/NN/stack is there when you enable stacktrace support. There is not necessary to enable any new option.

Quoted 5 lines
Quoted 1 line

Or is there any other point which I am missing?

AFAICT STACKTRACE is an embedded option that isn't presented in the menu. If all you want is /proc/NN/stack without the baggage of kmemleak, tracing, etc., I didn't see a way to configure it.

Quoted 8 lines

Agree that you have to enable some option to get this functionality but the correct question is if someone need only this functionality.

Quoted 2 lines

This probably belongs somewhere more generic, maybe lib/Kconfig.debug?

It is more generic things.
Arnd: What do you think?

CONFIG_STACKTRACE is currently silent option that can be selected by others. If there is value in having it enabled without any of the others, just make it an explicit option by adding a text to 'config BACKTRACE' in lib/Kconfig.debug.

Arnd