Skip to contentSkip to conversation

Avoid repetition of "this config may cache passwords in memory"

PATCH In review David Sommerseth 1 participant 2 messages Apr 25, 2010 – Apr 26, 2010

lore
Share & tools
lore

David Sommerseth

author
#0 lore raw

PATCH 1/1 Avoid repetition of "this config may cache passwords in memory"

From: David Sommerseth <[email protected]...>

For OpenVPN clients with long living connections, this message is repeated everytime the connection is renegotiated. This patch removes this behaviour and will only show this warning once.

Signed-off-by David Sommerseth <[email protected]...>
---
 misc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
misc.c +3 -1
index 643ffad..7052584 100644
@@ -1588,14 +1588,16 @@ void
 purge_user_pass (struct user_pass *up, const bool force)
 {
   const bool nocache = up->nocache;
+  static warn_shown = false;
   if (nocache || force)
     {
       CLEAR (*up);
       up->nocache = nocache;
     }
-  else
+  else if (!warn_shown)
     {
       msg (M_WARN, "WARNING: this configuration may cache passwords in memory -- use the auth-nocache option to prevent this");
+      warn_shown = true;
     }
 }
Signature · 1 line
1.6.6.1
author
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 16 lines · David Sommerseth

From: David Sommerseth <[email protected]...>

For OpenVPN clients with long living connections, this message is repeated everytime the connection is renegotiated. This patch removes this behaviour and will only show this warning once.

Signed-off-by David Sommerseth <[email protected]...>
---
 misc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
misc.c +0 -0
index 643ffad..7052584 100644

misc.c void · line 1591

Quoted 4 lines
misc.c +1 -0
@@ -1588,14 +1588,16 @@ void
 purge_user_pass (struct user_pass *up, const bool force)
 {
   const bool nocache = up->nocache;
+  static warn_shown = false;

Well, this came as a surprise when I just quickly looked through it now in the morning. I'll have recheck this one ... I'm pretty sure I wrote 'static bool' as the variable declaration. That's more proper anyway. I'll fix this today.

misc.c void · line 1603

Quoted 13 lines
misc.c +2 -1
   if (nocache || force)
     {
       CLEAR (*up);
       up->nocache = nocache;
     }
-  else
+  else if (!warn_shown)
     {
       msg (M_WARN, "WARNING: this configuration may cache passwords in memory -- use the auth-nocache option to prevent this");
+      warn_shown = true;
     }
 }

kind regards,

David Sommerseth
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkvVRBEACgkQDC186MBRfrpJ6ACfVC1LzHDOvzUHtSN6QSKzELSh EP8An23EMCXf3cKVILvgjXq56NHSyC6m
=e+I7
-----END PGP SIGNATURE-----