drivers: staging: dream: fix smd in makefile
Subsystems (2)
PATCH 1/1 drivers: staging: dream: fix smd in makefile
Not sure about this one.. Cause if you apply this then some SMD files don't compile anymore. There's some missing config options related to AMSS.
--- drivers/staging/dream/Makefile | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/staging/dream/Makefile +2 -1
@@ -1,5 +1,6 @@ EXTRA_CFLAGS=-Idrivers/staging/dream/include -obj-$(CONFIG_MSM_ADSP) += qdsp5/ smd/ +obj-$(CONFIG_MSM_SMD) += smd/ +obj-$(CONFIG_MSM_ADSP) += qdsp5/ obj-$(CONFIG_MSM_CAMERA) += camera/ obj-$(CONFIG_INPUT_GPIO) += gpio_axis.o gpio_event.o gpio_input.o gpio_matrix.o gpio_output.o
Signature · 1 line
1.7.0.4
Quoted 5 lines · Daniel Walker
Not sure about this one.. Cause if you apply this then some SMD files don't compile anymore. There's some missing config options related to AMSS.
NOT-Signed-off-by Daniel Walker <[email protected]>
Heh, I'm not going to apply this then :)
Quoted 4 lines
CC Greg KH <[email protected]>Cc Pavel Machek <[email protected]>--- drivers/staging/dream/Makefile | 3 ++-
With the recent progression of your arch tree, and the wakelock/suspend-blocker stuff, what's the need for these files to still be in the staging directory at all? Can't it be deleted and it go through your tree?
thanks,
greg k-h
Quoted 14 lines · Greg KH
Quoted 5 lines · Daniel Walker
Not sure about this one.. Cause if you apply this then some SMD files don't compile anymore. There's some missing config options related to AMSS.
NOT-Signed-off-by Daniel Walker <[email protected]>Heh, I'm not going to apply this then :)
Quoted 4 lines
CC Greg KH <[email protected]>Cc Pavel Machek <[email protected]>--- drivers/staging/dream/Makefile | 3 ++-
Quoted 4 lines
With the recent progression of your arch tree, and the wakelock/suspend-blocker stuff, what's the need for these files to still be in the staging directory at all? Can't it be deleted and it go through your tree?
Yeah, all the smd stuff can .. The rest of it should stay for now I think. I'm not ready to take on those other specific drivers, like the camera etc..
Should I just send a patch to drop the whole SMD directory then?
Daniel
Quoted 20 lines · Daniel Walker
Quoted 14 lines · Greg KH
Quoted 5 lines · Daniel Walker
Not sure about this one.. Cause if you apply this then some SMD files don't compile anymore. There's some missing config options related to AMSS.
NOT-Signed-off-by Daniel Walker <[email protected]>Heh, I'm not going to apply this then :)
Quoted 4 lines
CC Greg KH <[email protected]>Cc Pavel Machek <[email protected]>--- drivers/staging/dream/Makefile | 3 ++-Quoted 4 lines
With the recent progression of your arch tree, and the wakelock/suspend-blocker stuff, what's the need for these files to still be in the staging directory at all? Can't it be deleted and it go through your tree?
Quoted 5 lines
Yeah, all the smd stuff can .. The rest of it should stay for now I think. I'm not ready to take on those other specific drivers, like the camera etc..
Should I just send a patch to drop the whole SMD directory then?
Yes, I think so. Pavel, any objections?
thanks,
greg k-h