perf: remove __weak function hw_perf_event_init
cover perf: remove __weak function hw_perf_event_init
Hi, all
Quoted 4 lines · Peter Zijlstra
Right, I've got some definite ideas on how to go here, just need some time to implement them.
Quoted 8 lines
The first thing that needs to be done is get rid of all the
__weakfunctions (with exception of perf_callchain*, since that really is arch specific).For
hw_perf_event_init()we need to create a pmu registration facility and lookup apmu_id, either passed as an actual id found in sysfs or an open file handle from sysfs (the cpu pmu would bepmu_id0 for backwards compat).
Here are 9 small patches to remove __weak function hw_perf_event_init
[PATCH 1/9] perf: un-const struct pmu *
A new field "id" will be added to struct pmu, and the "id" is assigned at registration time, so the struct is not const any more.
[PATCH 2/9] perf: core, remove weak function hw_perf_event_init A new field "pmu_id" is added to struct perf_event_attr. 2 new functions: perf_event_register_pmu, perf_event_lookup_pmuperf_event_register_pmu: the pmu registration facilityperf_event_lookup_pmu: lookup the pmu via the passed in event->attr.pmu_id.
A new api pmu->init_event to replace hw_perf_event_init
[PATCH 3/9] perf: export registered pmus via sysfs Export pmus via sysfs /sys/devices/system/cpu/pmus/0...N The file name is the pmu id, so perf tool can use it to initialize perf_event_attr.
[PATCH 4/9] perf: x86, convert to new API pmu->init_event [PATCH 5/9] perf: arm, convert to new API pmu->init_event [PATCH 6/9] perf: powerpc, convert to new API pmu->init_event [PATCH 7/9] perf: sh, convert to new API pmu->init_event [PATCH 8/9] perf: sparc, convert to new API pmu->init_event [PATCH 9/9] perf top: set perf_event_attr->pmu_id
Thanks for any comments.
Lin Ming