fsnotify: initialize mask in fsnotify_perm
PATCH 1/1 fsnotify: initialize mask in fsnotify_perm
akpm got a warning the fsnotify_mask could be used uninitialized in fsnotify_perm(). It's not actually possible but his compiler complained about it. This patch just initializes it to 0 to shut up the compiler.
Reported-by Andrew Morton <[email protected]>
Signed-off-by Eric Paris <[email protected]>
--- include/linux/fsnotify.h | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
include/linux/fsnotify.h +5 -3
@@ -39,16 +39,18 @@ static inline int fsnotify_perm(struct file *file, int mask) {struct path *path = &file->f_path;struct inode *inode = path->dentry->d_inode; -__u32 fsnotify_mask; +__u32 fsnotify_mask =0 ;if (file->f_mode &FMODE_NONOTIFY )return 0 ;if (!(mask & (MAY_READ |MAY_OPEN )))return 0 ; -if (mask &MAY_READ ) - fsnotify_mask =FS_ACCESS_PERM ;if (mask &MAY_OPEN ) fsnotify_mask =FS_OPEN_PERM ; +else if (mask &MAY_READ ) + fsnotify_mask =FS_ACCESS_PERM ; +else +BUG ();return fsnotify (inode, fsnotify_mask, path,FSNOTIFY_EVENT_PATH ,NULL ,0 ); }
Signature · 1 line
1.6.5.3