Skip to contentSkip to conversation

x86/mmiotrace: remove redundant instruction prefix checks

PATCH In review Akinobu Mita 2 participants 3 messages May 17, 2010 – May 23, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/mmiotrace: remove redundant instruction prefix checks

Get rid of the duplicated entries in prefix_codes[] to eliminate redundant checks by skip_prefix().

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
---
 arch/x86/mm/pf_in.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/mm/pf_in.c +1 -1
index df3d5c8..308e325 100644
@@ -34,7 +34,7 @@
 /* IA32 Manual 3, 2-1 */
 static unsigned char prefix_codes[] = {
 	0xF0, 0xF2, 0xF3, 0x2E, 0x36, 0x3E, 0x26, 0x64,
-	0x65, 0x2E, 0x3E, 0x66, 0x67
+	0x65, 0x66, 0x67
 };
 /* IA32 Manual 3, 3-432*/
 static unsigned int reg_rop[] = {
Signature · 1 line
1.6.0.6
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Tue, 18 May 2010 08:48:30 +0900 Akinobu Mita <[email protected]> wrote:

Get rid of the duplicated entries in prefix_codes[] to eliminate redundant checks by skip_prefix().

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Quoted 27 lines
---
 arch/x86/mm/pf_in.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/mm/pf_in.c +1 -1
index df3d5c8..308e325 100644
@@ -34,7 +34,7 @@
 /* IA32 Manual 3, 2-1 */
 static unsigned char prefix_codes[] = {
 	0xF0, 0xF2, 0xF3, 0x2E, 0x36, 0x3E, 0x26, 0x64,
-	0x65, 0x2E, 0x3E, 0x66, 0x67
+	0x65, 0x66, 0x67
 };
 /* IA32 Manual 3, 3-432*/
 static unsigned int reg_rop[] = {
Signature · 8 lines
1.6.0.6

--
To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in the body of a message to
[email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html Please read the FAQ
at  http://www.tux.org/lkml/
Signature · 2 lines
Pekka Paalanen
http://www.iki.fi/pq/
#2 lore raw

[tip:perf/core] x86/mmiotrace: Remove redundant instruction prefix checks

In reply to Akinobu Mita
Commit-ID:  841bca1393d315d79077f272c2918423e36dc364
Gitweb:     http://git.kernel.org/tip/841bca1393d315d79077f272c2918423e36dc364
Author:     Akinobu Mita <[email protected]>
AuthorDate: Tue, 18 May 2010 08:48:30 +0900
Committer:  Ingo Molnar <[email protected]>
CommitDate: Sun, 23 May 2010 11:02:43 +0200

x86/mmiotrace: Remove redundant instruction prefix checks

Get rid of the duplicated entries in prefix_codes[] to eliminate redundant checks by skip_prefix().

LKML-Reference: <[email protected]>

---
 arch/x86/mm/pf_in.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/mm/pf_in.c +1 -1
index df3d5c8..308e325 100644
@@ -34,7 +34,7 @@
 /* IA32 Manual 3, 2-1 */
 static unsigned char prefix_codes[] = {
 	0xF0, 0xF2, 0xF3, 0x2E, 0x36, 0x3E, 0x26, 0x64,
-	0x65, 0x2E, 0x3E, 0x66, 0x67
+	0x65, 0x66, 0x67
 };
 /* IA32 Manual 3, 3-432*/
 static unsigned int reg_rop[] = {