Skip to contentSkip to conversation

arm: Adding support for TI OMAP4430 SDP

PATCH New Aneesh V 6 participants 9 messages May 25, 2010 – Jun 8, 2010

Subsystems (3)
Arm (32-bit) Kbuild Arm/actions semi architecture
lore
Share & tools
lore

Aneesh V

author
#0 lore raw

cover arm: Adding support for TI OMAP4430 SDP

The following series implements support for TI OMAP4430 SDP based TI OMAP4430.

TI OMAP4430 is a Cortex-A9 based SOC from TI. OMAP4430 is a refrence board based on OMAP4430.

The first patch in this series renames the cpu arm_cortexa8 to armv7 so that the existing cortexa8 code can be shared with cortexa9. Both A8 and A9 are based on armv7 architecture.

The second patch adds minimal support for OMAP4430 SDP. With this patch OMAP4430 SDP boots up. Other features such as MMC, ethernet etc will be added in subsequent patches.

Aneesh V (2):
arm: renaming the cpu arm_cortexa8 to armv7
arm: cortexa9: adding support for TI OMAP4430 SDP

 Makefile                                           |   28 ++-
 arch/arm/cpu/{arm_cortexa8 => armv7}/Makefile      |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/config.mk     |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/cpu.c         |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/Makefile |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/clock.c  |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/iomux.c  |    0
 .../{arm_cortexa8 => armv7}/mx51/lowlevel_init.S   |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/soc.c    |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/speed.c  |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/timer.c  |    0
 .../cpu/{arm_cortexa8 => armv7}/mx51/u-boot.lds    |    0
 .../arm/cpu/{arm_cortexa8 => armv7}/omap3/Makefile |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/board.c |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/cache.S |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/clock.c |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/gpio.c  |    0
 .../{arm_cortexa8 => armv7}/omap3/lowlevel_init.S  |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/mem.c   |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/reset.S |    0
 .../cpu/{arm_cortexa8 => armv7}/omap3/sys_info.c   |    0
 .../arm/cpu/{arm_cortexa8 => armv7}/omap3/syslib.c |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/timer.c |    0
 .../{arm_cortexa8/omap3 => armv7/omap4}/Makefile   |    7 +-
 .../{arm_cortexa8/s5pc1xx => armv7/omap4}/cache.S  |   66 +++--
 .../mx51/speed.c => armv7/omap4/lowlevel_init.S}   |   40 ++-
 arch/arm/cpu/armv7/omap4/omap4.c                   |   97 +++++++
 .../{arm_cortexa8/omap3 => armv7/omap4}/reset.S    |    0
 .../s5pc1xx/cpu_info.c => armv7/omap4/sys_info.c}  |   51 ++--
 .../{arm_cortexa8/omap3 => armv7/omap4}/timer.c    |   48 ++--
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/Makefile   |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/cache.S    |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/clock.c    |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/cpu_info.c |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/reset.S    |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/sromc.c    |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/timer.c    |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/start.S       |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/u-boot.lds    |    2 +-
 arch/arm/include/asm/arch-omap4/cpu.h              |   89 ++++++
 arch/arm/include/asm/arch-omap4/omap4.h            |  142 ++++++++++
 .../reset.S => include/asm/arch-omap4/sys_proto.h} |   38 ++--
 .../cpu/arm_cortexa8 => board/ti/sdp4430}/Makefile |   24 +-
 .../arm_cortexa8 => board/ti/sdp4430}/config.mk    |   25 +-
 .../s5pc1xx/reset.S => board/ti/sdp4430/sdp.c      |   57 +++--
 include/configs/omap4_sdp4430.h                    |  280 ++++++++++++++++++++
 46 files changed, 817 insertions(+), 177 deletions(-)
 copy arch/arm/cpu/{arm_cortexa8 => armv7}/Makefile (100%)
 copy arch/arm/cpu/{arm_cortexa8 => armv7}/config.mk (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/cpu.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/Makefile (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/clock.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/iomux.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/lowlevel_init.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/soc.c (100%)
 copy arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/speed.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/timer.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/u-boot.lds (100%)
 copy arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/Makefile (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/board.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/cache.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/clock.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/gpio.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/lowlevel_init.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/mem.c (100%)
 copy arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/reset.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/sys_info.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/syslib.c (100%)
 copy arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/timer.c (100%)
 rename arch/arm/cpu/{arm_cortexa8/omap3 => armv7/omap4}/Makefile (93%)
 copy arch/arm/cpu/{arm_cortexa8/s5pc1xx => armv7/omap4}/cache.S (73%)
 rename arch/arm/cpu/{arm_cortexa8/mx51/speed.c => armv7/omap4/lowlevel_init.S} (63%)
 create mode 100644 arch/arm/cpu/armv7/omap4/omap4.c
 copy arch/arm/cpu/{arm_cortexa8/omap3 => armv7/omap4}/reset.S (100%)
 copy arch/arm/cpu/{arm_cortexa8/s5pc1xx/cpu_info.c => armv7/omap4/sys_info.c} (51%)
 rename arch/arm/cpu/{arm_cortexa8/omap3 => armv7/omap4}/timer.c (73%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/Makefile (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/cache.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/clock.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/cpu_info.c (100%)
 copy arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/reset.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/sromc.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/timer.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/start.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/u-boot.lds (97%)
 create mode 100644 arch/arm/include/asm/arch-omap4/cpu.h
 create mode 100644 arch/arm/include/asm/arch-omap4/omap4.h
 rename arch/arm/{cpu/arm_cortexa8/omap3/reset.S => include/asm/arch-omap4/sys_proto.h} (58%)
 rename {arch/arm/cpu/arm_cortexa8 => board/ti/sdp4430}/Makefile (79%)
 rename {arch/arm/cpu/arm_cortexa8 => board/ti/sdp4430}/config.mk (54%)
 rename arch/arm/cpu/arm_cortexa8/s5pc1xx/reset.S => board/ti/sdp4430/sdp.c (58%)
 create mode 100644 include/configs/omap4_sdp4430.h
author
#1 lore raw

PATCH 1/2 arm: renaming the cpu arm_cortexa8 to armv7

Renaming the cpu arm_cortexa8 to armv7 so that we can share code between cortexa8 and cortexa9.

Both A8 and A9 belong to the armv7 architecture.
The differences between cortexa8 and cortexa9 do not impact u-boot initialization. We can have common code for both the CPUs.

Signed-off-by Aneesh V <[email protected]>
---
 Makefile                                           |   20 ++++++++++----------
 arch/arm/cpu/{arm_cortexa8 => armv7}/Makefile      |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/config.mk     |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/cpu.c         |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/Makefile |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/clock.c  |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/iomux.c  |    0
 .../{arm_cortexa8 => armv7}/mx51/lowlevel_init.S   |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/soc.c    |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/speed.c  |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/timer.c  |    0
 .../cpu/{arm_cortexa8 => armv7}/mx51/u-boot.lds    |    0
 .../arm/cpu/{arm_cortexa8 => armv7}/omap3/Makefile |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/board.c |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/cache.S |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/clock.c |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/gpio.c  |    0
 .../{arm_cortexa8 => armv7}/omap3/lowlevel_init.S  |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/mem.c   |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/reset.S |    0
 .../cpu/{arm_cortexa8 => armv7}/omap3/sys_info.c   |    0
 .../arm/cpu/{arm_cortexa8 => armv7}/omap3/syslib.c |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/timer.c |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/Makefile   |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/cache.S    |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/clock.c    |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/cpu_info.c |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/reset.S    |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/sromc.c    |    0
 .../cpu/{arm_cortexa8 => armv7}/s5pc1xx/timer.c    |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/start.S       |    0
 arch/arm/cpu/{arm_cortexa8 => armv7}/u-boot.lds    |    2 +-
 32 files changed, 11 insertions(+), 11 deletions(-)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/Makefile (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/config.mk (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/cpu.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/Makefile (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/clock.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/iomux.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/lowlevel_init.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/soc.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/speed.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/timer.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/mx51/u-boot.lds (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/Makefile (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/board.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/cache.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/clock.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/gpio.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/lowlevel_init.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/mem.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/reset.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/sys_info.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/syslib.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/omap3/timer.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/Makefile (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/cache.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/clock.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/cpu_info.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/reset.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/sromc.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/s5pc1xx/timer.c (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/start.S (100%)
 rename arch/arm/cpu/{arm_cortexa8 => armv7}/u-boot.lds (97%)
Makefile +10 -10
index 82cbbf4..0c7c130 100644
@@ -3156,31 +3156,31 @@ SMN42_config	:	unconfig
 #########################################################################
 
 devkit8000_config :	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 devkit8000 timll omap3
+	@$(MKCONFIG) $(@:_config=) arm armv7 devkit8000 timll omap3
 
 omap3_beagle_config :	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 beagle ti omap3
+	@$(MKCONFIG) $(@:_config=) arm armv7 beagle ti omap3
 
 omap3_overo_config :	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 overo NULL omap3
+	@$(MKCONFIG) $(@:_config=) arm armv7 overo NULL omap3
 
 omap3_evm_config :	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 evm ti omap3
+	@$(MKCONFIG) $(@:_config=) arm armv7 evm ti omap3
 
 omap3_pandora_config :	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 pandora NULL omap3
+	@$(MKCONFIG) $(@:_config=) arm armv7 pandora NULL omap3
 
 omap3_sdp3430_config :	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 sdp3430 ti omap3
+	@$(MKCONFIG) $(@:_config=) arm armv7 sdp3430 ti omap3
 
 omap3_zoom1_config :	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom1 logicpd omap3
+	@$(MKCONFIG) $(@:_config=) arm armv7 zoom1 logicpd omap3
 
 omap3_zoom2_config :	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 zoom2 logicpd omap3
+	@$(MKCONFIG) $(@:_config=) arm armv7 zoom2 logicpd omap3
 
 smdkc100_config:	unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 smdkc100 samsung s5pc1xx
+	@$(MKCONFIG) $(@:_config=) arm armv7 smdkc100 samsung s5pc1xx
 
 #########################################################################
 ## XScale Systems

@@ -3299,7 +3299,7 @@ mx31pdk_nand_config	: unconfig
 	@$(MKCONFIG) -a mx31pdk arm arm1136 mx31pdk freescale mx31
 
 mx51evk_config	: unconfig
-	@$(MKCONFIG) $(@:_config=) arm arm_cortexa8 mx51evk freescale mx51
+	@$(MKCONFIG) $(@:_config=) arm armv7 mx51evk freescale mx51
 
 omap2420h4_config	: unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 ti omap24xx
arch/arm/cpu/armv7/Makefile renamed from arch/arm/cpu/arm_cortexa8/Makefile +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/Makefile
rename to arch/arm/cpu/armv7/Makefile
arch/arm/cpu/armv7/config.mk renamed from arch/arm/cpu/arm_cortexa8/config.mk +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/config.mk
rename to arch/arm/cpu/armv7/config.mk
arch/arm/cpu/armv7/cpu.c renamed from arch/arm/cpu/arm_cortexa8/cpu.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/cpu.c
rename to arch/arm/cpu/armv7/cpu.c
arch/arm/cpu/armv7/mx51/Makefile renamed from arch/arm/cpu/arm_cortexa8/mx51/Makefile +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/mx51/Makefile
rename to arch/arm/cpu/armv7/mx51/Makefile
arch/arm/cpu/armv7/mx51/clock.c renamed from arch/arm/cpu/arm_cortexa8/mx51/clock.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/mx51/clock.c
rename to arch/arm/cpu/armv7/mx51/clock.c
arch/arm/cpu/armv7/mx51/iomux.c renamed from arch/arm/cpu/arm_cortexa8/mx51/iomux.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/mx51/iomux.c
rename to arch/arm/cpu/armv7/mx51/iomux.c
arch/arm/cpu/armv7/mx51/lowlevel_init.S renamed from arch/arm/cpu/arm_cortexa8/mx51/lowlevel_init.S +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/mx51/lowlevel_init.S
rename to arch/arm/cpu/armv7/mx51/lowlevel_init.S
arch/arm/cpu/armv7/mx51/soc.c renamed from arch/arm/cpu/arm_cortexa8/mx51/soc.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/mx51/soc.c
rename to arch/arm/cpu/armv7/mx51/soc.c
arch/arm/cpu/armv7/mx51/speed.c renamed from arch/arm/cpu/arm_cortexa8/mx51/speed.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/mx51/speed.c
rename to arch/arm/cpu/armv7/mx51/speed.c
arch/arm/cpu/armv7/mx51/timer.c renamed from arch/arm/cpu/arm_cortexa8/mx51/timer.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/mx51/timer.c
rename to arch/arm/cpu/armv7/mx51/timer.c
arch/arm/cpu/armv7/mx51/u-boot.lds renamed from arch/arm/cpu/arm_cortexa8/mx51/u-boot.lds +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/mx51/u-boot.lds
rename to arch/arm/cpu/armv7/mx51/u-boot.lds
arch/arm/cpu/armv7/omap3/Makefile renamed from arch/arm/cpu/arm_cortexa8/omap3/Makefile +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/Makefile
rename to arch/arm/cpu/armv7/omap3/Makefile
arch/arm/cpu/armv7/omap3/board.c renamed from arch/arm/cpu/arm_cortexa8/omap3/board.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/board.c
rename to arch/arm/cpu/armv7/omap3/board.c
arch/arm/cpu/armv7/omap3/cache.S renamed from arch/arm/cpu/arm_cortexa8/omap3/cache.S +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/cache.S
rename to arch/arm/cpu/armv7/omap3/cache.S
arch/arm/cpu/armv7/omap3/clock.c renamed from arch/arm/cpu/arm_cortexa8/omap3/clock.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/clock.c
rename to arch/arm/cpu/armv7/omap3/clock.c
arch/arm/cpu/armv7/omap3/gpio.c renamed from arch/arm/cpu/arm_cortexa8/omap3/gpio.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/gpio.c
rename to arch/arm/cpu/armv7/omap3/gpio.c
arch/arm/cpu/armv7/omap3/lowlevel_init.S renamed from arch/arm/cpu/arm_cortexa8/omap3/lowlevel_init.S +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/lowlevel_init.S
rename to arch/arm/cpu/armv7/omap3/lowlevel_init.S
arch/arm/cpu/armv7/omap3/mem.c renamed from arch/arm/cpu/arm_cortexa8/omap3/mem.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/mem.c
rename to arch/arm/cpu/armv7/omap3/mem.c
arch/arm/cpu/armv7/omap3/reset.S renamed from arch/arm/cpu/arm_cortexa8/omap3/reset.S +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/reset.S
rename to arch/arm/cpu/armv7/omap3/reset.S
arch/arm/cpu/armv7/omap3/sys_info.c renamed from arch/arm/cpu/arm_cortexa8/omap3/sys_info.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/sys_info.c
rename to arch/arm/cpu/armv7/omap3/sys_info.c
arch/arm/cpu/armv7/omap3/syslib.c renamed from arch/arm/cpu/arm_cortexa8/omap3/syslib.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/syslib.c
rename to arch/arm/cpu/armv7/omap3/syslib.c
arch/arm/cpu/armv7/omap3/timer.c renamed from arch/arm/cpu/arm_cortexa8/omap3/timer.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/omap3/timer.c
rename to arch/arm/cpu/armv7/omap3/timer.c
arch/arm/cpu/armv7/s5pc1xx/Makefile renamed from arch/arm/cpu/arm_cortexa8/s5pc1xx/Makefile +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/s5pc1xx/Makefile
rename to arch/arm/cpu/armv7/s5pc1xx/Makefile
arch/arm/cpu/armv7/s5pc1xx/cache.S renamed from arch/arm/cpu/arm_cortexa8/s5pc1xx/cache.S +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/s5pc1xx/cache.S
rename to arch/arm/cpu/armv7/s5pc1xx/cache.S
arch/arm/cpu/armv7/s5pc1xx/clock.c renamed from arch/arm/cpu/arm_cortexa8/s5pc1xx/clock.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/s5pc1xx/clock.c
rename to arch/arm/cpu/armv7/s5pc1xx/clock.c
arch/arm/cpu/armv7/s5pc1xx/cpu_info.c renamed from arch/arm/cpu/arm_cortexa8/s5pc1xx/cpu_info.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/s5pc1xx/cpu_info.c
rename to arch/arm/cpu/armv7/s5pc1xx/cpu_info.c
arch/arm/cpu/armv7/s5pc1xx/reset.S renamed from arch/arm/cpu/arm_cortexa8/s5pc1xx/reset.S +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/s5pc1xx/reset.S
rename to arch/arm/cpu/armv7/s5pc1xx/reset.S
arch/arm/cpu/armv7/s5pc1xx/sromc.c renamed from arch/arm/cpu/arm_cortexa8/s5pc1xx/sromc.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/s5pc1xx/sromc.c
rename to arch/arm/cpu/armv7/s5pc1xx/sromc.c
arch/arm/cpu/armv7/s5pc1xx/timer.c renamed from arch/arm/cpu/arm_cortexa8/s5pc1xx/timer.c +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/s5pc1xx/timer.c
rename to arch/arm/cpu/armv7/s5pc1xx/timer.c
arch/arm/cpu/armv7/start.S renamed from arch/arm/cpu/arm_cortexa8/start.S +0 -0
similarity index 100%
rename from arch/arm/cpu/arm_cortexa8/start.S
rename to arch/arm/cpu/armv7/start.S
arch/arm/cpu/armv7/u-boot.lds renamed from arch/arm/cpu/arm_cortexa8/u-boot.lds +1 -1
similarity index 97%
rename from arch/arm/cpu/arm_cortexa8/u-boot.lds
rename to arch/arm/cpu/armv7/u-boot.lds
index 820e3a1..9e5b5a9 100644
@@ -34,7 +34,7 @@ SECTIONS
 	. = ALIGN(4);
 	.text	:
 	{
-		arch/arm/cpu/arm_cortexa8/start.o	(.text)
+		arch/arm/cpu/armv7/start.o	(.text)
 		*(.text)
 	}
Signature · 1 line
1.6.0.4
author
#2 lore raw

PATCH 2/2 arm: cortexa9: adding support for TI OMAP4430 SDP

Adding support for OMAP4430 SDP board based on the TI OMAP4430 SOC.

TI OMAP4430 is an SOC based on ARM Cortex-A9 cpu. OMAP4430 SDP is a reference board based on OMAP4430.

This patch adds minimum support for booting the board.
OMAP4430 SDP does not support XIP. U-boot is loaded to SDRAM with the help of another small bootloader running from SRAM. U-boot currently relies on this bootloader for clock, mux, and SDRAM initialization.

This will change when OMAP4430 Configuration Header(CH) is attached to u-boot. CH is a feature by which ROM code can be made to intialize the clocks and SDRAM and to copy u-boot directly into SDRAM from a non-XIP device.

More support such as MMC, ethernet etc will be added in subsequent patches.

Signed-off-by Aneesh V <[email protected]>
---
 Makefile                                    |    8 +-
 arch/arm/cpu/armv7/omap4/Makefile           |   50 +++++
 arch/arm/cpu/armv7/omap4/cache.S            |  128 ++++++++++++
 arch/arm/cpu/armv7/omap4/lowlevel_init.S    |   49 +++++
 arch/arm/cpu/armv7/omap4/omap4.c            |   97 +++++++++
 arch/arm/cpu/armv7/omap4/reset.S            |   36 ++++
 arch/arm/cpu/armv7/omap4/sys_info.c         |   58 ++++++
 arch/arm/cpu/armv7/omap4/timer.c            |  140 +++++++++++++
 arch/arm/include/asm/arch-omap4/cpu.h       |   89 +++++++++
 arch/arm/include/asm/arch-omap4/omap4.h     |  142 ++++++++++++++
 arch/arm/include/asm/arch-omap4/sys_proto.h |   36 ++++
 board/ti/sdp4430/Makefile                   |   49 +++++
 board/ti/sdp4430/config.mk                  |   32 +++
 board/ti/sdp4430/sdp.c                      |   56 ++++++
 include/configs/omap4_sdp4430.h             |  280 +++++++++++++++++++++++++++
 15 files changed, 1249 insertions(+), 1 deletions(-)
 create mode 100644 arch/arm/cpu/armv7/omap4/Makefile
 create mode 100644 arch/arm/cpu/armv7/omap4/cache.S
 create mode 100644 arch/arm/cpu/armv7/omap4/lowlevel_init.S
 create mode 100644 arch/arm/cpu/armv7/omap4/omap4.c
 create mode 100644 arch/arm/cpu/armv7/omap4/reset.S
 create mode 100644 arch/arm/cpu/armv7/omap4/sys_info.c
 create mode 100644 arch/arm/cpu/armv7/omap4/timer.c
 create mode 100644 arch/arm/include/asm/arch-omap4/cpu.h
 create mode 100644 arch/arm/include/asm/arch-omap4/omap4.h
 create mode 100644 arch/arm/include/asm/arch-omap4/sys_proto.h
 create mode 100644 board/ti/sdp4430/Makefile
 create mode 100644 board/ti/sdp4430/config.mk
 create mode 100644 board/ti/sdp4430/sdp.c
 create mode 100644 include/configs/omap4_sdp4430.h
Makefile +7 -1
index 0c7c130..3fb488c 100644
@@ -3152,7 +3152,7 @@ SMN42_config	:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm arm720t SMN42 siemens lpc2292
 
 #########################################################################
-## ARM CORTEX Systems
+## ARM v7 Cortex-A8 systems
 #########################################################################
 
 devkit8000_config :	unconfig

@@ -3183,6 +3183,12 @@ smdkc100_config:	unconfig
 	@$(MKCONFIG) $(@:_config=) arm armv7 smdkc100 samsung s5pc1xx
 
 #########################################################################
+## ARM v7 CORTEX-A9 Systems
+#########################################################################
+omap4_sdp4430_config :	unconfig
+	@$(MKCONFIG) $(@:_config=) arm armv7 sdp4430 ti omap4
+
+#########################################################################
 ## XScale Systems
 #########################################################################
arch/arm/cpu/armv7/omap4/Makefile new file +50 -0

50 lines not on this page · raw message

arch/arm/cpu/armv7/omap4/cache.S new file +128 -0

128 lines not on this page · raw message

arch/arm/cpu/armv7/omap4/lowlevel_init.S new file +49 -0

49 lines not on this page · raw message

arch/arm/cpu/armv7/omap4/omap4.c new file +97 -0

97 lines not on this page · raw message

arch/arm/cpu/armv7/omap4/reset.S new file +36 -0
new file mode 100644
index 0000000..a53c408
@@ -0,0 +1,36 @@
+/*
+ * Copyright (c) 2009 Samsung Electronics.
+ * Minkyu Kang <[email protected]>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <config.h>
+
+.global reset_cpu
+reset_cpu:
+	ldr	r1, rstctl			@ get addr for global reset
+						@ reg
+	mov	r3, #0x2			@ full reset pll + mpu
+	str	r3, [r1]			@ force reset
+	mov	r0, r0
+_loop_forever:
+	b	_loop_forever
+rstctl:
+	.word	PRM_RSTCTRL
arch/arm/cpu/armv7/omap4/sys_info.c new file +58 -0

58 lines not on this page · raw message

arch/arm/cpu/armv7/omap4/timer.c new file +140 -0

140 lines not on this page · raw message

arch/arm/include/asm/arch-omap4/cpu.h new file +89 -0

89 lines not on this page · raw message

arch/arm/include/asm/arch-omap4/omap4.h new file +142 -0

142 lines not on this page · raw message

arch/arm/include/asm/arch-omap4/sys_proto.h new file +36 -0
new file mode 100644
index 0000000..29915ee
@@ -0,0 +1,36 @@
+/*
+ * (C) Copyright 2004-2008
+ * Texas Instruments, <www.ti.com>
+ * Richard Woodruff <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR /PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+  */
+#ifndef _SYS_PROTO_H_
+#define _SYS_PROTO_H_
+#include <asm/arch/omap4.h>
+#include <asm/io.h>
+
+struct omap_sysinfo {
+	char *board_string;
+};
+
+void watchdog_init (void);
+u32 get_device_type (void);
+void invalidate_dcache (u32);
+
+extern const struct omap_sysinfo sysinfo;
+
+#endif
board/ti/sdp4430/Makefile new file +49 -0

49 lines not on this page · raw message

board/ti/sdp4430/config.mk new file +32 -0
new file mode 100644
index 0000000..3c0349e
@@ -0,0 +1,32 @@
+#
+# (C) Copyright 2006-2009
+# Texas Instruments Incorporated, <www.ti.com>
+#
+# OMAP 3430 SDP uses OMAP3 (ARM-CortexA8) cpu
+# see http://www.ti.com/ for more information on Texas Instruments
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+# SDRAM Address Space:
+# 8000'0000 - 9fff'ffff (512 MB)
+# Linux-Kernel is expected to be at 8000'8000, entry 8000'8000
+# (mem base + reserved)
+
+# Let's place u-boot 1MB before the end of SDRAM.
+TEXT_BASE = 0x9ff00000
board/ti/sdp4430/sdp.c new file +56 -0

56 lines not on this page · raw message

include/configs/omap4_sdp4430.h new file +280 -0

280 lines not on this page · raw message

Signature · 1 line
1.6.0.4
#3 lore raw

PATCH 2/2 arm: cortexa9: adding support for TI OMAP4430 SDP

Aneesh:

Quoted 1 line · Aneesh V

Adding support for OMAP4430 SDP board based on the TI OMAP4430 SOC.

---

arch/arm/cpu/armv7/omap4/reset.S:
Identical to omap3 version. I think they should be shared. Perhaps have a arch/arm/cpu/armv7/omap directory for shared files.

arch/arm/cpu/armv7/omap4/timer.c:
Apart from the include of asm/arch/omap4.h this file is identical to the omap3 version. See sharing comment above.

arch/arm/include/asm/arch-omap4/cpu.h:
I think there is opportunity for sharing here as well. Not the whole file so some refactoring needs to happen.

Thanks,
John

#4 lore raw

PATCH 2/2 arm: cortexa9: adding support for TI OMAP4430 SDP

Quoted 10 lines · John Rigby

Aneesh:

Quoted 1 line · Aneesh V

Adding support for OMAP4430 SDP board based on the TI OMAP4430 SOC.

---

arch/arm/cpu/armv7/omap4/reset.S:
Identical to omap3 version. ?I think they should be shared. Perhaps have a arch/arm/cpu/armv7/omap directory for shared files.

How about we call it omap-common?

Is there a good example of how to handle this shared code? The existing build system will only build the contents of the omap4 directory and not omap-common. Offhand I don't see any other architectures that do this, so I thought I would ask before making something up :-)

Steve

Quoted 15 lines

arch/arm/cpu/armv7/omap4/timer.c:
Apart from the include of asm/arch/omap4.h this file is identical to the omap3 version. ?See sharing comment above.

arch/arm/include/asm/arch-omap4/cpu.h:
I think there is opportunity for sharing here as well. ?Not the whole file so some refactoring needs to happen.

Thanks,
John
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#5 lore raw

PATCH 2/2 arm: cortexa9: adding support for TI OMAP4430 SDP

Looks like mpc85xx and mpc86xx share:

ifeq ($(CPU),mpc85xx)
LIBS += drivers/qe/qe.a
LIBS += arch/powerpc/cpu/mpc8xxx/ddr/libddr.a
LIBS += arch/powerpc/cpu/mpc8xxx/lib8xxx.a
endif
ifeq ($(CPU),mpc86xx)
LIBS += arch/powerpc/cpu/mpc8xxx/ddr/libddr.a
LIBS += arch/powerpc/cpu/mpc8xxx/lib8xxx.a
endif

So something like
ifeq ($(SOC),omap3)
LIBS += $(CPUDIR)/omap-common/libomap-common.a
endif
ifeq(#(SOC),omap4)
LIBS += $(CPUDIR)/omap-common/libomap-common.a
endif

would work. But it is a bit brute force and not general.

You could also add a config.mk to arch/arm/cpu/armv7/omap[34] that defines SOC_COMMON as omap-common and then add

ifdef SOC_COMMON
LIBS += $(CPUDIR)/$(SOC_COMMON)/lib$(SOC_COMMON).a endif

to the root Makefile. This solution seems more clean but a little less obvious.

Quoted 43 lines · Steve Sakoman
Quoted 10 lines · John Rigby

Aneesh:

Quoted 1 line · Aneesh V

Adding support for OMAP4430 SDP board based on the TI OMAP4430 SOC.

---

arch/arm/cpu/armv7/omap4/reset.S:
Identical to omap3 version. I think they should be shared. Perhaps have a arch/arm/cpu/armv7/omap directory for shared files.

How about we call it omap-common?

Is there a good example of how to handle this shared code? The existing build system will only build the contents of the omap4 directory and not omap-common. Offhand I don't see any other architectures that do this, so I thought I would ask before making something up :-)

Steve

Quoted 6 lines

arch/arm/cpu/armv7/omap4/timer.c:
Apart from the include of asm/arch/omap4.h this file is identical to the omap3 version. See sharing comment above.

arch/arm/include/asm/arch-omap4/cpu.h:
I think there is opportunity for sharing here as well. Not the whole

file

Quoted 9 lines

so some refactoring needs to happen.

Thanks,
John
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#6 lore raw

PATCH 2/2 arm: cortexa9: adding support for TI OMAP4430 SDP

In reply to Aneesh V

Dear Aneesh V,

Quoted 10 lines · In message <[email protected]> you wrote:

Adding support for OMAP4430 SDP board based on the TI OMAP4430 SOC.

TI OMAP4430 is an SOC based on ARM Cortex-A9 cpu. OMAP4430 SDP is a reference board based on OMAP4430.

This patch adds minimum support for booting the board.
OMAP4430 SDP does not support XIP. U-boot is loaded to SDRAM with the help of another small bootloader running from SRAM. U-boot currently relies on this bootloader for clock, mux, and SDRAM initialization.

Quoted 7 lines

This will change when OMAP4430 Configuration Header(CH) is attached to u-boot. CH is a feature by which ROM code can be made to intialize the clocks and SDRAM and to copy u-boot directly into SDRAM from a non-XIP device.

More support such as MMC, ethernet etc will be added in subsequent patches.

Signed-off-by Aneesh V <[email protected]>

In addition to John's comments:

Quoted 22 lines
 Makefile                                    |    8 +-
 arch/arm/cpu/armv7/omap4/Makefile           |   50 +++++
 arch/arm/cpu/armv7/omap4/cache.S            |  128 ++++++++++++
 arch/arm/cpu/armv7/omap4/lowlevel_init.S    |   49 +++++
 arch/arm/cpu/armv7/omap4/omap4.c            |   97 +++++++++
 arch/arm/cpu/armv7/omap4/reset.S            |   36 ++++
 arch/arm/cpu/armv7/omap4/sys_info.c         |   58 ++++++
 arch/arm/cpu/armv7/omap4/timer.c            |  140 +++++++++++++
 arch/arm/include/asm/arch-omap4/cpu.h       |   89 +++++++++
 arch/arm/include/asm/arch-omap4/omap4.h     |  142 ++++++++++++++
 arch/arm/include/asm/arch-omap4/sys_proto.h |   36 ++++
 board/ti/sdp4430/Makefile                   |   49 +++++
 board/ti/sdp4430/config.mk                  |   32 +++
 board/ti/sdp4430/sdp.c                      |   56 ++++++
 include/configs/omap4_sdp4430.h             |  280 +++++++++++++++++++++++++++
 15 files changed, 1249 insertions(+), 1 deletions(-)
 create mode 100644 arch/arm/cpu/armv7/omap4/Makefile
 create mode 100644 arch/arm/cpu/armv7/omap4/cache.S
 create mode 100644 arch/arm/cpu/armv7/omap4/lowlevel_init.S
 create mode 100644 arch/arm/cpu/armv7/omap4/omap4.c
 create mode 100644 arch/arm/cpu/armv7/omap4/reset.S
 create mode 100644 arch/arm/cpu/armv7/omap4/sys_info.c
Quoted 8 lines
 create mode 100644 arch/arm/cpu/armv7/omap4/timer.c
 create mode 100644 arch/arm/include/asm/arch-omap4/cpu.h
 create mode 100644 arch/arm/include/asm/arch-omap4/omap4.h
 create mode 100644 arch/arm/include/asm/arch-omap4/sys_proto.h
 create mode 100644 board/ti/sdp4430/Makefile
 create mode 100644 board/ti/sdp4430/config.mk
 create mode 100644 board/ti/sdp4430/sdp.c
 create mode 100644 include/configs/omap4_sdp4430.h

Entries to MAKEALL and MAINTAINERS files missing.

arch/arm/cpu/armv7/omap4/omap4.c line 96

Quoted 5 lines
arch/arm/cpu/armv7/omap4/omap4.c new file +5 -0
+int checkboard (void)
+{
+	printf ("%s\n", sysinfo.board_string);
+	return 0;
+}

Consider using puts() when you don't need any output formatting.

Quoted 1 line

+#endif /* CONFIG_DISPLAY_BOARDINFO */

...

Quoted 1 line

+#ifdef CONFIG_DISPLAY_CPUINFO

These #defines have never been documented. It seems they are being copied around a lot, but I'm not sure if anybody ever does NOT set these.

I think we should at least document these - or rather drop them
everywhere. What do you think?

arch/arm/cpu/armv7/omap4/sys_info.c line 54

Quoted 3 lines
arch/arm/cpu/armv7/omap4/sys_info.c new file +3 -0
+{
+
+	printf ("CPU  : OMAP4430 ES1.0 \n");

puts()?

And: no spaces after function names please (fix globally!).

...

include/configs/omap4_sdp4430.h line 41

Quoted 9 lines
include/configs/omap4_sdp4430.h new file +9 -0
+/*
+ * High Level Configuration Options
+ */
+#define CONFIG_ARMCORTEXA9	1	/* This is an ARM V7 CPU core */
+#define CONFIG_OMAP		1	/* in a TI OMAP core */
+#define CONFIG_OMAP44XX		1	/* which is a 44XX */
+#define CONFIG_OMAP4430		1	/* which is in a 4430 */
+#define CONFIG_4430SDP		1	/* working with SDP */
+					/*#define CONFIG_FASTBOOT	1*//* Using fastboot interface */

Line too long - please check (and fix) globally.

And please don't add dead code like this.

include/configs/omap4_sdp4430.h line 117

Quoted 8 lines
include/configs/omap4_sdp4430.h new file +8 -0
+#if 0
+/* Enabled commands */
+#define CONFIG_CMD_DHCP		/* DHCP Support                 */
+#define CONFIG_CMD_EXT2		/* EXT2 Support                 */
+#define CONFIG_CMD_FAT		/* FAT support                  */
+#define CONFIG_CMD_I2C		/* I2C serial bus support       */
+#define CONFIG_CMD_MMC		/* MMC support                  */
+#endif

... or like this.

...

Quoted 5 lines

+/* SDRAM Test range - start at 16 meg boundary -ends at 1Meg -
+ * a basic sanity check ONLY
+ * IF you would like to increase coverage, increase the end address
+ * or run the test with custom options
+ */

Incorrect multiline comment style - in addition, the comment ("start at 16 meg boundary -ends at 1Meg") makes no sense to me.

include/configs/omap4_sdp4430.h line 215

Quoted 2 lines
include/configs/omap4_sdp4430.h new file +2 -0
+#define CONFIG_SYS_MEMTEST_START	0x80000000
+#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + (1 << 20))

Why would you want to test only such a small fration of your system RAM?

Quoted 6 lines

+/*
+ * Although we don't have
+ * CFI FLASH driver setup
+ * NOR boot support - single 1 Gbit PF48F6000M0 Strataflash
+ *
+ */

Can't parse this!

Quoted 1 line

+#if 0

No dead code, please.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real computer scientists don't comment their  code.  The  identifiers
are so long they can't afford the disk space.
#7 lore raw

PATCH 2/2 arm: cortexa9: adding support for TI OMAP4430 SDP

Hello Wolfgang,

Thanks for your comments. We will fix the issues you have pointed out.

Quoted 11 lines
Quoted 1 line

+#endif /* CONFIG_DISPLAY_BOARDINFO */

...

Quoted 1 line

+#ifdef CONFIG_DISPLAY_CPUINFO

These #defines have never been documented. It seems they are being copied around a lot, but I'm not sure if anybody ever does NOT set these.

I think we should at least document these - or rather drop them
everywhere. What do you think?

I'm ok with dropping it everywhere.

Quoted 7 lines

arch/arm/cpu/armv7/omap4/sys_info.c line 54

Quoted 3 lines
arch/arm/cpu/armv7/omap4/sys_info.c new file +3 -0
+{
+
+	printf ("CPU  : OMAP4430 ES1.0 \n");

puts()?

And: no spaces after function names please (fix globally!).

But how about this rule mentioned in your wiki:

"All contributions to U-Boot should conform to the Linux kernel coding style; see the file "Documentation/CodingStyle" and the script "scripts/Lindent" in your Linux kernel source directory. In sources originating from U-Boot a style corresponding to "Lindent -pcs" (adding spaces before parameters to function calls) is actually used."

http://www.denx.de/wiki/U-Boot/CodingStyle

In fact, I didn't add spaces initially. They got added when I ran "Lindent -pcs". Is this rule not applicable anymore? Or am I missing something?

Best regards,
Aneesh

Quoted 166 lines

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Sunday, June 06, 2010 1:25 AM
To: V, Aneesh
Cc: u-boot at lists.denx.de; olbpdev at list.ti.com - OMAP Linux Baseport Development Team (May contain non-TIers)
Subject: Re: [U-Boot] [PATCH 2/2] arm: cortexa9: adding support for TI OMAP4430 SDP

Dear Aneesh V,

Quoted 7 lines · In message <[email protected]> you wrote:

Adding support for OMAP4430 SDP board based on the TI OMAP4430 SOC.

TI OMAP4430 is an SOC based on ARM Cortex-A9 cpu. OMAP4430 SDP is a reference board based on OMAP4430.

This patch adds minimum support for booting the board. OMAP4430 SDP does not support XIP. U-boot is loaded to SDRAM with the

help of

Quoted 1 line

another small bootloader running from SRAM. U-boot currently relies on

this

Quoted 4 lines

bootloader for clock, mux, and SDRAM initialization.

This will change when OMAP4430 Configuration Header(CH) is attached to u-boot. CH is a feature by which ROM code can be made to intialize

the

Quoted 1 line

clocks and SDRAM and to copy u-boot directly into SDRAM from a non-XIP

device.

Quoted 2 lines

More support such as MMC, ethernet etc will be added in subsequent

patches.

Quoted 2 lines
Signed-off-by Aneesh V <[email protected]>

In addition to John's comments:

Quoted 7 lines
 Makefile                                    |    8 +-
 arch/arm/cpu/armv7/omap4/Makefile           |   50 +++++
 arch/arm/cpu/armv7/omap4/cache.S            |  128 ++++++++++++
 arch/arm/cpu/armv7/omap4/lowlevel_init.S    |   49 +++++
 arch/arm/cpu/armv7/omap4/omap4.c            |   97 +++++++++
 arch/arm/cpu/armv7/omap4/reset.S            |   36 ++++
 arch/arm/cpu/armv7/omap4/sys_info.c         |   58 ++++++
Quoted 8 lines
 arch/arm/cpu/armv7/omap4/timer.c            |  140 +++++++++++++
 arch/arm/include/asm/arch-omap4/cpu.h       |   89 +++++++++
 arch/arm/include/asm/arch-omap4/omap4.h     |  142 ++++++++++++++
 arch/arm/include/asm/arch-omap4/sys_proto.h |   36 ++++
 board/ti/sdp4430/Makefile                   |   49 +++++
 board/ti/sdp4430/config.mk                  |   32 +++
 board/ti/sdp4430/sdp.c                      |   56 ++++++
 include/configs/omap4_sdp4430.h             |  280

+++++++++++++++++++++++++++

Quoted 7 lines
 15 files changed, 1249 insertions(+), 1 deletions(-)
 create mode 100644 arch/arm/cpu/armv7/omap4/Makefile
 create mode 100644 arch/arm/cpu/armv7/omap4/cache.S
 create mode 100644 arch/arm/cpu/armv7/omap4/lowlevel_init.S
 create mode 100644 arch/arm/cpu/armv7/omap4/omap4.c
 create mode 100644 arch/arm/cpu/armv7/omap4/reset.S
 create mode 100644 arch/arm/cpu/armv7/omap4/sys_info.c
Quoted 8 lines
 create mode 100644 arch/arm/cpu/armv7/omap4/timer.c
 create mode 100644 arch/arm/include/asm/arch-omap4/cpu.h
 create mode 100644 arch/arm/include/asm/arch-omap4/omap4.h
 create mode 100644 arch/arm/include/asm/arch-omap4/sys_proto.h
 create mode 100644 board/ti/sdp4430/Makefile
 create mode 100644 board/ti/sdp4430/config.mk
 create mode 100644 board/ti/sdp4430/sdp.c
 create mode 100644 include/configs/omap4_sdp4430.h

Entries to MAKEALL and MAINTAINERS files missing.

arch/arm/cpu/armv7/omap4/omap4.c line 96

Quoted 5 lines
arch/arm/cpu/armv7/omap4/omap4.c new file +5 -0
+int checkboard (void)
+{
+	printf ("%s\n", sysinfo.board_string);
+	return 0;
+}

Consider using puts() when you don't need any output formatting.

Quoted 1 line

+#endif /* CONFIG_DISPLAY_BOARDINFO */

...

Quoted 1 line

+#ifdef CONFIG_DISPLAY_CPUINFO

These #defines have never been documented. It seems they are being copied around a lot, but I'm not sure if anybody ever does NOT set these.

I think we should at least document these - or rather drop them
everywhere. What do you think?

arch/arm/cpu/armv7/omap4/sys_info.c line 54

Quoted 3 lines
arch/arm/cpu/armv7/omap4/sys_info.c new file +3 -0
+{
+
+	printf ("CPU  : OMAP4430 ES1.0 \n");

puts()?

And: no spaces after function names please (fix globally!).

...

include/configs/omap4_sdp4430.h

Quoted 9 lines
include/configs/omap4_sdp4430.h new file +9 -0
+/*
+ * High Level Configuration Options
+ */
+#define CONFIG_ARMCORTEXA9	1	/* This is an ARM V7 CPU core */
+#define CONFIG_OMAP		1	/* in a TI OMAP core */
+#define CONFIG_OMAP44XX		1	/* which is a 44XX */
+#define CONFIG_OMAP4430		1	/* which is in a 4430 */
+#define CONFIG_4430SDP		1	/* working with SDP */
+					/*#define CONFIG_FASTBOOT	1*//* Using

fastboot interface */

Line too long - please check (and fix) globally.

And please don't add dead code like this.

include/configs/omap4_sdp4430.h line 117

Quoted 8 lines
include/configs/omap4_sdp4430.h new file +8 -0
+#if 0
+/* Enabled commands */
+#define CONFIG_CMD_DHCP		/* DHCP Support                 */
+#define CONFIG_CMD_EXT2		/* EXT2 Support                 */
+#define CONFIG_CMD_FAT		/* FAT support                  */
+#define CONFIG_CMD_I2C		/* I2C serial bus support       */
+#define CONFIG_CMD_MMC		/* MMC support                  */
+#endif

... or like this.

...

Quoted 5 lines

+/* SDRAM Test range - start at 16 meg boundary -ends at 1Meg -
+ * a basic sanity check ONLY
+ * IF you would like to increase coverage, increase the end address
+ * or run the test with custom options
+ */

Incorrect multiline comment style - in addition, the comment ("start at 16 meg boundary -ends at 1Meg") makes no sense to me.

Review

Quoted 2 lines
(quoted diff) +2 -0
+#define CONFIG_SYS_MEMTEST_START	0x80000000
+#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + (1

<< 20))

Why would you want to test only such a small fration of your system RAM?

Quoted 6 lines

+/*
+ * Although we don't have
+ * CFI FLASH driver setup
+ * NOR boot support - single 1 Gbit PF48F6000M0 Strataflash
+ *
+ */

Can't parse this!

Quoted 1 line

+#if 0

No dead code, please.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Real computer scientists don't comment their code. The identifiers are so long they can't afford the disk space.

#8 lore raw

PATCH 2/2 arm: cortexa9: adding support for TI OMAP4430 SDP

Dear "V, Aneesh",

Quoted 10 lines · In message <[email protected]> you…
Quoted 2 lines

And: no spaces after function names please (fix globally!).

But how about this rule mentioned in your wiki:

"All contributions to U-Boot should conform to the Linux kernel coding styl e; see the file "Documentation/CodingStyle" and the script "scripts/Lindent " in your Linux kernel source directory. In sources originating from U-Boot
a style corresponding to "Lindent -pcs" (adding spaces before parameters t
o function calls) is actually used."

[Could you please restrict your ine length to some 70 characters or so? Thanks!]

Quoted 4 lines

http://www.denx.de/wiki/U-Boot/CodingStyle

In fact, I didn't add spaces initially. They got added when I ran "Lindent -pcs". Is this rule not applicable anymore? Or am I missing something?

Thais was written some time ago by me, and nobody cared to fix it yet. Having the spaces was (and is) my ownporeferred style, but I got overruled by a vast majority...

Quoted 10 lines
Quoted 10 lines

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Sunday, June 06, 2010 1:25 AM
To: V, Aneesh
Cc: u-boot at lists.denx.de; olbpdev at list.ti.com - OMAP Linux Baseport Development Team (May contain non-TIers)
Subject: Re: [U-Boot] [PATCH 2/2] arm: cortexa9: adding support for TI OMAP4430 SDP

Dear Aneesh V,

And please don;t top-post / full quote; please see
http://www.netmeister.org/news/learn2quote.html

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A morsel of genuine history is a  thing  so  rare  as  to  be  always
valuable.                                          - Thomas Jefferson