Skip to contentSkip to conversation

shadow.inc: Append serial devices mentioned in SERIAL_CONSOLE into /etc/securetty

PATCH In review Khem Raj 2 participants 2 messages May 26, 2010

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 shadow.inc: Append serial devices mentioned in SERIAL_CONSOLE into /etc/securetty

* Some serial dev nodes are not part of /etc/securetty. So either we can add them manually or deduce from SERIAL_CONSOLE. this does the later. Tested on qemuarm which used ttyAMA0 for console and it not listed in the securetty list. This authorizes root login on the give named console.

---
 recipes/shadow/shadow.inc |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)
recipes/shadow/shadow.inc +11 -2
index 30bd92f..460930b 100644
@@ -11,7 +11,9 @@ LICENSE = "BSD"
 SECTION = "base"
 DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
 
-INC_PR = "r13"
+PACKAGE_ARCH_${PN} = "${MACHINE_ARCH}"
+
+INC_PR = "r14"
 
 # Additional Policy files for PAM
 PAM_SRC_URI = " \
@@ -90,8 +92,15 @@ do_install_append() {
   mv ${D}${bindir}/login ${D}${base_bindir}/login.${PN}
 
   # Ensure we add a suitable securetty file to the package that has most common embedded TTYs defined.
+  if [ ! -z "${SERIAL_CONSOLE}" ]; then
+  # our SERIAL_CONSOLE contains baud rate too and sometime -L option as well.
+  # the following pearl :) takes that and converts it into newline sepated tty's and appends
+  # them into securetty. So if a machine has a weird looking console device node (e.g. ttyAMA0) that securetty
+  # does not know then it will get appended to securetty and root login will be allowed on
+  # that console.
+    echo "${SERIAL_CONSOLE}" | sed -e 's/[0-9][0-9]\|\-L//g'|tr "[ ]" "[\n]"  >> ${WORKDIR}/securetty
+  fi
   install -m 0400 ${WORKDIR}/securetty ${D}${sysconfdir}/securetty 
-
 }
 
 pkg_postinst_${PN} () {
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Khem Raj

* Some serial dev nodes are not part of /etc/securetty. So either we can add them manually or deduce from SERIAL_CONSOLE. this does the later. Tested on qemuarm which used ttyAMA0 for console and it not listed in the securetty list. This authorizes root login on the give named console.

Nicely done, that looks quite useful for devices with unusual tty names for their serial ports.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics