Skip to contentSkip to conversation

splice: direct_splice_actor() should not use pos in sd

PATCH In review Changli Gao 2 participants 2 messages May 26, 2010 – May 28, 2010 VFS

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/4 splice: direct_splice_actor() should not use pos in sd

direct_splice_actor() should not use pos in sd

direct_splice_actor() shouldn't use sd->pos, as sd->pos is for file reading, file->f_pos should be used instead.

----

 fs/splice.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/splice.c +2 -1
index 9e52de5..eb602cb 100644
@@ -1232,7 +1232,8 @@ static int direct_splice_actor(struct pipe_inode_info *pipe,
 {
 	struct file *file = sd->u.file;
 
-	return do_splice_from(pipe, file, &sd->pos, sd->total_len, sd->flags);
+	return do_splice_from(pipe, file, &file->f_pos, sd->total_len,
+			      sd->flags);
 }
 
 /**
Acked-by on v2 2/4
#1 lore raw
Quoted 6 lines · Changli Gao

direct_splice_actor() should not use pos in sd

direct_splice_actor() shouldn't use sd->pos, as sd->pos is for file reading, file->f_pos should be used instead.

Quoted 22 lines

----

 fs/splice.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/splice.c +2 -2
index 9e52de5..eb602cb 100644
@@ -1232,7 +1232,8 @@ static int direct_splice_actor(struct pipe_inode_info *pipe,
 {
 	struct file *file = sd->u.file;
 
-	return do_splice_from(pipe, file, &sd->pos, sd->total_len, sd->flags);
+	return do_splice_from(pipe, file, &file->f_pos, sd->total_len,
+			      sd->flags);
 }
 
 /**
--

To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html