Skip to contentSkip to conversation

HID: Removed obsolete comment from roccat kone driver

PATCH Applied Stefan Achatz 2 participants 2 messages May 26, 2010 – May 31, 2010

Subsystems (2)
HID Roccat drivers
lore
Share & tools
lore

Stefan Achatz

author maintainer
#0 lore raw

PATCH 1/3 HID: Removed obsolete comment from roccat kone driver

Removed comment that is obsolete since roccat char device is implemented

Signed-off-by Stefan Achatz <[email protected]>
---
 drivers/hid/hid-roccat-kone.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/hid/hid-roccat-kone.c +0 -5
index 17f2dc0..3e5b553 100644
@@ -22,11 +22,6 @@
  *      Is it possible to remove and reinstall the urb in raw-event- or any
  *      other handler, or to defer this action to be executed somewhere else?
  *
- * TODO implement notification mechanism for overlong macro execution
- *      If user wants to execute an overlong macro only the names of macroset
- *      and macro are given. Should userland tap hidraw or is there an
- *      additional streaming mechanism?
- *
  * TODO is it possible to overwrite group for sysfs attributes via udev?
  */
Signature · 1 line
1.6.6.1
Applied
#1 lore raw
Quoted 13 lines · Stefan Achatz

Removed comment that is obsolete since roccat char device is implemented

Signed-off-by Stefan Achatz <[email protected]>
---
 drivers/hid/hid-roccat-kone.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
drivers/hid/hid-roccat-kone.c +0 -0
index 17f2dc0..3e5b553 100644

drivers/hid/hid-roccat-kone.c line 26

Quoted 10 lines
drivers/hid/hid-roccat-kone.c +0 -5
@@ -22,11 +22,6 @@
  *      Is it possible to remove and reinstall the urb in raw-event- or any
  *      other handler, or to defer this action to be executed somewhere else?
  *
- * TODO implement notification mechanism for overlong macro execution
- *      If user wants to execute an overlong macro only the names of macroset
- *      and macro are given. Should userland tap hidraw or is there an
- *      additional streaming mechanism?
- *
  * TODO is it possible to overwrite group for sysfs attributes via udev?
  */

Hi Stefan,

I have applied all three patches in the series. Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs, Novell Inc.