ACPICA Release 20100528 linuxized patches
Subsystems (2)
Hi, Len
ACPICA Release 20100528 linuxized patches attached. Applied cleanly on top of linus tree(67a3e12).
[PATCH 01/14] ACPICA: Add comment: _BCL cannot be sorted on the fly [PATCH 02/14] ACPICA: Fix namestring associated with AE_NO_HANDLER exception [PATCH 03/14] ACPICA: iASL/Core: Add support for _WDG/_WED MS methods [PATCH 04/14] ACPICA: Expand initialization counters to 32 bits [PATCH 05/14] ACPICA: Limit maximum time for Sleep() operator
[PATCH 06/14] ACPICA: Core: Replace all %d format specifiers with %u (unsigned) [PATCH 07/14] ACPICA: Expand device initialization counters to 32 bits [PATCH 08/14] ACPICA: Truncate I/O addresses to 16 bits for Windows compatibility [PATCH 09/14] ACPICA: Performance enhancement for namespace search and access [PATCH 10/14] ACPICA: Update flags for operand object
[PATCH 11/14] ACPICA: Enable multi-byte EC transfers
[PATCH 12/14] ACPICA: Optimization: Reduce the number of namespace walks [PATCH 13/14] ACPICA: Add signatures for undefined tables: ATKG, GSCI, IEIT [PATCH 14/14] ACPICA: Update version to 20100528
Lin Ming
Hi, Len
It's reported that patch 11 has a bug, see
http://www.acpica.org/bugzilla/show_bug.cgi?id=863
Please apply this new version of mbox, the only difference is as below.
Alexey,
The reporter confirmed that removing the "Handle the simple case here" code fixes bug 863.
drivers/acpi/acpica/exfldio.c +0 -8
@@ -698,15 +698,7 @@ acpi_ex_extract_from_field(union acpi_operand_object *obj_desc,ACPI_MEMSET (buffer,0 , buffer_length); access_bit_width =ACPI_MUL_8 (obj_desc->common_field.access_byte_width); -/* Handle the simple case here */ - -if ((obj_desc->common_field.start_field_bit_offset ==0 ) && - (obj_desc->common_field.bit_length == access_bit_width)) { - status =acpi_ex_field_datum_io (obj_desc,0 , buffer,ACPI_READ ); -return_ACPI_STATUS (status); - } -
/* TBD: Move to common setup code */
/* Field algorithm is limited to sizeof(u64), truncate if needed */
Quoted 21 lines · Lin Ming
Hi, Len
ACPICA Release 20100528 linuxized patches attached. Applied cleanly on top of linus tree(67a3e12).
[PATCH 01/14] ACPICA: Add comment:
_BCLcannot be sorted on the fly [PATCH 02/14] ACPICA: Fix namestring associated withAE_NO_HANDLERexception [PATCH 03/14] ACPICA: iASL/Core: Add support for _WDG/_WED MS methods [PATCH 04/14] ACPICA: Expand initialization counters to 32 bits [PATCH 05/14] ACPICA: Limit maximum time forSleep()operator
[PATCH 06/14] ACPICA: Core: Replace all %d format specifiers with %u (unsigned) [PATCH 07/14] ACPICA: Expand device initialization counters to 32 bits [PATCH 08/14] ACPICA: Truncate I/O addresses to 16 bits for Windows compatibility [PATCH 09/14] ACPICA: Performance enhancement for namespace search and access [PATCH 10/14] ACPICA: Update flags for operand object
[PATCH 11/14] ACPICA: Enable multi-byte EC transfers
[PATCH 12/14] ACPICA: Optimization: Reduce the number of namespace walks [PATCH 13/14] ACPICA: Add signatures for undefined tables: ATKG, GSCI, IEIT [PATCH 14/14] ACPICA: Update version to 20100528Lin Ming
Hi Ming,
In this case please revert whole patch #11, there is no reason to include it without this piece.
Regards,
Alex.
02.06.2010 06:13, Lin Ming пишет:
Quoted 56 lines
Hi, Len
It's reported that patch 11 has a bug, see
http://www.acpica.org/bugzilla/show_bug.cgi?id=863Please apply this new version of mbox, the only difference is as below.
Alexey,
The reporter confirmed that removing the "Handle the simple case here" code fixes bug 863.
drivers/acpi/acpica/exfldio.c +0
-8@@ -698,15 +698,7 @@ acpi_ex_extract_from_field(union acpi_operand_object *obj_desc,ACPI_MEMSET (buffer,0 , buffer_length); access_bit_width =ACPI_MUL_8 (obj_desc->common_field.access_byte_width); -/* Handle the simple case here */ - -if ((obj_desc->common_field.start_field_bit_offset ==0 ) && - (obj_desc->common_field.bit_length == access_bit_width)) { - status =acpi_ex_field_datum_io (obj_desc,0 , buffer,ACPI_READ ); -return_ACPI_STATUS (status); - } -/* TBD: Move to common setup code */ /* Field algorithm is limited to sizeof(u64), truncate if needed */ Quoted 20 lines · Lin Ming
Hi, Len
ACPICA Release 20100528 linuxized patches attached. Applied cleanly on top of linus tree(67a3e12).
[PATCH 01/14] ACPICA: Add comment:
_BCLcannot be sorted on the fly [PATCH 02/14] ACPICA: Fix namestring associated withAE_NO_HANDLERexception [PATCH 03/14] ACPICA: iASL/Core: Add support for _WDG/_WED MS methods [PATCH 04/14] ACPICA: Expand initialization counters to 32 bits [PATCH 05/14] ACPICA: Limit maximum time forSleep()operator
[PATCH 06/14] ACPICA: Core: Replace all %d format specifiers with %u (unsigned) [PATCH 07/14] ACPICA: Expand device initialization counters to 32 bits [PATCH 08/14] ACPICA: Truncate I/O addresses to 16 bits for Windows compatibility [PATCH 09/14] ACPICA: Performance enhancement for namespace search and access [PATCH 10/14] ACPICA: Update flags for operand object
[PATCH 11/14] ACPICA: Enable multi-byte EC transfers
[PATCH 12/14] ACPICA: Optimization: Reduce the number of namespace walks [PATCH 13/14] ACPICA: Add signatures for undefined tables: ATKG, GSCI, IEIT [PATCH 14/14] ACPICA: Update version to 20100528
Quoted 1 line
Quoted 1 line
Lin Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Ming,
02.06.2010 06:13, Lin Ming пишет:
drivers/acpi/acpica/exfldio.c acpi_ex_extract_from_field(union acpi_operand_object *obj_desc, · line 704
Quoted 12 lines
drivers/acpi/acpica/exfldio.c +0
-4@@ -698,15 +698,7 @@ acpi_ex_extract_from_field(union acpi_operand_object *obj_desc,ACPI_MEMSET (buffer,0 , buffer_length); access_bit_width =ACPI_MUL_8 (obj_desc->common_field.access_byte_width); -/* Handle the simple case here */ - -if ((obj_desc->common_field.start_field_bit_offset ==0 ) && - (obj_desc->common_field.bit_length == access_bit_width)) {
I would guess we need to zero the whole buffer here... Buffer length is sizeof(ACPI_INTEGER), we read only 8 bits, everything else is packed with garbage.
drivers/acpi/acpica/exfldio.c acpi_ex_extract_from_field(union acpi_operand_object *obj_desc, · line 708
Quoted 4 lines
drivers/acpi/acpica/exfldio.c +0
-4- status =acpi_ex_field_datum_io (obj_desc,0 , buffer,ACPI_READ ); -return_ACPI_STATUS (status); - } -
Thanks,
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Len Brown
reviewerapplied to the acpica branch in acpi-test -- with patch 11 excluded
thanks,
Len Brown, Intel Open Source Technology Center