UBUNTU: SAUCE: khubd -- switch USB product/manufacturer/serial handling to RCU
PATCH 1/1 UBUNTU: SAUCE: khubd -- switch USB product/manufacturer/serial handling to RCU
With the introduction of wireless USB hubs the product, manufacturer, and serial number are now mutable. This necessitates new locking in the consumers of these values including the sysfs read routines in order to prevent use-after-free acces to these values. These extra locks create significant lock contention leading to increased boot times (0.3s for an example Atom based system). Move update of these values to RCU based locking.
--- drivers/usb/core/hub.c | 34 ++++++++++++++++++++++++++++------ drivers/usb/core/sysfs.c | 6 +++--- 2 files changed, 31 insertions(+), 9 deletions(-)
drivers/usb/core/hub.c +28 -6
@@ -24,6 +24,7 @@#include <linux/mutex.h> #include <linux/freezer.h> #include <linux/pm_runtime.h> +#include <linux/rcupdate.h> #include <asm/uaccess.h> #include <asm/byteorder.h>
@@ -1849,6 +1850,10 @@ fail:*/ int usb_deauthorize_device (struct usb_device *usb_dev) { +char *product =NULL ; +char *manufacturer =NULL ; +char *serial =NULL ; +usb_lock_device (usb_dev);if (usb_dev->authorized ==0 ) goto out_unauthorized;
@@ -1856,11 +1861,12 @@ int usb_deauthorize_device(struct usb_device *usb_dev) usb_dev->authorized =0 ;usb_set_configuration (usb_dev,-1 ); -kfree (usb_dev->product); + product = usb_dev->product; + manufacturer = usb_dev->manufacturer; + serial = usb_dev->serial; + usb_dev->product =kstrdup ("n/a (unauthorized)" ,GFP_KERNEL ); -kfree (usb_dev->manufacturer); usb_dev->manufacturer =kstrdup ("n/a (unauthorized)" ,GFP_KERNEL ); -kfree (usb_dev->serial); usb_dev->serial =kstrdup ("n/a (unauthorized)" ,GFP_KERNEL );usb_destroy_configuration (usb_dev);
@@ -1868,6 +1874,12 @@ int usb_deauthorize_device(struct usb_device *usb_dev) out_unauthorized:usb_unlock_device (usb_dev); +if (product || manufacturer || serial) { +synchronize_rcu (); +kfree (product); +kfree (manufacturer); +kfree (serial); + }return 0 ; }
@@ -1875,6 +1887,9 @@ out_unauthorized:int usb_authorize_device (struct usb_device *usb_dev) {int result =0 , c; +char *product =NULL ; +char *manufacturer =NULL ; +char *serial =NULL ;usb_lock_device (usb_dev);if (usb_dev->authorized ==1 )
@@ -1893,11 +1908,12 @@ int usb_authorize_device(struct usb_device *usb_dev) goto error_device_descriptor; } -kfree (usb_dev->product); + product = usb_dev->product; + manufacturer = usb_dev->manufacturer; + serial = usb_dev->serial; + usb_dev->product =NULL ; -kfree (usb_dev->manufacturer); usb_dev->manufacturer =NULL ; -kfree (usb_dev->serial); usb_dev->serial =NULL ; usb_dev->authorized =1 ;
@@ -1925,6 +1941,12 @@ error_device_descriptor: error_autoresume: out_authorized:usb_unlock_device (usb_dev);// complements locktree +if (product || manufacturer || serial) { +synchronize_rcu (); +kfree (product); +kfree (manufacturer); +kfree (serial); + }return result; }
drivers/usb/core/sysfs.c +3 -3
@@ -85,9 +85,9 @@ static ssize_t show_##name(struct device *dev, \int retval; \ \ udev =to_usb_device (dev); \ -usb_lock_device (udev); \ - retval =sprintf (buf,"%s\n" , udev->name); \ -usb_unlock_device (udev); \ +rcu_read_lock (); \ + retval =sprintf (buf,"%s\n" ,rcu_dereference (udev->name)); \ +rcu_read_unlock (); \return retval; \ } \ static DEVICE_ATTR(name, S_IRUGO, show_##name, NULL);
Signature · 1 line
1.7.0.4
Quoted 7 lines · Andy Whitcroft
With the introduction of wireless USB hubs the product, manufacturer, and serial number are now mutable. This necessitates new locking in the consumers of these values including the sysfs read routines in order to prevent use-after-free acces to these values. These extra locks create significant lock contention leading to increased boot times (0.3s for an example Atom based system). Move update of these values to RCU based locking.
Bah, some Ubuntu-ism leaked out in the summary test, I've resent it with those removed.
-apw