Skip to contentSkip to conversation

hwmon: Add support for W83667HG-B to w83627ehf driver.

PATCH Superseded Guenter Roeck 1 participant 1 message Jul 3, 2010

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 hwmon: Add support for W83667HG-B to w83627ehf driver.

---

Key relevant difference between W83667HG and W83667HG-B are the Chip ID as well as fan output and step output register addresses. Those differences are addressed with this patch.

There are other relevant changes in the mapping of input sensors to fan control (W83667HG datasheet chapter 8.7, W83667HG-B datasheet chapter 8.5). However, control of those mappings is not implemented in the driver, thus the respective changes should not have an impact on driver operation.

Changes made in this patch are based on information from datasheets only. The patch has not yet been tested with real hardware. The patch will have to be tested with real hardware before it is integrated, and is thus submitted as RFC.

The next version of this patch will be split in two parts: generic changes which also apply to W83667HG, and W83667HG-B specific changes.

Changes in v3:
- Updated driver documentation
- Read data from max and step registers in update_device function.
- In update_device, read fan pwm registers only for installed/supported fans.
- Removed W83667HG-I code; that should really have been W83677HG-I. Without datasheet, adding support for this chip would be too risky.
- For W83667HG-B, create max and step attribute files for all fans.

Changes in v2:
- Removed dash from hwmon device name.
- Moved global array pointers to per-device data.
- Added chip detection for W83667HG-I
(assumed to be identical to W83667HG; needs to be validated).

---
 Documentation/hwmon/w83627ehf |   15 ++++--
 drivers/hwmon/w83627ehf.c     |   97 ++++++++++++++++++++++++++++++++++++----
 2 files changed, 97 insertions(+), 15 deletions(-)
Documentation/hwmon/w83627ehf +10 -5
index b7e42ec..c74cf09 100644
@@ -20,6 +20,10 @@ Supported chips:
     Prefix: 'w83667hg'
     Addresses scanned: ISA address retrieved from Super I/O registers
     Datasheet: not available
+  * Winbond W83667HG-B
+    Prefix: 'w83667hg'
+    Addresses scanned: ISA address retrieved from Super I/O registers
+    Datasheet: Available from Nuvoton upon request
 
 Authors:
         Jean Delvare <[email protected]>
@@ -32,8 +36,8 @@ Description
 -----------
 
 This driver implements support for the Winbond W83627EHF, W83627EHG,
-W83627DHG, W83627DHG-P and W83667HG super I/O chips. We will refer to them
-collectively as Winbond chips.
+W83627DHG, W83627DHG-P, W83667HG and W83667HG-B super I/O chips.
+We will refer to them collectively as Winbond chips.
 
 The chips implement three temperature sensors, five fan rotation
 speed sensors, ten analog voltage sensors (only nine for the 627DHG), one
@@ -68,14 +72,15 @@ follows:
 temp1 -> pwm1
 temp2 -> pwm2
 temp3 -> pwm3
-prog  -> pwm4 (not on 667HG; the programmable setting is not supported by
-	       the driver)
+prog  -> pwm4 (not on 667HG and 667-B; the programmable setting is not supported
+               by the driver)
 
 /sys files
 ----------
 
 name - this is a standard hwmon device entry. For the W83627EHF and W83627EHG,
-       it is set to "w83627ehf" and for the W83627DHG it is set to "w83627dhg"
+       it is set to "w83627ehf", for the W83627DHG it is set to "w83627dhg",
+       and for the W83667HG it is set to "w83667hg".
 
 pwm[1-4] - this file stores PWM duty cycle or DC value (fan speed) in range:
 	   0 (stop) to 255 (full)
drivers/hwmon/w83627ehf.c +79 -10

202 lines not on this page · raw message

Signature · 7 lines
1.7.0.87.g0901d


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors