Skip to contentSkip to conversation

PATCH] Scripts: checkpatch: change externals to globals

PATCH Joe Eloff 1 participant 1 message Jul 5, 2010 Checkpatch

lore
Share & tools
lore

Joe Eloff

author
#0 lore raw
Quoted 1 line

From 9745542c84ef223eec8309a9fb7abf225153419d Mon Sep 17 00:00:00 2001

From: Joe Eloff <[email protected]>
Date: Mon, 5 Jul 2010 23:28:21 +0200
Subject: [PATCH] Scripts: checkpatch: change externals to globals

Made error message say 'ERROR: do not initialise globals to 0 or NULL' rather than 'ERROR: do not initialise externals to 0 or NULL'. Makes more sense in the context since there is an extern keyword in C and that is a global declaration within the scope of the current file.

---
 scripts/checkpatch.pl |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
scripts/checkpatch.pl +2 -2
index bd88f11..6b003cf 100755
@@ -1778,9 +1778,9 @@ sub process {
 			WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
 		}
 
-# check for external initialisers.
+# check for global initialisers.
 		if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
-			ERROR("do not initialise externals to 0 or NULL\n" .
+			ERROR("do not initialise globals to 0 or NULL\n" .
 				$herecurr);
 		}
 # check for static initialisers.
Signature · 1 line
1.6.3.3