Skip to contentSkip to conversation

ks8842: Do the TX timeout work in workqueue context.

PATCH Superseded Richard Röjfors 2 participants 2 messages Jul 6, 2010 – Jul 9, 2010

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ks8842: Do the TX timeout work in workqueue context.

Currently all code that needs to be run at TX timeout is done in the calling context, where bottom halves are disabled. Some of the code blocks, so it needs to be done in a different context. This patch adds in a work struct which is scheduled at TX timeout. Then the timeout code is executed within work queue context.

---

drivers/net/ks8842.c +2 -0
index d47bba9..0be9261 100644
@@ -119,6 +119,8 @@ struct ks8842_adapter {
 	int		irq;
 	struct tasklet_struct	tasklet;
 	spinlock_t	lock; /* spinlock to be interrupt safe */
+	struct work_struct timeout_work;
+	struct net_device *netdev;
 };
 
 static inline void ks8842_select_bank(struct ks8842_adapter *adapter,

u16 bank)
@@ -197,7 +199,6 @@ static void ks8842_reset(struct ks8842_adapter *adapter)
msleep(10);
iowrite16(0, adapter->hw_addr + REG_GRR);
*/
- iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST); msleep(20);
}
@@ -553,6 +554,8 @@ static int ks8842_close(struct net_device *netdev)

netdev_dbg(netdev, "%s - entry\n", __func__);

+ cancel_work_sync(&adapter->timeout_work);
+
/* free the irq */
free_irq(adapter->irq, netdev);

@@ -595,9 +598,11 @@ static int ks8842_set_mac(struct net_device *netdev, void *p)
return 0;
}

-static void ks8842_tx_timeout(struct net_device *netdev) +static void ks8842_tx_timeout_work(struct work_struct *work)
{
- struct ks8842_adapter *adapter = netdev_priv(netdev);
+ struct ks8842_adapter *adapter =
+ container_of(work, struct ks8842_adapter, timeout_work);
+ struct net_device *netdev = adapter->netdev;
unsigned long flags;

netdev_dbg(netdev, "%s: entry\n", __func__);
@@ -606,6 +611,9 @@ static void ks8842_tx_timeout(struct net_device *netdev)
/* disable interrupts */
ks8842_write16(adapter, 18, 0, REG_IER); ks8842_write16(adapter, 18, 0xFFFF, REG_ISR);
+
+ netif_stop_queue(netdev);
+
spin_unlock_irqrestore(&adapter->lock, flags);

ks8842_reset_hw(adapter);
@@ -615,6 +623,15 @@ static void ks8842_tx_timeout(struct net_device *netdev)
ks8842_update_link_status(netdev, adapter);
}

+static void ks8842_tx_timeout(struct net_device *netdev) +{
+ struct ks8842_adapter *adapter = netdev_priv(netdev);
+
+ netdev_dbg(netdev, "%s: entry\n", __func__);
+
+ schedule_work(&adapter->timeout_work);
+}
+
static const struct net_device_ops ks8842_netdev_ops = {
.ndo_open = ks8842_open,
.ndo_stop = ks8842_close,
@@ -649,6 +666,8 @@ static int __devinit ks8842_probe(struct platform_device *pdev)
SET_NETDEV_DEV(netdev, &pdev->dev);

adapter = netdev_priv(netdev);
+ adapter->netdev = netdev;
+ INIT_WORK(&adapter->timeout_work, ks8842_tx_timeout_work);
adapter->hw_addr = ioremap(iomem->start, resource_size(iomem)); if (!adapter->hw_addr)
goto err_ioremap;

maintainer
#1 lore raw

From: Richard Röjfors <[email protected]>
Date: Tue, 06 Jul 2010 17:20:25 +0200

Quoted 7 lines

Currently all code that needs to be run at TX timeout is done in the calling context, where bottom halves are disabled. Some of the code blocks, so it needs to be done in a different context. This patch adds in a work struct which is scheduled at TX timeout. Then the timeout code is executed within work queue context.

Your patch is corrupted by your email client, and it does more than you say it does in this commit message:

Review static void ks8842_reset(struct ks8842_adapter · line 199

Quoted 4 lines

static inline void ks8842_select_bank(struct ks8842_adapter *adapter,
u16 bank)

(quoted diff) +0 -0
@@ -197,7 +199,6 @@ static void ks8842_reset(struct ks8842_adapter
 *adapter)

Your email client is wrapping long lines in the patch, corrupting it and making it unusable. Please fix your email client to not molest the patch in any way.

Quoted 7 lines
(quoted diff) +0 -1
 	msleep(10);
 	iowrite16(0, adapter->hw_addr + REG_GRR);
 	*/
-	iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
 	iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST);
 	msleep(20);

}

Your commit message fails to describe what this REG_SELECT_BANK write removal is needed for. It must be accounted for in your log message otherwise other developers won't understand why this line gets removed in your change.

Thanks.