nfs02: testcases/network/nfs/nfs02/nfs02 script - bug fixing

PATCH In review [email protected] 2 participants 3 messages Jul 11, 2010

lore

Share & tools

lore

[email protected]

author

2010-07-11 13:58 UTC #0 lore raw

PATCH 2/3 nfs02: testcases/network/nfs/nfs02/nfs02 script - bug fixing

Hi,

Testcase "nfs02" fails with following message
"Test Failed: Removal of write permissions not honored on ascii.sm" This is because ascii.sm has a rwx file permission for others when It got installed. The script first tried to remove only write permission for others and then it tests it with the r-- permission so test get fails as it has r-x permission for others.

This is fixed with following patch.

testcases/network/nfs/nfs02/nfs02 +1 -1

Index: ltp-full-20100630/testcases/network/nfs/nfs02/nfs02
===================================================================
@@ -179,7 +179,7 @@ do_test3()
 {
 $trace_logic
    echo "do_test3 $TC "
-   chmod a-w $TCtmp/ascii.sm &
+   chmod a-wx $TCtmp/ascii.sm &
    wait $!
    ls -l $TCtmp/ascii.sm | grep "r--" 
    [ $? -eq 0 ] || end_testcase "Removal of write permissions not

honored on ascii.sm"

Thanks & Regards
Sumit Dhoot
System Administrator
Linsyssoft Technologies Pvt. Ltd.
[email protected]

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Sumit Dhoot

author

2010-07-11 14:21 UTC #1 lore raw

Hi All,

I failed to add "Signed-off-by". Apologies for this.

Quoted 12 lines · On Sun, Jul 11, 2010 at 7:04 PM, <[email protected]> wrote:

Hi,
Testcase "nfs02" fails with following message
"Test Failed: Removal of write permissions not honored on ascii.sm" This is because ascii.sm has a rwx file permission for others when It got installed. The script first tried to remove only write permission for others and then it tests it with the r-- permission so test get fails as it has r-x permission for others.
This is fixed with following patch.

Signed-off-by Sumit Dhoot <[email protected]>

======

Quoted 6 lines

Index: ltp-full-20100630/testcases/network/nfs/nfs02/nfs02
===================================================================
testcases/network/nfs/nfs02/nfs02 +0 -0
@@ -179,7 +179,7 @@ do_test3()
  {

Quoted 10 lines

$trace_logic
echo "do_test3 $TC "
- chmod a-w $TCtmp/ascii.sm &
+ chmod a-wx $TCtmp/ascii.sm &
wait $!
ls -l $TCtmp/ascii.sm | grep "r--"
[ $? -eq 0 ] || end_testcase "Removal of write permissions not honored on ascii.sm"

======

Quoted 8 lines

Thanks & Regards
Sumit Dhoot
System Administrator
Linsyssoft Technologies Pvt. Ltd.
[email protected]

Signature · 11 lines

Thanks & Regards
Sumit Dhoot

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Garrett Cooper

2010-07-11 17:05 UTC #2 lore raw

Quoted 21 lines · Sumit Dhoot

Hi All,
I failed to add "Signed-off-by". Apologies for this.
Quoted 12 lines · On Sun, Jul 11, 2010 at 7:04 PM, <[email protected]> wrote:
Hi,
Testcase "nfs02" fails with following message
"Test Failed: Removal of write permissions not honored on ascii.sm" This is because ascii.sm has a rwx file permission for others when It got installed. The script first tried to remove only write permission for others and then it tests it with the r-- permission so test get fails as it has r-x permission for others.
This is fixed with following patch.
Signed-off-by Sumit Dhoot <[email protected]>
======

Quoted 14 lines

Quoted 6 lines
Index: ltp-full-20100630/testcases/network/nfs/nfs02/nfs02
===================================================================
testcases/network/nfs/nfs02/nfs02 +0 -0
@@ -179,7 +179,7 @@ do_test3()
  {
Quoted 8 lines
$trace_logic
echo "do_test3 $TC "
- chmod a-w $TCtmp/ascii.sm &
+ chmod a-wx $TCtmp/ascii.sm &
wait $!
ls -l $TCtmp/ascii.sm | grep "r--"
[ $? -eq 0 ] || end_testcase "Removal of write permissions not honored on ascii.sm"

ACK.