Skip to contentSkip to conversation

usb-serial: fix oti6858.c segfault in termios handling

PATCH New Thomas Viehmann 1 participant 1 message Jul 25, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb-serial: fix oti6858.c segfault in termios handling

The oti6858 usb serial driver should use kernel_termios_to_user_termios/ user_termios_to_kernel_termios to avoid segfaults because the kernel uses a structure differing from that of user space with a different size.

---
I'm don't know the least thing about the type casting (it is lifted from kobil_sct.c), but I do get better success with the patch...

drivers/usb/serial/oti6858.c renamed from drivers/usb/serial/oti6858.c.orig +5 -6
@@ -818,19 +818,22 @@
 
       switch (cmd) {
               case TCGETS:
-                       if (copy_to_user(user_arg, port->tty->termios,
-                                               sizeof(struct ktermios))) {
+                       if (kernel_termios_to_user_termios(
+                                            (struct ktermios __user *)arg,
+                                            port->tty->termios))
                               return -EFAULT;
-                       }
                       return 0;
 
               case TCSETS:
               case TCSETSW:                  case TCSETSF:   -      
                 if (copy_from_user(port->tty->termios, user_arg,
-                                               sizeof(struct ktermios))) {
+                       if (user_termios_to_kernel_termios(port->tty->termios,
+                                               (struct ktermios __user *)arg))
                               return -EFAULT;
-                       }
                       oti6858_set_termios(port, NULL);
                       return 0;
 
--

Thomas Viehmann, http://thomas.viehmann.net/