Skip to contentSkip to conversation

perf: export tracepoint events via sysfs: power

RFC PATCH In review Lin Ming 2 participants 4 messages Jul 22, 2010 – Jul 23, 2010 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Lin Ming

author
#0 lore raw

RFC PATCH 11/15 perf: export tracepoint events via sysfs: power

power tracepoint events are exported like below,

/sys/power/events/

|-- power_end
|   |-- config
|   `-- type
|-- power_frequency
|   |-- config
|   `-- type
`-- power_start
    |-- config
    `-- type
---
 kernel/power/main.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
kernel/power/main.c +4 -0
index b58800b..6749374 100644
@@ -12,6 +12,7 @@
 #include <linux/string.h>
 #include <linux/resume-trace.h>
 #include <linux/workqueue.h>
+#include <linux/perf_event.h>
 
 #include "power.h"
 
@@ -269,6 +270,9 @@ static int __init pm_init(void)
 	power_kobj = kobject_create_and_add("power", NULL);
 	if (!power_kobj)
 		return -ENOMEM;
+
+	perf_sys_add_tp(power_kobj, "power");
+
 	return sysfs_create_group(power_kobj, &attr_group);
 }
 
#1 lore raw
Quoted 12 lines · Lin Ming

power tracepoint events are exported like below,

/sys/power/events/

|-- power_end
|   |-- config
|   `-- type
|-- power_frequency
|   |-- config
|   `-- type
`-- power_start
    |-- config
    `-- type

Any details?

Quoted 17 lines
---
 kernel/power/main.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
kernel/power/main.c +1 -0
index b58800b..6749374 100644
@@ -12,6 +12,7 @@
 #include <linux/string.h>
 #include <linux/resume-trace.h>
 #include <linux/workqueue.h>
+#include <linux/perf_event.h>
 
 #include "power.h"
 

kernel/power/main.c static int __init pm_init(void) · line 275

Quoted 6 lines
kernel/power/main.c +3 -0
@@ -269,6 +270,9 @@ static int __init pm_init(void)
 	power_kobj = kobject_create_and_add("power", NULL);
 	if (!power_kobj)
 		return -ENOMEM;
+
+	perf_sys_add_tp(power_kobj, "power");
+

Why isn't it done in drivers/base/power/sysfs.c ?

kernel/power/main.c static int __init pm_init(void) · line 277

Quoted 2 lines
kernel/power/main.c +0 -0
 	return sysfs_create_group(power_kobj, &attr_group);
 }

Rafael

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#3 lore raw
Quoted 21 lines

From: Rafael J. Wysocki <[email protected]>
Date: Fri, Jul 23, 2010 at 5:53 AM
Subject: Re: [RFC][PATCH v1 11/15] perf: export tracepoint events via
sysfs: power

Quoted 12 lines · Lin Ming

power tracepoint events are exported like below,

/sys/power/events/

|-- power_end
|   |-- config
|   `-- type
|-- power_frequency
|   |-- config
|   `-- type
`-- power_start
    |-- config
    `-- type
Quoted 1 line

Any details?

Sorry that I didn't include you in the patch description.

[RFC][PATCH v1 00/15] perf: export events in a structured way via sysfs
http://lkml.org/lkml/2010/7/22/141

Quoted 17 lines
Quoted 17 lines
---
 kernel/power/main.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
kernel/power/main.c +1 -0
index b58800b..6749374 100644
@@ -12,6 +12,7 @@
 #include <linux/string.h>
 #include <linux/resume-trace.h>
 #include <linux/workqueue.h>
+#include <linux/perf_event.h>
 
 #include "power.h"
 
Quoted 9 lines

kernel/power/main.c static int __init pm_init(void) · line 275

Quoted 7 lines
kernel/power/main.c +3 -0
@@ -269,6 +270,9 @@ static int __init pm_init(void)
      power_kobj = kobject_create_and_add("power", NULL);
      if (!power_kobj)
              return -ENOMEM;
+
+     perf_sys_add_tp(power_kobj, "power");
+

Why isn't it done in drivers/base/power/sysfs.c ?

The sysfs thing in drivers/base/power/sysfs.c is per device. But the power tracepoint events are not per device, right?

Lin Ming

Quoted 5 lines

kernel/power/main.c static int __init pm_init(void) · line 277

Quoted 3 lines
kernel/power/main.c +0 -0
      return sysfs_create_group(power_kobj, &attr_group);
 }

Rafael

#4 lore raw
Quoted 21 lines · Lin Ming
Quoted 21 lines

From: Rafael J. Wysocki <[email protected]>
Date: Fri, Jul 23, 2010 at 5:53 AM
Subject: Re: [RFC][PATCH v1 11/15] perf: export tracepoint events via
sysfs: power

Quoted 12 lines · Lin Ming

power tracepoint events are exported like below,

/sys/power/events/

|-- power_end
|   |-- config
|   `-- type
|-- power_frequency
|   |-- config
|   `-- type
`-- power_start
    |-- config
    `-- type
Quoted 6 lines
Quoted 1 line

Any details?

Sorry that I didn't include you in the patch description.

[RFC][PATCH v1 00/15] perf: export events in a structured way via sysfs
http://lkml.org/lkml/2010/7/22/141

Thanks, I'll have a look at this later today.

Quoted 26 lines
Quoted 16 lines
Quoted 16 lines
---
 kernel/power/main.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
kernel/power/main.c +1 -0
index b58800b..6749374 100644
@@ -12,6 +12,7 @@
 #include <linux/string.h>
 #include <linux/resume-trace.h>
 #include <linux/workqueue.h>
+#include <linux/perf_event.h>
 
 #include "power.h"
 
Quoted 9 lines

kernel/power/main.c static int __init pm_init(void) · line 275

Quoted 7 lines
kernel/power/main.c +3 -0
@@ -269,6 +270,9 @@ static int __init pm_init(void)
      power_kobj = kobject_create_and_add("power", NULL);
      if (!power_kobj)
              return -ENOMEM;
+
+     perf_sys_add_tp(power_kobj, "power");
+

Why isn't it done in drivers/base/power/sysfs.c ?

Quoted 2 lines

The sysfs thing in drivers/base/power/sysfs.c is per device. But the power tracepoint events are not per device, right?

Right, sorry.

Rafael