perf: export tracepoint events via sysfs: mac80211
RFC PATCH 15/15 perf: export tracepoint events via sysfs: mac80211
mac80211 tracepoint events are exported like below,
/sys/class/ieee80211/events/
|-- api_beacon_loss | |-- config | |-- type .... .... |-- drv_add_interface | |-- config | |-- type .... .... |-- stop_queue | |-- config | |-- type |-- wake_queue | |-- config | |-- type --- drivers/base/class.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
drivers/base/class.c +12 -0
@@ -19,6 +19,7 @@#include <linux/slab.h> #include <linux/genhd.h> #include <linux/mutex.h> +#include <linux/perf_event.h> #include "base.h" #define to_class_attr (_attr) container_of(_attr, struct class_attribute, attr)
@@ -160,6 +161,14 @@ static void klist_class_dev_put(struct klist_node *n)put_device (dev); } +extern struct class ieee80211_class; + +static void class_sys_add_tp (struct kobject *class_kobj,struct class *cls) +{ +if (cls == &ieee80211_class) +perf_sys_add_tp (class_kobj,"mac80211" ); +} +int __class_register (struct class *cls,struct lock_class_key *key) {struct class_private *cp;
@@ -202,6 +211,9 @@ int __class_register(struct class *cls, struct lock_class_key *key) } error =add_class_attrs (class_get (cls));class_put (cls); + +class_sys_add_tp (&cp->class_subsys.kobj, cls); +return error; }EXPORT_SYMBOL_GPL (__class_register);
Quoted 37 lines · Lin Ming
mac80211 tracepoint events are exported like below,
/sys/class/ieee80211/events/|-- api_beacon_loss | |-- config | |-- type .... .... |-- drv_add_interface | |-- config | |-- type .... .... |-- stop_queue | |-- config | |-- type |-- wake_queue | |-- config | |-- type --- drivers/base/class.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)drivers/base/class.c +1
-0@@ -19,6 +19,7 @@#include <linux/slab.h> #include <linux/genhd.h> #include <linux/mutex.h> +#include <linux/perf_event.h> #include "base.h" #define to_class_attr (_attr) container_of(_attr, struct class_attribute, attr)@@ -160,6 +161,14 @@ static void klist_class_dev_put(struct klist_node *n)put_device (dev);
drivers/base/class.c static void klist_class_dev_put(struct klist_node *n) · line 171
Quoted 10 lines
drivers/base/class.c +8
-0} +extern struct class ieee80211_class; + +static void class_sys_add_tp (struct kobject *class_kobj,struct class *cls) +{ +if (cls == &ieee80211_class) +perf_sys_add_tp (class_kobj,"mac80211" ); +} +
Ick, what a bad hack! No way. And this really can't work anyway when cfg80211 is a module. This is all messed up. The events should probably be in /sys/class/ieee80211/phyX/ anyway.
johannes
Quoted 40 lines · Johannes Berg
Quoted 39 lines · Lin Ming
mac80211 tracepoint events are exported like below,
/sys/class/ieee80211/events/|-- api_beacon_loss | |-- config | |-- type .... .... |-- drv_add_interface | |-- config | |-- type .... .... |-- stop_queue | |-- config | |-- type |-- wake_queue | |-- config | |-- type --- drivers/base/class.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)drivers/base/class.c +1
-0@@ -19,6 +19,7 @@#include <linux/slab.h> #include <linux/genhd.h> #include <linux/mutex.h> +#include <linux/perf_event.h> #include "base.h" #define to_class_attr (_attr) container_of(_attr, struct class_attribute, attr)@@ -160,6 +161,14 @@ static void klist_class_dev_put(struct klist_node *n)put_device (dev); }
Quoted 10 lines
drivers/base/class.c static void klist_class_dev_put(struct klist_node *n) · line 171
Quoted 8 lines
drivers/base/class.c +8
-0+extern struct class ieee80211_class; + +static void class_sys_add_tp (struct kobject *class_kobj,struct class *cls) +{ +if (cls == &ieee80211_class) +perf_sys_add_tp (class_kobj,"mac80211" ); +} +Ick, what a bad hack! [...]
Yeah, putting driver specific code into generic code for a prototype is OK but not acceptable as an end result.
Thanks,
Ingo