Skip to contentSkip to conversation

cifs: fsc should not default to "on"

PATCH In review Jeff Layton 3 participants 3 messages Jul 26, 2010 – Jul 27, 2010 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: fsc should not default to "on"

I'm not sure why this was merged with this flag hardcoded on, but it seems quite dangerous. Turn it off.

Also, mount.cifs hands unrecognized options off to the kernel so there should be no need for changes there in order to support this.

---
 fs/cifs/connect.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
fs/cifs/connect.c +0 -3
index 85a994c..2a43a0a 100644
@@ -846,9 +846,6 @@ cifs_parse_mount_options(char *options, const char *devname,
 	/* default to using server inode numbers where available */
 	vol->server_ino = 1;
 
-	/* XXX: default to fsc for testing until mount.cifs pieces are done */
-	vol->fsc = 1;
-
 	if (!options)
 		return 1;
 
Signature · 1 line
1.7.1.1

A message that is not in the archive (sent off-list or not yet received): 1280168708-2943-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org

#2 lore raw

agreed - merged

Quoted 29 lines · Jeff Layton

I'm not sure why this was merged with this flag hardcoded on, but it seems quite dangerous. Turn it off.

Also, mount.cifs hands unrecognized options off to the kernel so there should be no need for changes there in order to support this.

---
 fs/cifs/connect.c |    3 ---

 1 files changed, 0 insertions(+), 3 deletions(-)
fs/cifs/connect.c +0 -4
index 85a994c..2a43a0a 100644
@@ -846,9 +846,6 @@ cifs_parse_mount_options(char *options, const char *devname,
        /* default to using server inode numbers where available */
        vol->server_ino = 1;
 
-       /* XXX: default to fsc for testing until mount.cifs pieces are done */
-       vol->fsc = 1;
-
        if (!options)
                return 1;
 
--

1.7.1.1

Signature · 3 lines
Thanks,

Steve
#3 lore raw
In reply to a message not in the archive
Quoted 2 lines · Jeff Layton

I'm not sure why this was merged with this flag hardcoded on, but it seems quite dangerous. Turn it off.

Mea culpa.. I forgot to remove this during the second post.

Quoted 2 lines

Also, mount.cifs hands unrecognized options off to the kernel so there should be no need for changes there in order to support this.

Yeah, it does not seem to require any handling - I had misunderstood.

Quoted 4 lines
---
 fs/cifs/connect.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

Thanks,

Signature · 1 line
Suresh Jayaraman