Skip to contentSkip to conversation

oss: msnd: check request_region() return value

PATCH Applied Kulikov Vasiliy 1 participant 1 message Jul 29, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 9/10 oss: msnd: check request_region() return value

request_region() may fail, if so return -EBUSY.

---
 sound/oss/msnd_pinnacle.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
sound/oss/msnd_pinnacle.c +6 -2
index bfaac5f..cd70b9a 100644
@@ -1400,9 +1400,13 @@ static int __init attach_multisound(void)
 		printk(KERN_ERR LOGNAME ": Couldn't grab IRQ %d\n", dev.irq);
 		return err;
 	}
-	request_region(dev.io, dev.numio, dev.name);
+	if (request_region(dev.io, dev.numio, dev.name) == NULL) {
+		free_irq(dev.irq, &dev);
+		return -EBUSY;
+	}
 
-        if ((err = dsp_full_reset()) < 0) {
+	err = dsp_full_reset();
+	if (err < 0) {
 		release_region(dev.io, dev.numio);
 		free_irq(dev.irq, &dev);
 		return err;
Signature · 1 line
1.7.0.4