scsi: ch: check put_user() result

PATCH New Kulikov Vasiliy 1 participant 1 message Jul 29, 2010

Subsystems (2)

SCSI Kernel janitors

lore

Share & tools

lore

Kulikov Vasiliy

author

2010-07-29 15:56 UTC #0 lore raw

PATCH 1/1 scsi: ch: check put_user() result

put_user() may fail, if so return -EFAULT.

Signed-off-by Kulikov Vasiliy <[email protected]>

---
 drivers/scsi/ch.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

drivers/scsi/ch.c +4 -1

index 4799d43..978bf68 100644
@@ -548,7 +548,10 @@ static int ch_gstatus(scsi_changer *ch, int type, unsigned char __user *dest)
 			retval = -EIO;
 			break;
 		}
-		put_user(data[2], dest+i);
+		if (put_user(data[2], dest+i)) {
+			retval = -EFAULT;
+			break;
+		}
 		if (data[2] & CESTATUS_EXCEPT)
 			vprintk("element 0x%x: asc=0x%x, ascq=0x%x\n",
 				ch->firsts[type]+i,

Signature · 1 line

1.7.0.4