Skip to contentSkip to conversation

writeback: remove wb in get_next_work_item

PATCH In review Minchan Kim 2 participants 3 messages Aug 1, 2010 – Aug 3, 2010 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 writeback: remove wb in get_next_work_item

83ba7b07 cleans up the writeback.
So we don't use wb any more in get_next_work_item. Let's remove unnecessary argument.

CC Christoph Hellwig <[email protected]>
CC Jens Axboe <[email protected]>
---
 fs/fs-writeback.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/fs-writeback.c +2 -2
index a178828..9a55257 100644
@@ -712,7 +712,7 @@ static long wb_writeback(struct bdi_writeback *wb,
  * Return the next wb_writeback_work struct that hasn't been processed yet.
  */
 static struct wb_writeback_work *
-get_next_work_item(struct backing_dev_info *bdi, struct bdi_writeback *wb)
+get_next_work_item(struct backing_dev_info *bdi)
 {
 	struct wb_writeback_work *work = NULL;
 
@@ -770,7 +770,7 @@ long wb_do_writeback(struct bdi_writeback *wb, int force_wait)
 	struct wb_writeback_work *work;
 	long wrote = 0;
 
-	while ((work = get_next_work_item(bdi, wb)) != NULL) {
+	while ((work = get_next_work_item(bdi)) != NULL) {
 		/*
 		 * Override sync mode, in case we must wait for completion
 		 * because this thread is exiting now.
Signature · 1 line
1.7.0.5
#1 lore raw
Quoted 3 lines · Minchan Kim

83ba7b07 cleans up the writeback.
So we don't use wb any more in get_next_work_item. Let's remove unnecessary argument.

If we can get it in this merge windows it's fine with me. If not I have patches pending that use only the bdi_writeback inside fs/fs-writeback.c and completely get rid of the backing-dev.

#2 lore raw
Quoted 9 lines · Christoph Hellwig
Quoted 3 lines · Minchan Kim

83ba7b07 cleans up the writeback.
So we don't use wb any more in get_next_work_item. Let's remove unnecessary argument.

If we can get it in this merge windows it's fine with me. If not I have patches pending that use only the bdi_writeback inside fs/fs-writeback.c and completely get rid of the backing-dev.

Yub. I don't care about it.
It's just clean up patch not urgent.

Signature · 2 lines
Kind regards,
Minchan Kim