West Bridge Astoria Driver 2.6.35
A message that is not in the archive (sent off-list or not yet received): 1281140943.4035.7.camel@odc-laptop
Quoted 2 lines · David Cross
Re-Re-Re-Re-Re-sending with unnecessary files removed, line wrap turned off in new email client, Signed-off-by included in the correct place, and TODO file added.
Looks much better.
I can queue this up in the staging-next tree for the .37 merge, after the .36 merge window closes, if you don't mind me removing the non drivers/staging/ file changes here.
Is that ok?
Quoted 19 lines
arch/arm/mach-omap2/gpmc.c +2
-0@@ -115,6 +115,7 @@ void gpmc_cs_write_reg(int cs, int idx, reg_addr = gpmc_base +GPMC_CS0 + (cs *GPMC_CS_SIZE ) + idx;__raw_writel (val, reg_addr); } +EXPORT_SYMBOL (gpmc_cs_write_reg);u32 gpmc_cs_read_reg (int cs,int idx) {@@ -123,6 +124,7 @@ u32 gpmc_cs_read_reg(int cs, int idx) reg_addr = gpmc_base +GPMC_CS0 + (cs *GPMC_CS_SIZE ) + idx;return __raw_readl (reg_addr); } +EXPORT_SYMBOL (gpmc_cs_read_reg);/* TODO: Add support for gpmc_fck to clock framework and use it */ unsigned long gpmc_get_fclk_period (void )
arch/arm/mach-omap2/gpmc.c int gpmc_cs_set_timings(int cs, const st · line 284
Quoted 7 lines
arch/arm/mach-omap2/gpmc.c +1
-0@@ -276,6 +278,7 @@ int gpmc_cs_set_timings(int cs, const streturn 0 ; } +EXPORT_SYMBOL (gpmc_cs_set_timings);static void gpmc_cs_enable_mem (int cs,u32 base,u32 size) {
What are these symbols needed for?
Can they be marked EXPORT_SYMBOL_GPL()?
thanks,
greg k-h
Quoted 2 lines · David Cross
Re-Re-Re-Re-Re-sending with unnecessary files removed, line wrap turned off in new email client, Signed-off-by included in the correct place, and TODO file added.
I get a build error when I try to build this driver:
drivers/staging/westbridge/astoria/block/../include/linux/westbridge/cyasmisc.h:521:2: error: expected declaration specifiers or ‘...’ before ‘cy_as_hal_device_tag’
It looks like the #include mess isn't working quite properly.
Also note that this driver is building on an x86-64 platform, which is something that you probably don't want :)
So, for now, I'll just mark the driver as CONFIG_BROKEN and can you send me some Kconfig patches against the next linux-next release which should have this driver in it, so that it will build properly?
thanks,
greg k-h
Quoted 3 lines
I get a build error when I try to build this driver:
drivers/staging/westbridge/astoria/block/../include/linux/westbridge/c> yasmisc.h:521:2: error: expected declaration specifiers or '...' before > 'cy_as_hal_device_tag'
Quoted 8 lines
It looks like the #include mess isn't working quite properly.
Also note that this driver is building on an x86-64 platform, which is something that you probably don't want :)
So, for now, I'll just mark the driver as
CONFIG_BROKENand can you send me someKconfigpatches against the next linux-next release which should have this driver in it, so that it will build properly?
Sure, I can do that. I have since changed the Kconfig structure a bit. It actually will build properly with the correct .config as it is though. I can send you the .config if you would like.
Thanks,
David
---------------------------------------------------------------
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.
---------------------------------------------------------------
Quoted 12 lines · David Cross
Quoted 3 lines
I get a build error when I try to build this driver:
drivers/staging/westbridge/astoria/block/../include/linux/westbridge/c> yasmisc.h:521:2: error: expected declaration specifiers or '...' before > 'cy_as_hal_device_tag'Quoted 4 lines
It looks like the #include mess isn't working quite properly.
Also note that this driver is building on an x86-64 platform, which is something that you probably don't want :)
Quoted 7 lines
Quoted 3 lines
So, for now, I'll just mark the driver as
CONFIG_BROKENand can you send me someKconfigpatches against the next linux-next release which should have this driver in it, so that it will build properly?Sure, I can do that. I have since changed the
Kconfigstructure a bit. It actually will build properly with the correct .config as it is though. I can send you the .config if you would like.
It's up to the Kconfig rules to ensure that there can never be a "non-correct" .config file, so that needs to be fixed so that the build will never be broken no matter what type of options are selected.
Care to send a patch for that?
thanks,
greg k-h