Skip to contentSkip to conversation

regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()

PATCH RESEND Applied Axel Lin 2 participants 2 messages Aug 9, 2010 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH RESEND 1/1 regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write()

i2c_smbus_write_byte_data() returns zero or negative value, therefore no need to check if ret is greater than zero or not.

Signed-off-by Axel Lin <[email protected]>
Acked-by Mark Brown <[email protected]>
---
 drivers/regulator/lp3971.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
drivers/regulator/lp3971.c +1 -7
index 8ae3732..d4d9822 100644
@@ -387,15 +387,9 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count,
 static int lp3971_i2c_write(struct i2c_client *i2c, char reg, int count,
 	const u16 *src)
 {
-	int ret;
-
 	if (count != 1)
 		return -EIO;
-	ret = i2c_smbus_write_byte_data(i2c, reg, *src);
-	if (ret >= 0)
-		return 0;
-
-	return ret;
+	return i2c_smbus_write_byte_data(i2c, reg, *src);
 }
 
 static u8 lp3971_reg_read(struct lp3971 *lp3971, u8 reg)
Signature · 1 line
1.5.4.3
Applied
#1 lore raw
Quoted 9 lines · Axel Lin

i2c_smbus_write_byte_data() returns zero or negative value, therefore no need to check if ret is greater than zero or not.

Signed-off-by Axel Lin <[email protected]>
Acked-by Mark Brown <[email protected]>
---
 drivers/regulator/lp3971.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

Applied.

Thanks

Liam

Signature · 3 lines
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk