staging: usbip: fix memory leak

PATCH New Kulikov Vasiliy 1 participant 1 message Aug 11, 2010

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Kulikov Vasiliy

author

2010-08-11 08:02 UTC #0 lore raw

PATCH 1/1 staging: usbip: fix memory leak

If stub_probe() failed then do not increase interf_count. In original code sdev was leaked as its interf_count never reaches 0.

Signed-off-by Kulikov Vasiliy <[email protected]>

---
 drivers/staging/usbip/stub_dev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/staging/usbip/stub_dev.c +1 -1

index b6b753a..b186b5f 100644
@@ -427,11 +427,11 @@ static int stub_probe(struct usb_interface *interface,
 
 
 	if (busid_priv->status = STUB_BUSID_ALLOC) {
-		busid_priv->interf_count++;
 		sdev = busid_priv->sdev;
 		if (!sdev)
 			return -ENODEV;
 
+		busid_priv->interf_count++;
 		dev_info(&interface->dev,
 		 "USB/IP Stub: register a new interface "
 		 "(bus %u dev %u ifn %u)\n", udev->bus->busnum, udev->devnum,

Signature · 1 line

1.7.0.4