Skip to contentSkip to conversation

Initializing gpmc before accessing flash

PATCH In review Mathieu Poirier 2 participants 2 messages Aug 11, 2010 – Aug 12, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Mathieu Poirier

author
#0 lore raw

PATCH 1/1 Initializing gpmc before accessing flash

Quoted 1 line

From b12de3010763a8c047eefd2eb9296eb68157b07e Mon Sep 17 00:00:00 2001

From: Mathieu J. Poirier <[email protected]>
Date: Tue, 10 Aug 2010 17:14:25 -0400
Subject: [PATCH] Initializing gpmc before accessing flash

Adding initialization of the General Purpose Memory Controller (gpmc) in 'omap3beagle_flash_init'.

The gpmc init was decoupled from nand flash init and got its own init function. This change was not reflected in 'omap3beagle_flash_init' resulting in a lookup failure when probing for flash.

BugLink https://bugs/launchpad.net/bugs/608266
Signed-off-by Mathieu Poirier <[email protected]>
---
 arch/arm/mach-omap2/board-omap3beagle.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +1 -0
index 7a1b351..e1203a4 100644
@@ -466,6 +466,7 @@ static void __init omap3beagle_flash_init(void)
 		omap3beagle_nand_data.gpmc_cs_baseaddr = (void *)
 			(gpmc_base_add + GPMC_CS0_BASE + nandcs * GPMC_CS_SIZE);
 		omap3beagle_nand_data.gpmc_baseaddr = (void *) (gpmc_base_add);
+               gpmc_nand_init(&omap3beagle_nand_data);
 
 		printk(KERN_INFO "Registering NAND on CS%d\n", nandcs);
 		if (platform_device_register(&omap3beagle_nand_device) < 0)
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 36 lines

-----Original Message-----
From: [email protected] [mailto:linux-omap- [email protected]] On Behalf Of Mathieu Poirier
Sent: Wednesday, August 11, 2010 8:12 PM
To: [email protected]
Cc: [email protected]; Mathieu Poirier
Subject: [PATCH] Initializing gpmc before accessing flash

Quoted 1 line

From b12de3010763a8c047eefd2eb9296eb68157b07e Mon Sep 17 00:00:00 2001

From: Mathieu J. Poirier <[email protected]>
Date: Tue, 10 Aug 2010 17:14:25 -0400
Subject: [PATCH] Initializing gpmc before accessing flash

Adding initialization of the General Purpose Memory Controller (gpmc) in 'omap3beagle_flash_init'.

The gpmc init was decoupled from nand flash init and got its own init function. This change was not reflected in 'omap3beagle_flash_init' resulting in a lookup failure when probing for flash.

BugLink https://bugs/launchpad.net/bugs/608266
Signed-off-by Mathieu Poirier <[email protected]>
---
 arch/arm/mach-omap2/board-omap3beagle.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-omap2/board-omap3beagle.c +0 -0

omap2/board-omap3beagle.c
index 7a1b351..e1203a4 100644

arch/arm/mach-omap2/board-omap3beagle.c static void __init omap3beagle_flash_init(void) · line 470

Quoted 5 lines
arch/arm/mach-omap2/board-omap3beagle.c +1 -0
@@ -466,6 +466,7 @@ static void __init omap3beagle_flash_init(void)
 		omap3beagle_nand_data.gpmc_cs_baseaddr = (void *)
 			(gpmc_base_add + GPMC_CS0_BASE + nandcs * GPMC_CS_SIZE);
 		omap3beagle_nand_data.gpmc_baseaddr = (void *)
 (gpmc_base_add);
+               gpmc_nand_init(&omap3beagle_nand_data);

[Ghorai] things are queued for 2.6.36; can refer
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=f450d86790ebf72ac93c7ea5addd6fa278aae64c

Quoted 12 lines
arch/arm/mach-omap2/board-omap3beagle.c +0 -1
 		printk(KERN_INFO "Registering NAND on CS%d\n", nandcs);
 		if (platform_device_register(&omap3beagle_nand_device) < 0)
--

1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html