regulator: ab8500 - fix the logic to remove already registered regulators in error path

-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: Saturday, August 14, 2010 7:14 PM
To: linux-kernel
Cc: Liam Girdwood; Mark Brown; Sundar R IYER
Subject: [PATCH] regulator: ab8500 - fix the logic to remove already registered regulators in error path

In current implementation, ab8500_regulator_info[0].regulator is not unregistered if the error happen at i > 0.

This patch fixes the resource leak and also improves the readability.

Signed-off-by Axel Lin <[email protected]>

---
I think this change is better ( in readability ) than simply change "while (i > 0)" to "while (i >= 0)".

drivers/regulator/ab8500.c | 4 +---

1 files changed, 1 insertions(+), 3 deletions(-)

drivers/regulator/ab8500.c +1 -3

index dc3f1a4..775688e 100644
@@ -368,11 +368,9 @@ static __devinit int ab8500_regulator_probe(struct
 platform_device *pdev)
 			dev_err(&pdev->dev, "failed to register regulator %s\n",
 					info->desc.name);
 			/* when we fail, un-register all earlier regulators */
-			i--;
-			while (i > 0) {
+			while (--i >= 0) {
 				info = &ab8500_regulator_info[i];
 				regulator_unregister(info->regulator);
-				i--;
 			}
 			return err;

		}

--
1.7.0.4

BTW, could you also include the AB3100 as well into this patch? I derived it from the AB3100 implementation.

-----Original Message-----
From: Sundar R IYER
Sent: Saturday, August 14, 2010 8:05 PM
To: 'Axel Lin'; linux-kernel
Cc: Liam Girdwood; Mark Brown; Linus WALLEIJ
Subject: RE: [PATCH] regulator: ab8500 - fix the logic to remove already registered regulators in error path

Thanx!

BTW, could you also include the AB3100 as well into this patch? I derived it from the AB3100 implementation.

Linus, any comments?

Regards,
Sundar

Quoted 35 lines

-----Original Message-----
From: Axel Lin [mailto:[email protected]]
Sent: Saturday, August 14, 2010 7:14 PM
To: linux-kernel
Cc: Liam Girdwood; Mark Brown; Sundar R IYER
Subject: [PATCH] regulator: ab8500 - fix the logic to remove already registered regulators in error path

In current implementation, ab8500_regulator_info[0].regulator is not unregistered if the error happen at i > 0.

This patch fixes the resource leak and also improves the readability.

Signed-off-by Axel Lin <[email protected]>

---
I think this change is better ( in readability ) than simply change "while (i > 0)" to "while (i >= 0)".

drivers/regulator/ab8500.c | 4 +---

1 files changed, 1 insertions(+), 3 deletions(-)

drivers/regulator/ab8500.c +1 -2

index dc3f1a4..775688e 100644
@@ -368,11 +368,9 @@ static __devinit int ab8500_regulator_probe(struct
 platform_device *pdev)
 			dev_err(&pdev->dev, "failed to register regulator %s\n",
 					info->desc.name);
 			/* when we fail, un-register all earlier regulators */
-			i--;
-			while (i > 0) {
+			while (--i >= 0) {
 				info = &ab8500_regulator_info[i];
 				regulator_unregister(info->regulator);

Quoted 8 lines

drivers/regulator/ab8500.c +0 -1

-				i--;
 			}
 			return err;

		}

--
1.7.0.4

In current implementation, ab8500_regulator_info[0].regulator is not unregistered if the error happen at i > 0.

This patch fixes the resource leak and also improves the readability.

Signed-off-by Axel Lin <[email protected]>

In current implementation, ab8500_regulator_info[0].regulator is not unregistered if the error happen at i > 0.

This patch fixes the resource leak and also improves the readability.

Signed-off-by Axel Lin <[email protected]>

---
I think this change is better ( in readability ) than simply change "while (i > 0)" to "while (i >= 0)".

 drivers/regulator/ab8500.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

drivers/regulator/ab8500.c +0 -0

index dc3f1a4..775688e 100644
@@ -368,11 +368,9 @@ static __devinit int ab8500_regulator_probe(struct platform_device *pdev)
 			dev_err(&pdev->dev, "failed to register regulator %s\n",
 					info->desc.name);