Fixes field names that changed

PATCH In review Henrique Camargo 2 participants 4 messages Aug 17, 2010 – Aug 19, 2010 Media (V4L/DVB)

Share & tools

Henrique Camargo

author

2010-08-17 14:34 UTC #0 lore raw

PATCH 1/1 Fixes field names that changed

If CONFIG_VIDEO_ADV_DEBUG was set, the driver failed to compile because the fields get_register and set_register changed names to s_register and s_register in the struct v4l2_subdev_core_ops.

Signed-off-by Henrique Camargo <[email protected]>

---
 drivers/media/video/mt9t031.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/media/video/mt9t031.c +2 -2

index 716fea6..f3d1995 100644
@@ -499,8 +499,8 @@ static const struct v4l2_subdev_core_ops mt9t031_core_ops = {
 	.g_ctrl	= mt9t031_get_control,
 	.s_ctrl	= mt9t031_set_control,
 #ifdef CONFIG_VIDEO_ADV_DEBUG
-	.get_register = mt9t031_get_register,
-	.set_register = mt9t031_set_register,
+	.g_register = mt9t031_get_register,
+	.s_register = mt9t031_set_register,
 #endif
 };

Signature · 1 line

1.7.0.4

Aguirre, Sergio

2010-08-19 00:16 UTC #1 lore raw

Hi Henrique,

Just some minor comments about the patch description below:

Quoted 8 lines

-----Original Message-----
From: [email protected] [mailto:linux-media- [email protected]] On Behalf Of Henrique Camargo
Sent: Tuesday, August 17, 2010 9:35 AM
To: Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski; Karicheri, Muralidharan; linux- [email protected]; [email protected]
Subject: [PATCH] Fixes field names that changed

Add missing subject prefix to quickly describe the affected driver:

Subject: [PATCH] mt9t032: Fixes field names that changed

Quoted 4 lines

If CONFIG_VIDEO_ADV_DEBUG was set, the driver failed to compile because the fields get_register and set_register changed names to s_register and s_register in the struct v4l2_subdev_core_ops.

Please break down this comment to 70 chars max.

Also, you said "s_register" twice.

Regards,
Sergio

Quoted 31 lines

Signed-off-by Henrique Camargo <[email protected]>
---
 drivers/media/video/mt9t031.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/media/video/mt9t031.c +2 -3
index 716fea6..f3d1995 100644
@@ -499,8 +499,8 @@ static const struct v4l2_subdev_core_ops
 mt9t031_core_ops = {
 	.g_ctrl	= mt9t031_get_control,
 	.s_ctrl	= mt9t031_set_control,
 #ifdef CONFIG_VIDEO_ADV_DEBUG
-	.get_register = mt9t031_get_register,
-	.set_register = mt9t031_set_register,
+	.g_register = mt9t031_get_register,
+	.s_register = mt9t031_set_register,
 #endif
 };
 
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Aguirre, Sergio

2010-08-19 00:18 UTC #2 lore raw

Oops, fixing my own typo below:

Quoted 22 lines

-----Original Message-----
From: [email protected] [mailto:linux-media- [email protected]] On Behalf Of Aguirre, Sergio
Sent: Wednesday, August 18, 2010 7:16 PM
To: [email protected]; Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski; Karicheri, Muralidharan; linux- [email protected]; [email protected]
Subject: RE: [PATCH] Fixes field names that changed
Hi Henrique,
Just some minor comments about the patch description below:
Quoted 8 lines
-----Original Message-----
From: [email protected] [mailto:linux-media- [email protected]] On Behalf Of Henrique Camargo
Sent: Tuesday, August 17, 2010 9:35 AM
To: Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski; Karicheri, Muralidharan; linux- [email protected]; [email protected]
Subject: [PATCH] Fixes field names that changed

Quoted 3 lines

Add missing subject prefix to quickly describe the affected driver:
Subject: [PATCH] mt9t032: Fixes field names that changed

mt9t032 -> mt9t031.

Sorry...

Regards,
Sergio

Quoted 50 lines

Quoted 5 lines
If CONFIG_VIDEO_ADV_DEBUG was set, the driver failed to compile because the fields get_register and set_register changed names to s_register and s_register in the struct v4l2_subdev_core_ops.
Please break down this comment to 70 chars max.
Also, you said "s_register" twice.
Regards,
Sergio
Review
Quoted 7 lines
Signed-off-by Henrique Camargo <[email protected]>
---
 drivers/media/video/mt9t031.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/media/video/mt9t031.c
Quoted 20 lines
index 716fea6..f3d1995 100644
drivers/media/video/mt9t031.c +2 -3
@@ -499,8 +499,8 @@ static const struct v4l2_subdev_core_ops
 mt9t031_core_ops = {
 	.g_ctrl	= mt9t031_get_control,
 	.s_ctrl	= mt9t031_set_control,
 #ifdef CONFIG_VIDEO_ADV_DEBUG
-	.get_register = mt9t031_get_register,
-	.set_register = mt9t031_set_register,
+	.g_register = mt9t031_get_register,
+	.s_register = mt9t031_set_register,
 #endif
 };
 
--
1.7.0.4
Quoted 2 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-media"
in
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Henrique Camargo

author

2010-08-19 18:33 UTC #3 lore raw

Thank you Sergio for your help, I resent the patch a couple of minutes ago taking your changes into account.

Best Regards,
Henrique Camargo

Quoted 84 lines · Sergio

Oops, fixing my own typo below:
Quoted 22 lines
-----Original Message-----
From: [email protected] [mailto:linux-media- [email protected]] On Behalf Of Aguirre, Sergio
Sent: Wednesday, August 18, 2010 7:16 PM
To: [email protected]; Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski; Karicheri, Muralidharan; linux- [email protected]; [email protected]
Subject: RE: [PATCH] Fixes field names that changed
Hi Henrique,
Just some minor comments about the patch description below:
Quoted 8 lines
-----Original Message-----
From: [email protected] [mailto:linux-media- [email protected]] On Behalf Of Henrique Camargo
Sent: Tuesday, August 17, 2010 9:35 AM
To: Mauro Carvalho Chehab
Cc: Guennadi Liakhovetski; Karicheri, Muralidharan; linux- [email protected]; [email protected]
Subject: [PATCH] Fixes field names that changed
Quoted 3 lines
Add missing subject prefix to quickly describe the affected driver:
Subject: [PATCH] mt9t032: Fixes field names that changed
mt9t032 -> mt9t031.
Sorry...
Regards,
Sergio
Quoted 50 lines
Quoted 5 lines
If CONFIG_VIDEO_ADV_DEBUG was set, the driver failed to compile because the fields get_register and set_register changed names to s_register and s_register in the struct v4l2_subdev_core_ops.
Please break down this comment to 70 chars max.
Also, you said "s_register" twice.
Regards,
Sergio
Review
Quoted 7 lines
Signed-off-by Henrique Camargo <[email protected]>
---
 drivers/media/video/mt9t031.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/media/video/mt9t031.c
Quoted 20 lines
index 716fea6..f3d1995 100644
drivers/media/video/mt9t031.c +2 -3
@@ -499,8 +499,8 @@ static const struct v4l2_subdev_core_ops
 mt9t031_core_ops = {
 	.g_ctrl	= mt9t031_get_control,
 	.s_ctrl	= mt9t031_set_control,
 #ifdef CONFIG_VIDEO_ADV_DEBUG
-	.get_register = mt9t031_get_register,
-	.set_register = mt9t031_set_register,
+	.g_register = mt9t031_get_register,
+	.s_register = mt9t031_set_register,
 #endif
 };
 
--
1.7.0.4
Quoted 2 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-media"
in
Quoted 2 lines
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html