Skip to contentSkip to conversation

stop_machine: convert cpu notifier to return encapsulate errno value

PATCH New Akinobu Mita 1 participant 1 message Aug 21, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 stop_machine: convert cpu notifier to return encapsulate errno value

By the commit e6bde73b07edeb703d4c89c1daabc09c303de11f ("cpu-hotplug: return better errno on cpu hotplug failure"), the cpu notifier can return encapsulate errno value.

This converts the cpu notifier to return encapsulate errno value for stop_machine.

---
 kernel/stop_machine.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
kernel/stop_machine.c +2 -2
index 4372ccb..9f95199 100644
@@ -303,7 +303,7 @@ static int __cpuinit cpu_stop_cpu_callback(struct notifier_block *nfb,
 		p = kthread_create(cpu_stopper_thread, stopper, "migration/%d",
 				   cpu);
 		if (IS_ERR(p))
-			return NOTIFY_BAD;
+			return notifier_from_errno(PTR_ERR(p));
 		sched_setscheduler_nocheck(p, SCHED_FIFO, &param);
 		get_task_struct(p);
 		stopper->thread = p;
@@ -370,7 +370,7 @@ static int __init cpu_stop_init(void)
 	/* start one for the boot cpu */
 	err = cpu_stop_cpu_callback(&cpu_stop_cpu_notifier, CPU_UP_PREPARE,
 				    bcpu);
-	BUG_ON(err == NOTIFY_BAD);
+	BUG_ON(err != NOTIFY_OK);
 	cpu_stop_cpu_callback(&cpu_stop_cpu_notifier, CPU_ONLINE, bcpu);
 	register_cpu_notifier(&cpu_stop_cpu_notifier);
 
Signature · 1 line
1.6.0.6