Skip to contentSkip to conversation

perf fixlet

GIT PULL Frederic Weisbecker 1 participant 1 message Aug 22, 2010 perf events

lore
Share & tools
lore
#0 lore raw

Ingo,

Please pull the perf/urgent branch that can be found at:

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
perf/urgent

Thanks,
Frederic
---

Frederic Weisbecker (1):
perf: Initialize callchains roots's childen hits

 tools/perf/util/callchain.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

---
commit 944c88c5ebf7bead43a98fc4cb89b195ee8792d1

Author: Frederic Weisbecker <[email protected]>
Date:   Sun Aug 22 04:29:17 2010 +0200

perf: Initialize callchains roots's childen hits

Each histogram entry has a callchain root that stores the callchain samples. However we forgot to initialize the tracking of children hits of these roots, which then got random values on their creation.

The root children hits is multiplied by the minimum percentage of hits provided by the user, and the result becomes the minimum hits expected from children branches. If the random value due to the uninitialization is big enough, then this minimum number of hits can be huge and eventually filter every children branches.

The end result was invisible callchains. All we need to fix this is to initialize the children hits of the root.

Cc Ingo Molnar <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc 2.6.32.x-2.6.35.y <[email protected]>
tools/perf/util/callchain.h +1 -0
index 624a96c..6de4313 100644
@@ -50,6 +50,7 @@ static inline void callchain_init(struct callchain_node *node)
 	INIT_LIST_HEAD(&node->children);
 	INIT_LIST_HEAD(&node->val);
 
+	node->children_hit = 0;
 	node->parent = NULL;
 	node->hit = 0;
 }