Skip to contentSkip to conversation

ptrace: annotate siglock acquirement

PATCH In review Namhyung Kim 2 participants 2 messages Aug 22, 2010 – Aug 23, 2010 ptrace support

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 ptrace: annotate siglock acquirement

lock_task_sighand() conditionally acquires sighand->siglock in case of returning non-NULL but unlock_task_sighand() releases it unconditionally. This leads sparse to complain about the lock context imbalance. Annotate it to make sparse happier.

---
 kernel/ptrace.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
kernel/ptrace.c +2 -0
index 1abbb4d..4553275 100644
@@ -438,6 +438,7 @@ static int ptrace_getsiginfo(struct task_struct *child, siginfo_t *info)
 	int error = -ESRCH;
 
 	if (lock_task_sighand(child, &flags)) {
+		__acquire(&child->sighand->siglock);
 		error = -EINVAL;
 		if (likely(child->last_siginfo != NULL)) {
 			*info = *child->last_siginfo;
@@ -454,6 +455,7 @@ static int ptrace_setsiginfo(struct task_struct *child, const siginfo_t *info)
 	int error = -ESRCH;
 
 	if (lock_task_sighand(child, &flags)) {
+		__acquire(&child->sighand->siglock);
 		error = -EINVAL;
 		if (likely(child->last_siginfo != NULL)) {
 			*child->last_siginfo = *info;
Signature · 1 line
1.7.0.4