spi/spi_s3c64xx: Warn if PIO transfers time out
Subsystems (2)
PATCH 1/1 spi/spi_s3c64xx: Warn if PIO transfers time out
When using PIO we have a timeout for the TX and RX FIFOs to ensure that the data actually gets transferred. Warn if we hit that timeout - it should never happen, but this makes sure we'll find out if it does.
--- drivers/spi/spi_s3c64xx.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/spi/spi_s3c64xx.c +6 -0
@@ -200,6 +200,9 @@ static void flush_fifo(struct s3c64xx_spi_driver_data *sdd) val =readl (regs +S3C64XX_SPI_STATUS ); }while (TX_FIFO_LVL (val, sci) && loops--); +if (loops ==0 ) +dev_warn (&sdd->pdev->dev,"Timed out flushing TX FIFO\n" ); +/* Flush RxFIFO*/ loops =msecs_to_loops (1 ); do {
@@ -210,6 +213,9 @@ static void flush_fifo(struct s3c64xx_spi_driver_data *sdd)break ; }while (loops--); +if (loops ==0 ) +dev_warn (&sdd->pdev->dev,"Timed out flushing RX FIFO\n" ); + val =readl (regs +S3C64XX_SPI_CH_CFG ); val &= ~S3C64XX_SPI_CH_SW_RST ;writel (val, regs +S3C64XX_SPI_CH_CFG );
Signature · 9 lines
1.7.1 ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev
Quoted 24 lines · Mark Brown
When using PIO we have a timeout for the TX and RX FIFOs to ensure that the data actually gets transferred. Warn if we hit that timeout - it should never happen, but this makes sure we'll find out if it does.
Signed-off-by Mark Brown <[email protected]>---
drivers/spi/spi_s3c64xx.c | 6 ++++++1 files changed, 6 insertions(+), 0 deletions(-)drivers/spi/spi_s3c64xx.c +3
-0@@ -200,6 +200,9 @@ static void flush_fifo(struct s3c64xx_spi_driver_data *sdd) val = readl(regs + S3C64XX_SPI_STATUS); } while (TX_FIFO_LVL(val, sci) && loops--); + if (loops == 0) + dev_warn(&sdd->pdev->dev, "Timed out flushing TX FIFO\n"); + /* Flush RxFIFO*/ loops = msecs_to_loops(1); do {
drivers/spi/spi_s3c64xx.c static void flush_fifo(struct s3c64xx_spi_driver_data *sdd) · line 221
Quoted 9 lines
drivers/spi/spi_s3c64xx.c +3
-0@@ -210,6 +213,9 @@ static void flush_fifo(struct s3c64xx_spi_driver_data *sdd) break; } while (loops--); + if (loops == 0) + dev_warn(&sdd->pdev->dev, "Timed out flushing RX FIFO\n"); + val = readl(regs + S3C64XX_SPI_CH_CFG); val &= ~S3C64XX_SPI_CH_SW_RST; writel(val, regs + S3C64XX_SPI_CH_CFG);
Ok, though I'll be very surprised to see the FIFO flush failing. We are not waiting
for data to be transferred, but for SW Reset to make its effect.
------------------------------------------------------------------------------
Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future.
http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________
spi-devel-general mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Grant Likely
AppliedQuoted 40 lines · Jassi Brar
Quoted 24 lines · Mark Brown
When using PIO we have a timeout for the TX and RX FIFOs to ensure that the data actually gets transferred. Warn if we hit that timeout - it should never happen, but this makes sure we'll find out if it does.
Signed-off-by Mark Brown <[email protected]>---
drivers/spi/spi_s3c64xx.c | 6 ++++++1 files changed, 6 insertions(+), 0 deletions(-)drivers/spi/spi_s3c64xx.c +3
-0@@ -200,6 +200,9 @@ static void flush_fifo(struct s3c64xx_spi_driver_data *sdd) val = readl(regs + S3C64XX_SPI_STATUS); } while (TX_FIFO_LVL(val, sci) && loops--); + if (loops == 0) + dev_warn(&sdd->pdev->dev, "Timed out flushing TX FIFO\n"); + /* Flush RxFIFO*/ loops = msecs_to_loops(1); do {drivers/spi/spi_s3c64xx.c static void flush_fifo(struct s3c64xx_spi_driver_data *sdd) · line 221
Quoted 9 lines
drivers/spi/spi_s3c64xx.c +3
-0@@ -210,6 +213,9 @@ static void flush_fifo(struct s3c64xx_spi_driver_data *sdd) break; } while (loops--); + if (loops == 0) + dev_warn(&sdd->pdev->dev, "Timed out flushing RX FIFO\n"); + val = readl(regs + S3C64XX_SPI_CH_CFG); val &= ~S3C64XX_SPI_CH_SW_RST; writel(val, regs + S3C64XX_SPI_CH_CFG);Ok, though I'll be very surprised to see the FIFO flush failing. We are not waiting
for data to be transferred, but for SW Reset to make its effect.
Quoted 1 line
Acked-by Jassi Brar <[email protected]>
Applied, thanks.
g.