Skip to contentSkip to conversation

APM82xxx: Add top level common file changes

PATCH New tmarri at apm.com 4 participants 8 messages Aug 26, 2010 – Sep 1, 2010 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 8/8 APM82xxx: Add top level common file changes

From: Tirumala Marri <[email protected]>

Add bluestone board name to the board.cfg.
Change Makefile to include bluestone board support. Modified MAINTAINERS file to include board maintainers name. Modified to include blouestone entry in the MAKEALL file.

---
 MAINTAINERS |    3 +++
 MAKEALL     |    1 +
 Makefile    |    7 +++++++
 boards.cfg  |    1 +
 4 files changed, 12 insertions(+), 0 deletions(-)
MAINTAINERS +3 -0
index 4b91b0f..263c00b 100644
@@ -253,6 +253,9 @@ Feng Kan <[email protected]>
 
 	redwood			PPC4xx
 
+Tirumala Marri<[email protected]>
+	bluestone	APM82XXX
+
 Brad Kemp <[email protected]>
 
 	ppmc8260	MPC8260
MAKEALL +1 -0
index b34ae33..02d5c17 100755
@@ -191,6 +191,7 @@ LIST_4xx="		\
 	ASH405		\
 	bamboo		\
 	bamboo_nand	\
+	bluestone	\
 	bubinga		\
 	CANBT		\
 	canyonlands	\
Makefile +7 -0
index 4f1cb1b..8cd5bd3 100644
@@ -926,6 +926,13 @@ bamboo_nand_config:	unconfig
 	@echo "CONFIG_NAND_U_BOOT = y" >> $(obj)include/config.mk
 	@$(MKCONFIG) -n $@ -a bamboo powerpc ppc4xx bamboo amcc
 
+# Maui Bluestone board images
+bluestone_config:   unconfig
+	@mkdir -p $(obj)include
+	@echo "#define CONFIG_$$(echo $(subst ,,$(@:_config=)) | \
+		tr '[:lower:]' '[:upper:]')" >$(obj)include/config.h
+	@$(MKCONFIG) -n $@ -a bluestone powerpc ppc4xx bluestone amcc
+
 # Arches, Canyonlands & Glacier use different U-Boot images
 arches_config \
 canyonlands_config \
boards.cfg +1 -0
index 69c6897..48001d3 100644
@@ -196,6 +196,7 @@ redwood		powerpc	ppc4xx		-		amcc
 taihu		powerpc	ppc4xx		-		amcc
 taishan		powerpc	ppc4xx		-		amcc
 yucca		powerpc	ppc4xx		-		amcc
+bluestone 	powerpc ppc4xx		-		amcc
 AP1000		powerpc	ppc4xx		ap1000		amirix
 CRAYL1		powerpc	ppc4xx		L1		cray
 ADCIOP		powerpc	ppc4xx		adciop		esd
Signature · 1 line
1.6.1.rc3
#1 lore raw

PATCH 8/8 APM82xxx: Add top level common file changes

Hi Marri,

Quoted 4 lines · On Thursday 26 August 2010 23:06:20 tmarri at apm.com wrote:

From: Tirumala Marri <[email protected]>

Add bluestone board name to the board.cfg. Change Makefile to include bluestone board support.

Not needed with board.cfg now. Please remove your changes to Makefile.

Compiling bluestone results in this warning:

[stefan at stefan-desktop u-boot (apm82xxx)]$ ./MAKEALL bluestone Configuring for bluestone board...
cpu_init.c: In function 'cpu_init_f':
cpu_init.c:226: warning: unused variable 'val'

Please fix and resubmit. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#2 lore raw

PATCH 8/8 APM82xxx: Add top level common file changes

Quoted 10 lines · On Thursday 26 August 2010 23:06:20 tmarri at apm.com wrote:
Quoted 4 lines

From: Tirumala Marri <[email protected]>

Add bluestone board name to the board.cfg. Change Makefile to include bluestone board support.

Not needed with board.cfg now. Please remove your changes to Makefile.

Compiling bluestone results in this warning:

[Marri] Sure will fix it.

Quoted 10 lines

[stefan at stefan-desktop u-boot (apm82xxx)]$ ./MAKEALL bluestone Configuring for bluestone board...
cpu_init.c: In function 'cpu_init_f':
cpu_init.c:226: warning: unused variable 'val'

Please fix and resubmit. Thanks.

Cheers,
Stefan

Regards,
Marri

#3 lore raw

PATCH 8/8 APM82xxx: Add top level common file changes

In reply to Stefan Roese

Hi Stefan,

Quoted 5 lines
Quoted 2 lines

Add bluestone board name to the board.cfg. Change Makefile to include bluestone board support.

Not needed with board.cfg now. Please remove your changes to Makefile.

[Marri] You mean we only need board.cfg change and we don't need Makefile entry ?

Regards,
Marri

#4 lore raw

PATCH 8/8 APM82xxx: Add top level common file changes

Hi Marri,

Quoted 7 lines · On Wednesday 01 September 2010 00:35:32 Tirumala Marri wrote:
Quoted 4 lines
Quoted 2 lines

Add bluestone board name to the board.cfg. Change Makefile to include bluestone board support.

Not needed with board.cfg now. Please remove your changes to Makefile.

[Marri] You mean we only need board.cfg change and we don't need Makefile entry ?

Yes.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#5 lore raw

PATCH 8/8 APM82xxx: Add top level common file changes

In reply to Tirumala Marri
Quoted 8 lines · Tirumala Marri

Hi Stefan,

Quoted 5 lines
Quoted 2 lines

Add bluestone board name to the board.cfg. Change Makefile to include bluestone board support.

Not needed with board.cfg now. Please remove your changes to Makefile.

[Marri] You mean we only need board.cfg change and we don't need Makefile entry ?

Yes, exactly.

Rogan

#6 lore raw

PATCH 8/8 APM82xxx: Add top level common file changes

In reply to tmarri at apm.com

Dear tmarri at apm.com,

Quoted 3 lines · In message <[email protected]> you wrote:

From: Tirumala Marri <[email protected]>

Add bluestone board name to the board.cfg.

NAK. This must not ne a separate commit.

Quoted 1 line

Change Makefile to include bluestone board support.

NAK. This is not needed and not allowed any more.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Prof:        So the American government went to IBM to come up with a
             data encryption standard and they came up with ...
Student:     EBCDIC!
#7 lore raw

PATCH 8/8 APM82xxx: Add top level common file changes

Quoted 19 lines

-----Original Message-----
From: Wolfgang Denk [mailto:wd at denx.de]
Sent: Sunday, August 29, 2010 1:57 AM
To: tmarri at apm.com
Cc: u-boot at lists.denx.de; open-source-review at apm.com
Subject: Re: [U-Boot] [PATCH 8/8] APM82xxx: Add top level common file changes

Dear tmarri at apm.com,

In message <[email protected]> you

Quoted 3 lines · wrote:

From: Tirumala Marri <[email protected]>

Add bluestone board name to the board.cfg.

NAK. This must not ne a separate commit.

Quoted 9 lines
Quoted 1 line

Change Makefile to include bluestone board support.

NAK. This is not needed and not allowed any more.

Best regards,

Wolfgang Denk

Mr Wolfgang,
Sure I will fix it.
Regards,
Marri