USB: musb-gadget: enable autoclear for OUT transfer in both DMA 0 and DMA 1
Subsystems (2)
PATCH 1/2 USB: musb-gadget: enable autoclear for OUT transfer in both DMA 0 and DMA 1
From: Ming Lei <[email protected]>
This patch fixes one bugs of OUT transfer in double buffer case:
-the current code only enable autoclear for dma mode 1, and not for dma mode 0
Without this patch, test #5 of usbtest can't be passed if we configure musb as g_zero and use fifo mode 3 to enable double buffer mode.
With this patch and the following patch(fix dma length), on my beagle B5, test#5(queued bulk out) may go beyond 18Mbyte/s(seems dma mode 0 is quicker in double buffer case) if musb is configured as g_zero and fifo mode 3 is taken, follows the test command:
#./testusb -D DEV_NAME -c 1024 -t 5 -s 32768 -g 8 [1]
Also I have tested this patch can't make g_ether broken.
[1],
-source of testusb : tools/usb/testusb.c under linux kernel;
--- drivers/usb/musb/musb_gadget.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/usb/musb/musb_gadget.c +1 -1
@@ -645,9 +645,9 @@ static void rxstate(struct musb *musb, struct musb_request *req)*/ csr |=MUSB_RXCSR_DMAENAB ; -#ifdef USE_MODE1 if (!musb_ep->hb_mult) csr |=MUSB_RXCSR_AUTOCLEAR ; +#ifdef USE_MODE1 /* csr |= MUSB_RXCSR_DMAMODE; */ /* this special sequence (enabling and then
Signature · 1 line
1.6.2.5
Quoted 22 lines · [email protected] wrote:
From: Ming Lei <[email protected]>
This patch fixes one bugs of OUT transfer in double buffer case:
-the current code only enable autoclear for dma mode 1, and not for dma mode 0
Without this patch, test #5 of usbtest can't be passed if we configure musb as
g_zeroand use fifo mode 3 to enable double buffer mode.With this patch and the following patch(fix dma length), on my beagle B5, test#5(queued bulk out) may go beyond 18Mbyte/s(seems dma mode 0 is quicker in double buffer case) if musb is configured as
g_zeroand fifo mode 3 is taken, follows the test command:#./testusb -D DEV_NAME -c 1024 -t 5 -s 32768 -g 8 [1]Also I have tested this patch can't make
g_etherbroken.
Quoted 7 lines
[1],
-source of testusb : tools/usb/testusb.c under linux kernel;Signed-off-by Ming Lei <[email protected]>Cc Anand Gadiyar <[email protected]>Cc Mike Frysinger <[email protected]>Cc Sergei Shtylyov <[email protected]>
I'm not 100% sure why not having autoclear was causing a failure with double-buffering enabled. I'd like this patch to be tested more on OMAP as well as on Blackfin/Davinci.
I'll need time to study MUSB specs again to understand this, so I'll skip acking this patch and let Felipe/Sergei/Mike/Ajay take a look.
Thanks for taking the time to debug this - if this patch series makes double buffering work reliably, that's a very good boost to throughput.
- Anand
Quoted 23 lines
--- drivers/usb/musb/musb_gadget.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/musb/musb_gadget.c +1
-1@@ -645,9 +645,9 @@ static void rxstate(struct musb *musb, struct musb_request *req)*/ csr |=MUSB_RXCSR_DMAENAB ; -#ifdef USE_MODE1 if (!musb_ep->hb_mult) csr |=MUSB_RXCSR_AUTOCLEAR ; +#ifdef USE_MODE1 /* csr |= MUSB_RXCSR_DMAMODE; */ /* this special sequence (enabling and then Signature · 1 line
1.6.2.5
2010/8/27 Gadiyar, Anand <[email protected]>:
Quoted 26 lines
Quoted 25 lines · [email protected] wrote:
From: Ming Lei <[email protected]>
This patch fixes one bugs of OUT transfer in double buffer case:
-the current code only enable autoclear for dma mode 1, and not for dma mode 0
Without this patch, test #5 of usbtest can't be passed if we configure musb as
g_zeroand use fifo mode 3 to enable double buffer mode.With this patch and the following patch(fix dma length), on my beagle B5, test#5(queued bulk out) may go beyond 18Mbyte/s(seems dma mode 0 is quicker in double buffer case) if musb is configured as
g_zeroand fifo mode 3 is taken, follows the test command:#./testusb -D
DEV_NAME-c 1024 -t 5 -s 32768 -g 8 [1]Also I have tested this patch can't make
g_etherbroken.[1],
-source of testusb :tools/usb/testusb.cunder linux kernel;
Quoted 8 lines
Quoted 4 lines
Signed-off-by Ming Lei <[email protected]>Cc Anand Gadiyar <[email protected]>Cc Mike Frysinger <[email protected]>Cc Sergei Shtylyov <[email protected]>I'm not 100% sure why not having autoclear was causing a failure with double-buffering enabled. I'd like this patch to be tested more on OMAP as well as on Blackfin/Davinci.
We don't clear MUSB_RXCSR_RXPKTRDY explicitly when dma complete, so if autoclear is not enabled, the dma read for packets from fifo will not be acked, then any odd things may happen...
I have tested the patch for both single buffer and double buffer case, test #5 and test #6 are passed, and result of test #5 in double buffer may go beyond 18M/s(seems much quicker than dma mode 1).
Also, g_ether is OK with the patch.
Quoted 4 lines
I'll need time to study MUSB specs again to understand this, so I'll skip acking this patch and let Felipe/Sergei/Mike/Ajay take a look.
Very good.
Quoted 31 lines
Thanks for taking the time to debug this - if this patch series makes double buffering work reliably, that's a very good boost to throughput.
- Anand
Quoted 23 lines
---
drivers/usb/musb/musb_gadget.c | 2 +-1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/musb/musb_gadget.c +1
-2@@ -645,9 +645,9 @@ static void rxstate(struct musb *musb, struct musb_request *req)*/ csr |= MUSB_RXCSR_DMAENAB; -#ifdef USE_MODE1 if (!musb_ep->hb_mult) csr |= MUSB_RXCSR_AUTOCLEAR; +#ifdef USE_MODE1 /* csr |= MUSB_RXCSR_DMAMODE; */ /* this special sequence (enabling and then -- 1.6.2.5
Signature · 5 lines
Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 38 lines · [email protected] wrote:
From: Ming Lei <[email protected]>
This patch fixes one bugs of OUT transfer in double buffer case:
-the current code only enable autoclear for dma mode 1, and not for dma mode 0
Without this patch, test #5 of usbtest can't be passed if we configure musb as
g_zeroand use fifo mode 3 to enable double buffer mode.With this patch and the following patch(fix dma length), on my beagle B5, test#5(queued bulk out) may go beyond 18Mbyte/s(seems dma mode 0 is quicker in double buffer case) if musb is configured as
g_zeroand fifo mode 3 is taken, follows the test command:#./testusb -D DEV_NAME -c 1024 -t 5 -s 32768 -g 8 [1]Also I have tested this patch can't make
g_etherbroken.[1],
-source of testusb : tools/usb/testusb.c under linux kernel;Signed-off-by Ming Lei <[email protected]>Cc Anand Gadiyar <[email protected]>Cc Mike Frysinger <[email protected]>Cc Sergei Shtylyov <[email protected]>--- drivers/usb/musb/musb_gadget.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/usb/musb/musb_gadget.c +0
-0
drivers/usb/musb/musb_gadget.c static void rxstate(struct musb *musb, struct musb_request *req) · line 649
Quoted 6 lines
drivers/usb/musb/musb_gadget.c +0
-1@@ -645,9 +645,9 @@ static void rxstate(struct musb *musb, struct musb_request *req)*/ csr |=MUSB_RXCSR_DMAENAB ; -#ifdef USE_MODE1 if (!musb_ep->hb_mult) csr |=MUSB_RXCSR_AUTOCLEAR ;
Hi Tom,
Which codebase is this patch meant for?
I don't see the hb_mult in current mainline code?
Are there any patches which this one depends on?
Thanks,
Anand
Quoted 4 lines
drivers/usb/musb/musb_gadget.c +1
-0+#ifdef USE_MODE1 /* csr |= MUSB_RXCSR_DMAMODE; */ /* this special sequence (enabling and then
2010/9/6 Gadiyar, Anand <[email protected]>:
Quoted 6 lines
Hi Tom,
Which codebase is this patch meant for?
I don't see thehb_multin current mainline code?Are there any patches which this one depends on?
This depends on the two iso for device mode patches:
http://marc.info/?l=linux-usb&m=128076716001885&w=2 http://marc.info/?l=linux-usb&m=128076716901924&w=2
I plan to resend the two patches above and the double buffer patches later.
thanks,
Signature · 5 lines
Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello.
Quoted 11 lines · Ming Lei
Quoted 4 lines
Which codebase is this patch meant for?
I don't see thehb_multin current mainline code?Are there any patches which this one depends on?
This depends on the two iso for device mode patches:
http://marc.info/?l=linux-usb&m=128076716001885&w=2 http://marc.info/?l=linux-usb&m=128076716901924&w=2I plan to resend the two patches above and the double buffer patches later.
I recommend that you change the ordering of patches so that fixes come
first, and new features last. I.e. this patch should precede the second one of those two above.
Quoted 1 line
thanks,
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
2010/9/7 Sergei Shtylyov <[email protected]>:
Quoted 13 lines
Hello.
Quoted 8 lines · Ming Lei
Quoted 4 lines
Which codebase is this patch meant for?
I don't see thehb_multin current mainline code?Are there any patches which this one depends on?
This depends on the two iso for device mode patches:
http://marc.info/?l=linux-usb&m=128076716001885&w=2
http://marc.info/?l=linux-usb&m=128076716901924&w=2
Quoted 6 lines
Quoted 2 lines
I plan to resend the two patches above and the double buffer patches later.
I recommend that you change the ordering of patches so that fixes come first, and new features last. I.e. this patch should precede the second one of those two above.
Good point, I will resend all the fix patches first, then the isochronous support
patch.
thanks,
Signature · 5 lines
Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html