Skip to contentSkip to conversation

regulator: ab8500 - fix off-by-one value range checking for selector

PATCH In review Axel Lin 2 participants 2 messages Sep 4, 2010 – Sep 5, 2010 Voltage and current regulator framework

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: ab8500 - fix off-by-one value range checking for selector

selector is used as array index of info->supported_voltages Thus the valid value range should be 0 .. info->voltages_len -1

---
 drivers/regulator/ab8500.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/regulator/ab8500.c +1 -1
index 3d09580..28c7ae6 100644
@@ -157,7 +157,7 @@ static int ab8500_list_voltage(struct regulator_dev *rdev, unsigned selector)
 	if (info->fixed_uV)
 		return info->fixed_uV;
 
-	if (selector > info->voltages_len)
+	if (selector >= info->voltages_len)
 		return -EINVAL;
 
 	return info->supported_voltages[selector];
Signature · 1 line
1.7.2