Skip to contentSkip to conversation

PATCH: b44 Handle RX FIFO overflow better (simplified)

PATCH Applied Mark Lord 2 participants 2 messages Sep 5, 2010 – Sep 7, 2010

Subsystems (2)
lore
Share & tools
lore

Mark Lord

author
#0 lore raw

This patch is a simplified version of the original patch from James Courtier-Dutton.

Quoted 11 lines

From: James Courtier-Dutton
Subject: [PATCH] Fix b44 RX FIFO overflow recovery.
Date: Wednesday, June 30, 2010 - 1:11 pm

This patch improves the recovery after a RX FIFO overflow on the b44 Ethernet NIC.
Before it would do a complete chip reset, resulting is loss of link for a few seconds.
This patch improves this to do recovery in about 20ms without loss of link.

Signed off by: [email protected]

drivers/net/b44.c +9 -0
@@ -851,6 +851,15 @@
 		b44_tx(bp);
 		/* spin_unlock(&bp->tx_lock); */
 	}
+	if (bp->istat & ISTAT_RFO) {	/* fast recovery, in ~20msec */
+		bp->istat &= ~ISTAT_RFO;
+		b44_disable_ints(bp);
+		ssb_device_enable(bp->sdev, 0); /* resets ISTAT_RFO */
+		b44_init_rings(bp);
+		b44_init_hw(bp, B44_FULL_RESET_SKIP_PHY);
+		netif_wake_queue(bp->dev);
+	}
+
 	spin_unlock_irqrestore(&bp->lock, flags);
 
 	work_done = 0;
maintainer Applied
#1 lore raw

From: Mark Lord <[email protected]>
Date: Sat, 04 Sep 2010 20:17:59 -0400

Quoted 12 lines

This patch is a simplified version of the original patch from James Courtier-Dutton.

Quoted 10 lines

From: James Courtier-Dutton
Subject: [PATCH] Fix b44 RX FIFO overflow recovery.
Date: Wednesday, June 30, 2010 - 1:11 pm

This patch improves the recovery after a RX FIFO overflow on the b44 Ethernet NIC.
Before it would do a complete chip reset, resulting is loss of link for a few seconds.
This patch improves this to do recovery in about 20ms without loss of link.

Quoted 3 lines
Quoted 1 line

Signed off by: [email protected]

Applied, thanks Mark.