Skip to contentSkip to conversation

ubifs: check return code of ubifs_lpt_lookup

PATCH In review Kulikov Vasiliy 2 participants 2 messages Sep 5, 2010 – Sep 7, 2010

Subsystems (3)
Kernel janitors Memory technology devices (MTD) UBI file system (UBIFS)
lore
Share & tools
lore

Kulikov Vasiliy

author
#0 lore raw

PATCH 11/14 ubifs: check return code of ubifs_lpt_lookup

From: Vasiliy Kulikov <[email protected]>

Function ubifs_lpt_lookup may return ERR_PTR(...). Check for it.

Signed-off-by Vasiliy Kulikov <[email protected]>

---
Compile tested.

 fs/ubifs/lpt.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
fs/ubifs/lpt.c +6 -1
index 0084a33..841bb36 100644
@@ -1351,6 +1351,7 @@ static int read_lsave(struct ubifs_info *c)
 {
 	int err, i;
 	void *buf;
+	struct ubifs_lprops *perr;
 
 	buf = vmalloc(c->lsave_sz);
 	if (!buf)

@@ -1370,7 +1371,11 @@ static int read_lsave(struct ubifs_info *c)
 		 */
 		if (lnum >= c->leb_cnt)
 			continue;
-		ubifs_lpt_lookup(c, lnum);
+		perr = ubifs_lpt_lookup(c, lnum);
+		if (IS_ERR(perr)) {
+			err = PTR_ERR(perr);
+			goto out;
+		}
 	}
 out:
 	vfree(buf);
Signature · 1 line
1.7.0.4