Skip to contentSkip to conversation

java-library.bbclass: do_stage is not needed anymore

PATCH In review Khem Raj 3 participants 6 messages Sep 7, 2010 – Sep 8, 2010

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 java-library.bbclass: do_stage is not needed anymore

---
 classes/java-library.bbclass |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
classes/java-library.bbclass +0 -4
index 904b4f1..5ce0537 100644
@@ -65,7 +65,3 @@ do_install() {
 java_stage() {
   oe_jarinstall -s ${JARFILENAME} ${ALTJARFILENAMES}
 }
-
-do_stage() {
-  java_stage
-}
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 2/2 jaxme_0.5.2.bb, xpp3_1.1.3.4.O.bb: Remove do_stage_append

---
 recipes/xml-commons/jaxme_0.5.2.bb    |    7 -------
 recipes/xml-commons/xpp3_1.1.3.4.O.bb |    4 ----
 2 files changed, 0 insertions(+), 11 deletions(-)
recipes/xml-commons/jaxme_0.5.2.bb +0 -7
index 4fa9cdf..304c06d 100644
@@ -39,13 +39,6 @@ do_install_append() {
 	oe_jarinstall jaxmepm-${PV}.jar jaxmepm.jar
 }
 
-do_stage_append() {
-	oe_jarinstall -s jaxmeapi-${PV}.jar jaxmeapi.jar
-	oe_jarinstall -s jaxmejs-${PV}.jar jaxmejs.jar
-	oe_jarinstall -s jaxmexs-${PV}.jar jaxmexs.jar
-	oe_jarinstall -s jaxmepm-${PV}.jar jaxmepm.jar
-}
-
 # Compile helper
 # 1 - source dir
 # 2 - dest dir
recipes/xml-commons/xpp3_1.1.3.4.O.bb +0 -4
index 11b82ab..40f7cb2 100644
@@ -42,10 +42,6 @@ do_install_append() {
 	oe_jarinstall xpp3-xpath-${PV}.jar xpp3-xpath.jar
 }
 
-do_stage_append() {
-	oe_jarinstall -s xpp3-xpath-${PV}.jar xpp3-xpath.jar
-}
-
 FILES_libxpp3-xpath-java = "${datadir}/java/xpp3-xpath*"
 
 
Signature · 1 line
1.7.1
#3 lore raw
In reply to Khem Raj

Patch is fine!

Am 07.09.2010 09:02, schrieb Khem Raj:

Quoted 17 lines
---
 classes/java-library.bbclass |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
classes/java-library.bbclass +0 -4
index 904b4f1..5ce0537 100644
@@ -65,7 +65,3 @@ do_install() {
 java_stage() {
   oe_jarinstall -s ${JARFILENAME} ${ALTJARFILENAMES}
 }
-
-do_stage() {
-  java_stage
-}
#2 lore raw

Re: [PATCH 2/2] jaxme_0.5.2.bb, xpp3_1.1.3.4.O.bb: Remove do_stage_append

In reply to Khem Raj

This as well.

Am 07.09.2010 09:02, schrieb Khem Raj:

Quoted 39 lines
---
 recipes/xml-commons/jaxme_0.5.2.bb    |    7 -------
 recipes/xml-commons/xpp3_1.1.3.4.O.bb |    4 ----
 2 files changed, 0 insertions(+), 11 deletions(-)
recipes/xml-commons/jaxme_0.5.2.bb +0 -7
index 4fa9cdf..304c06d 100644
@@ -39,13 +39,6 @@ do_install_append() {
 	oe_jarinstall jaxmepm-${PV}.jar jaxmepm.jar
 }
 
-do_stage_append() {
-	oe_jarinstall -s jaxmeapi-${PV}.jar jaxmeapi.jar
-	oe_jarinstall -s jaxmejs-${PV}.jar jaxmejs.jar
-	oe_jarinstall -s jaxmexs-${PV}.jar jaxmexs.jar
-	oe_jarinstall -s jaxmepm-${PV}.jar jaxmepm.jar
-}
-
 # Compile helper
 # 1 - source dir
 # 2 - dest dir
recipes/xml-commons/xpp3_1.1.3.4.O.bb +0 -4
index 11b82ab..40f7cb2 100644
@@ -42,10 +42,6 @@ do_install_append() {
 	oe_jarinstall xpp3-xpath-${PV}.jar xpp3-xpath.jar
 }
 
-do_stage_append() {
-	oe_jarinstall -s xpp3-xpath-${PV}.jar xpp3-xpath.jar
-}
-
 FILES_libxpp3-xpath-java = "${datadir}/java/xpp3-xpath*"
 
 
#4 lore raw
In reply to Khem Raj

classes/java-library.bbclass do_install() { · line 67

Quoted 13 lines · Khem Raj
---
 classes/java-library.bbclass |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
classes/java-library.bbclass +0 -0
index 904b4f1..5ce0537 100644
@@ -65,7 +65,3 @@ do_install() {
 java_stage() {
   oe_jarinstall -s ${JARFILENAME} ${ALTJARFILENAMES}
 }

Shouldn't you remove this java_stage function as well, as it won't be called anymore.

Quoted 4 lines
classes/java-library.bbclass +0 -4
-
-do_stage() {
-  java_stage
-}
author
#5 lore raw
Quoted 6 lines · Fahad
Quoted 5 lines · Khem Raj

---
 classes/java-library.bbclass |    4 ----

 1 files changed, 0 insertions(+), 4 deletions(-)
Quoted 10 lines

classes/java-library.bbclass do_install() { · line 67

Quoted 8 lines
classes/java-library.bbclass +0 -0
index 904b4f1..5ce0537 100644
@@ -65,7 +65,3 @@ do_install() {
  java_stage() {
    oe_jarinstall -s ${JARFILENAME} ${ALTJARFILENAMES}
  }

Shouldn't you remove this java_stage function as well, as it won't be called anymore.

its still used in do_install. but yes there can be some cleanup done there. I did
minimum to fix it.

Quoted 11 lines

classes/java-library.bbclass do_install() { · line 71

Quoted 4 lines
classes/java-library.bbclass +0 -4
-
-do_stage() {
-  java_stage
-}

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel